modxcms/revolution

View on GitHub

Showing 4,334 of 7,873 total issues

Avoid too many return statements within this method.
Open

                            return false;
Severity: Major
Found in core/model/phpthumb/phpthumb.class.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                        return $this->ErrorImage('Neither GD nor ImageMagick seem to be installed on this server. At least one (preferably GD), or better both, MUST be installed for phpThumb to work.');
    Severity: Major
    Found in core/model/phpthumb/phpthumb.class.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in core/model/phpthumb/phpthumb.class.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                            return $this->ErrorImage('Image (GIF) is too large for PHP-GD memory_limit, please install ImageMagick or increase php.ini memory_limit setting');
        Severity: Major
        Found in core/model/phpthumb/phpthumb.class.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return gettype($var);
          Severity: Major
          Found in core/model/phpthumb/phpthumb.class.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                        return false;
            Severity: Major
            Found in core/model/phpthumb/phpthumb.class.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                  return $gdimg_source;
              Severity: Major
              Found in core/model/phpthumb/phpthumb.class.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                        return $this->ErrorImage('include_once('. __DIR__ .'/phpthumb.bmp.php) failed');
                Severity: Major
                Found in core/model/phpthumb/phpthumb.class.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                      return $this->ErrorImage('Unable to create image, neither filename nor image data suppplied in SourceImageToGD() ['.__LINE__.']');
                  Severity: Major
                  Found in core/model/phpthumb/phpthumb.class.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                        return $this->ErrorImage($this->ImageMagickVersion() ? 'ImageMagick and GhostScript are both required for PDF source images; GhostScript may not be properly configured' : 'ImageMagick and/or GhostScript are unavailable and phpThumb() does not support PDF source images without them');
                    Severity: Major
                    Found in core/model/phpthumb/phpthumb.class.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return 'float       '.$var;
                      Severity: Major
                      Found in core/model/phpthumb/phpthumb.class.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return $this->ErrorImage($ErrorMessage);
                        Severity: Major
                        Found in core/model/phpthumb/phpthumb.class.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                              return $this->ErrorImage($this->ImageMagickVersion() ? 'ImageMagick failed on WMF source conversion' : 'ImageMagick is unavailable and phpThumb() does not support WMF source images without it');
                          Severity: Major
                          Found in core/model/phpthumb/phpthumb.class.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return $this->ErrorImage('Unknown image type identified by "'.$HeaderFourBytes.'" ('.phpthumb_functions::HexCharDisplay($HeaderFourBytes).') in SourceImageToGD() ['.__LINE__.']');
                            Severity: Major
                            Found in core/model/phpthumb/phpthumb.class.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                                  return $this->ErrorImage('Image (PNG) is too large for PHP-GD memory_limit, please install ImageMagick or increase php.ini memory_limit setting');
                              Severity: Major
                              Found in core/model/phpthumb/phpthumb.class.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                        return false;
                                Severity: Major
                                Found in core/model/phpthumb/phpthumb.class.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                              return false;
                                  Severity: Major
                                  Found in core/model/phpthumb/modphpthumb.class.php - About 30 mins to fix

                                    Function Lexicon has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                    MODx.grid.Lexicon = function(config) {
                                        config = config || {};
                                        Ext.applyIf(config,{
                                            id: 'modx-grid-lexicon'
                                            ,url: MODx.config.connector_url
                                    Severity: Minor
                                    Found in manager/assets/modext/workspace/lexicon/lexicon.grid.js - About 25 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Function updateHidden has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                    Ext.form.XCheckbox=Ext.extend(Ext.form.Checkbox,{submitOffValue:0,submitOnValue:1,onRender:function(){this.inputValue=this.submitOnValue;Ext.form.XCheckbox.superclass.onRender.apply(this,arguments);this.hiddenField=this.wrap.insertFirst({tag:'input',type:'hidden'});if(this.tooltip){this.imageEl.set({qtip:this.tooltip})}this.updateHidden()},setValue:function(v){v=this.convertValue(v);this.updateHidden(v);Ext.form.XCheckbox.superclass.setValue.apply(this,arguments)},updateHidden:function(v){v=undefined!==v?v:this.checked;v=this.convertValue(v);if(this.hiddenField){this.hiddenField.dom.value=v?this.submitOnValue:this.submitOffValue;this.hiddenField.dom.name=v?'':this.el.dom.name}},convertValue:function(v){return(v===true||v==='true'||v===this.submitOnValue||String(v).toLowerCase()==='on')}});Ext.reg('xcheckbox',Ext.form.XCheckbox);
                                    Severity: Minor
                                    Found in manager/assets/modext/util/utilities.js - About 25 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Function onSpecialKey has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                        ,onSpecialKey:function(t, e) {
                                            var key = e.getKey();
                                            if(key === e.TAB) {
                                                if(t === this.df && !e.shiftKey) {
                                                    e.stopEvent();
                                    Severity: Minor
                                    Found in manager/assets/modext/util/datetime.js - About 25 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language