Sign upLogin

modxcms/revolution

View on GitHub
Star
manager/assets/modext/sections/security/profile/update.js

Summary

Maintainability
C
1 day
Test Coverage

Function UpdateProfile has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

MODx.panel.UpdateProfile = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        title: _('general_information')
        ,id: 'modx-panel-profile-update'
Severity: Major
Found in manager/assets/modext/sections/security/profile/update.js - About 3 hrs to fix

    Function ChangeProfilePassword has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    MODx.panel.ChangeProfilePassword = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        title: _('reset_password')
        ,url: MODx.config.connector_url
    Severity: Major
    Found in manager/assets/modext/sections/security/profile/update.js - About 2 hrs to fix

      Function getTabs has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          getTabs: function(config) {
        var items = [{
            xtype: 'modx-panel-profile-update'
            ,id: 'modx-panel-profile-update'
            ,user: config.user
      Severity: Minor
      Found in manager/assets/modext/sections/security/profile/update.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        MODx.page.Profile = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        components: [{
            xtype: 'modx-panel-profile'
        Severity: Major
        Found in manager/assets/modext/sections/security/profile/update.js and 1 other location - About 3 hrs to fix
        manager/assets/modext/sections/security/message/list.js on lines 7..16

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 98.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status