Sign upLogin

modxcms/revolution

View on GitHub
Star
manager/assets/modext/util/lightbox.js

Summary

Maintainability
F
3 days
Test Coverage

Function Lightbox has 316 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Ext.ux.Lightbox = (function(){
    var els = {},
        images = [],
        activeImage,
        initialized = false,
Severity: Major
Found in manager/assets/modext/util/lightbox.js - About 1 day to fix

    Function Lightbox has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
    Open

    Ext.ux.Lightbox = (function(){
    var els = {},
        images = [],
        activeImage,
        initialized = false,
    Severity: Minor
    Found in manager/assets/modext/util/lightbox.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File lightbox.js has 320 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    Ext.ns('Ext.ux');

Ext.ux.Lightbox = (function(){
    var els = {},
        images = [],
    Severity: Minor
    Found in manager/assets/modext/util/lightbox.js - About 3 hrs to fix

      Function open has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              open: function(image, sel, group) {
            group = group || false;
            this.setViewSize();
            els.overlay.fadeIn({
                duration: this.overlayDuration,
      Severity: Minor
      Found in manager/assets/modext/util/lightbox.js - About 1 hr to fix

        Function getTemplate has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                getTemplate : function() {
            return [
                '<div id="ux-lightbox">',
                    '<div id="ux-lightbox-outerImageContainer">',
                        '<div id="ux-lightbox-imageContainer">',
        Severity: Minor
        Found in manager/assets/modext/util/lightbox.js - About 1 hr to fix

          Function resizeImage has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  resizeImage: function(w, h){
            var wCur = els.outerImageContainer.getWidth();
            var hCur = els.outerImageContainer.getHeight();
           
            var wNew = (w + this.borderSize * 2);
          Severity: Minor
          Found in manager/assets/modext/util/lightbox.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        els.navPrev.on('click', function(ev) {
                ev.preventDefault();
                this.setImage(activeImage - 1);
            }, this);
            Severity: Minor
            Found in manager/assets/modext/util/lightbox.js and 1 other location - About 40 mins to fix
            manager/assets/modext/util/lightbox.js on lines 117..120

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        els.navNext.on('click', function(ev) {
                ev.preventDefault();
                this.setImage(activeImage + 1);
            }, this);
            Severity: Minor
            Found in manager/assets/modext/util/lightbox.js and 1 other location - About 40 mins to fix
            manager/assets/modext/util/lightbox.js on lines 112..115

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 48.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status