modxcms/revolution

View on GitHub
manager/assets/modext/util/multiuploaddialog.js

Summary

Maintainability
F
3 days
Test Coverage

File multiuploaddialog.js has 447 lines of code (exceeds 250 allowed). Consider refactoring.
Open

(function(){
    var maxFileSize = parseInt(MODx.config['upload_maxsize'], 10);
    var permittedFileTypes = MODx.config['upload_files'].toLowerCase().split(',');

    FileAPI.debug = false;
Severity: Minor
Found in manager/assets/modext/util/multiuploaddialog.js - About 6 hrs to fix

    Function Dialog has 90 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        MODx.util.MultiUploadDialog.Dialog = function(config) {
            this.filesGridId = Ext.id();
    
            config = config || {};
            Ext.applyIf(config,{
    Severity: Major
    Found in manager/assets/modext/util/multiuploaddialog.js - About 3 hrs to fix

      Function FilesGrid has 73 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          MODx.util.MultiUploadDialog.FilesGrid = function(config) {
              config = config || {};
              Ext.applyIf(config,{
                  height: 300
                  ,autoScroll: true
      Severity: Major
      Found in manager/assets/modext/util/multiuploaddialog.js - About 2 hrs to fix

        Function startUpload has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                startUpload: function(){
                    var dialog = this;
                    var files = [];
                    var params = Ext.apply(this.base_params, {
                        'HTTP_MODAUTH': MODx.siteId
        Severity: Minor
        Found in manager/assets/modext/util/multiuploaddialog.js - About 1 hr to fix

          Function addFiles has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  addFiles: function(files){
                      var store = Ext.getCmp(this.filesGridId).getStore();
                      var dialog = this;
                      FileAPI.each(files, function(file){
                          var permitted = true;
          Severity: Minor
          Found in manager/assets/modext/util/multiuploaddialog.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    initComponent : function()
                    {
                        MODx.util.MultiUploadDialog.BrowseButton.superclass.initComponent.call(this);
                        this.original_handler = this.handler || null;
                        this.original_scope = this.scope || window;
            Severity: Major
            Found in manager/assets/modext/util/multiuploaddialog.js and 1 other location - About 3 hrs to fix
            manager/assets/modext/util/uploaddialog.js on lines 250..257

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 103.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        if(this.tooltip){
                            if(typeof this.tooltip == 'object'){
                                Ext.QuickTips.register(Ext.apply({target: this.input_file}, this.tooltip));
                            }
                            else {
            Severity: Major
            Found in manager/assets/modext/util/multiuploaddialog.js and 1 other location - About 3 hrs to fix
            manager/assets/modext/util/uploaddialog.js on lines 303..310

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 97.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    destroy : function()
                    {
                        var input_file = this.detachInputFile(true);
            
                        input_file.remove();
            Severity: Major
            Found in manager/assets/modext/util/multiuploaddialog.js and 1 other location - About 2 hrs to fix
            manager/assets/modext/util/uploaddialog.js on lines 369..375

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 75.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (typeof this.tooltip == 'object') {
                            Ext.QuickTips.unregister(this.input_file);
                        }
                        else {
                            this.input_file.dom[this.tooltipType] = null;
            Severity: Major
            Found in manager/assets/modext/util/multiuploaddialog.js and 1 other location - About 1 hr to fix
            manager/assets/modext/util/uploaddialog.js on lines 325..330

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    disable : function()
                    {
                        MODx.util.MultiUploadDialog.BrowseButton.superclass.disable.call(this);
                        this.input_file.dom.disabled = true;
                    },
            Severity: Major
            Found in manager/assets/modext/util/multiuploaddialog.js and 3 other locations - About 1 hr to fix
            manager/assets/modext/util/multiuploaddialog.js on lines 162..166
            manager/assets/modext/util/uploaddialog.js on lines 351..355
            manager/assets/modext/util/uploaddialog.js on lines 360..364

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    enable : function()
                    {
                        MODx.util.MultiUploadDialog.BrowseButton.superclass.enable.call(this);
                        this.input_file.dom.disabled = false;
                    },
            Severity: Major
            Found in manager/assets/modext/util/multiuploaddialog.js and 3 other locations - About 1 hr to fix
            manager/assets/modext/util/multiuploaddialog.js on lines 153..157
            manager/assets/modext/util/uploaddialog.js on lines 351..355
            manager/assets/modext/util/uploaddialog.js on lines 360..364

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    onRender : function(ct, position)
                    {
                        MODx.util.MultiUploadDialog.BrowseButton.superclass.onRender.call(this, ct, position);
                        this.createInputFile();
                    },
            Severity: Major
            Found in manager/assets/modext/util/multiuploaddialog.js and 1 other location - About 1 hr to fix
            manager/assets/modext/util/uploaddialog.js on lines 262..266

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (this.handleMouseEvents) {
                            this.input_file.on('mouseover', this.onMouseOver, this);
                            this.input_file.on('mousedown', this.onMouseDown, this);
                        }
            Severity: Minor
            Found in manager/assets/modext/util/multiuploaddialog.js and 1 other location - About 35 mins to fix
            manager/assets/modext/util/uploaddialog.js on lines 298..301

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status