Sign upLogin

modxcms/revolution

View on GitHub
Star
manager/assets/modext/widgets/core/modx.grid.settings.js

Summary

Maintainability
F
6 days
Test Coverage

File modx.grid.settings.js has 606 lines of code (exceeds 250 allowed). Consider refactoring.
Open

MODx.grid.SettingsGrid = function(config) {
    config = config || {};
    this.exp = new Ext.grid.RowExpander({
        tpl : new Ext.XTemplate(
            '<p class="desc">{[MODx.util.safeHtml(values.description_trans)]}</p>'
Severity: Major
Found in manager/assets/modext/widgets/core/modx.grid.settings.js - About 1 day to fix

    Function SettingsGrid has 176 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    MODx.grid.SettingsGrid = function(config) {
    config = config || {};
    this.exp = new Ext.grid.RowExpander({
        tpl : new Ext.XTemplate(
            '<p class="desc">{[MODx.util.safeHtml(values.description_trans)]}</p>'
    Severity: Major
    Found in manager/assets/modext/widgets/core/modx.grid.settings.js - About 7 hrs to fix

      Function CreateSetting has 119 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      MODx.window.CreateSetting = function(config) {
    config = config || {};
    config.keyField = config.keyField || {};
    Ext.applyIf(config,{
        title: _('setting_create')
      Severity: Major
      Found in manager/assets/modext/widgets/core/modx.grid.settings.js - About 4 hrs to fix

        Function UpdateSetting has 117 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        MODx.window.UpdateSetting = function(config) {
    config = config || {};
    this.ident = config.ident || 'modx-uss-'+Ext.id();
    Ext.applyIf(config,{
        title: _('setting_update')
        Severity: Major
        Found in manager/assets/modext/widgets/core/modx.grid.settings.js - About 4 hrs to fix

          Function SettingsGrid has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

          MODx.grid.SettingsGrid = function(config) {
    config = config || {};
    this.exp = new Ext.grid.RowExpander({
        tpl : new Ext.XTemplate(
            '<p class="desc">{[MODx.util.safeHtml(values.description_trans)]}</p>'
          Severity: Minor
          Found in manager/assets/modext/widgets/core/modx.grid.settings.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function UpdateSetting has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          MODx.window.UpdateSetting = function(config) {
    config = config || {};
    this.ident = config.ident || 'modx-uss-'+Ext.id();
    Ext.applyIf(config,{
        title: _('setting_update')
          Severity: Minor
          Found in manager/assets/modext/widgets/core/modx.grid.settings.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function xType has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          MODx.combo.xType = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        store: new Ext.data.SimpleStore({
            fields: ['d','v']
          Severity: Minor
          Found in manager/assets/modext/widgets/core/modx.grid.settings.js - About 1 hr to fix

            Function renderDynField has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                ,renderDynField: function(v,md,rec,ri,ci,s,g) {
        var r = s.getAt(ri).data;
        v = Ext.util.Format.htmlEncode(v);
        var f;
        if (r.xtype == 'combo-boolean' || r.xtype == 'modx-combo-boolean') {
            Severity: Minor
            Found in manager/assets/modext/widgets/core/modx.grid.settings.js - About 1 hr to fix

              Function renderDynField has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  ,renderDynField: function(v,md,rec,ri,ci,s,g) {
        var r = s.getAt(ri).data;
        v = Ext.util.Format.htmlEncode(v);
        var f;
        if (r.xtype == 'combo-boolean' || r.xtype == 'modx-combo-boolean') {
              Severity: Minor
              Found in manager/assets/modext/widgets/core/modx.grid.settings.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function renderDynField has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  ,renderDynField: function(v,md,rec,ri,ci,s,g) {
              Severity: Major
              Found in manager/assets/modext/widgets/core/modx.grid.settings.js - About 50 mins to fix

                Avoid too many return statements within this function.
                Open

                        return v;
                Severity: Major
                Found in manager/assets/modext/widgets/core/modx.grid.settings.js - About 30 mins to fix

                  Similar blocks of code found in 11 locations. Consider refactoring.
                  Open

                      },{
        xtype: 'textfield'
        ,name: 'filter_key'
        ,id: 'modx-filter-key'
        ,cls: 'x-form-filter'
                  Severity: Major
                  Found in manager/assets/modext/widgets/core/modx.grid.settings.js and 10 other locations - About 4 hrs to fix
                  manager/assets/modext/widgets/element/modx.grid.plugin.event.js on lines 89..105
                  manager/assets/modext/widgets/element/modx.grid.template.tv.js on lines 85..101
                  manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 83..99
                  manager/assets/modext/widgets/security/modx.grid.message.js on lines 141..157
                  manager/assets/modext/widgets/security/modx.grid.user.js on lines 130..146
                  manager/assets/modext/widgets/source/modx.panel.sources.js on lines 94..110
                  manager/assets/modext/widgets/system/modx.grid.context.js on lines 55..71
                  manager/assets/modext/widgets/system/modx.grid.dashboard.widgets.js on lines 55..71
                  manager/assets/modext/workspace/namespace/modx.namespace.panel.js on lines 84..100
                  manager/assets/modext/workspace/package.grid.js on lines 99..115

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 126.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 3 locations. Consider refactoring.
                  Open

                          ,tools: [{
            id: 'plus'
            ,qtip: _('expand_all')
            ,handler: this.expandAll
            ,scope: this
                  Severity: Major
                  Found in manager/assets/modext/widgets/core/modx.grid.settings.js and 2 other locations - About 1 hr to fix
                  manager/assets/modext/widgets/element/modx.grid.element.properties.js on lines 158..169
                  manager/assets/modext/widgets/source/modx.grid.source.properties.js on lines 54..65

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 71.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                                  },{
                    xtype: 'textarea'
                    ,fieldLabel: _('description')
                    ,description: MODx.expandHelp ? '' : _('description_desc')
                    ,name: 'description'
                  Severity: Major
                  Found in manager/assets/modext/widgets/core/modx.grid.settings.js and 1 other location - About 1 hr to fix
                  manager/assets/modext/widgets/security/modx.tree.user.group.js on lines 213..221

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 67.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                                  },{
                    xtype: 'textfield'
                    ,fieldLabel: _('name')
                    ,description: MODx.expandHelp ? '' : _('name_desc')
                    ,name: 'name'
                  Severity: Major
                  Found in manager/assets/modext/widgets/core/modx.grid.settings.js and 4 other locations - About 1 hr to fix
                  manager/assets/modext/widgets/core/modx.grid.settings.js on lines 622..629
                  manager/assets/modext/widgets/security/modx.tree.user.group.js on lines 226..233
                  manager/assets/modext/widgets/windows.js on lines 331..338
                  manager/assets/modext/widgets/windows.js on lines 344..351

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 62.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                                  },{
                    xtype: 'textfield'
                    ,fieldLabel: _('area_lexicon_string')
                    ,description: MODx.expandHelp ? '' : _('area_lexicon_string_msg')
                    ,name: 'area'
                  Severity: Major
                  Found in manager/assets/modext/widgets/core/modx.grid.settings.js and 4 other locations - About 1 hr to fix
                  manager/assets/modext/widgets/core/modx.grid.settings.js on lines 570..577
                  manager/assets/modext/widgets/security/modx.tree.user.group.js on lines 226..233
                  manager/assets/modext/widgets/windows.js on lines 331..338
                  manager/assets/modext/widgets/windows.js on lines 344..351

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 62.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 3 locations. Consider refactoring.
                  Open

                      _addEnterKeyHandler: function() {
        this.getEl().addKeyListener(Ext.EventObject.ENTER,function() {
            this.fireEvent('change');
        },this);
    }
                  Severity: Major
                  Found in manager/assets/modext/widgets/core/modx.grid.settings.js and 2 other locations - About 55 mins to fix
                  manager/assets/modext/widgets/modx.panel.search.js on lines 231..235
                  manager/assets/modext/widgets/system/modx.grid.manager.log.js on lines 200..204

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 54.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          },{
            header: _('value')
            ,dataIndex: 'value'
            ,sortable: true
            ,editable: true
                  Severity: Minor
                  Found in manager/assets/modext/widgets/core/modx.grid.settings.js and 1 other location - About 50 mins to fix
                  manager/assets/modext/widgets/core/modx.grid.settings.js on lines 104..111

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 52.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                          },{
            header: _('last_modified')
            ,dataIndex: 'editedon'
            ,sortable: true
            ,editable: false
                  Severity: Minor
                  Found in manager/assets/modext/widgets/core/modx.grid.settings.js and 1 other location - About 50 mins to fix
                  manager/assets/modext/widgets/core/modx.grid.settings.js on lines 97..104

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 52.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status