Sign upLogin

modxcms/revolution

View on GitHub
Star
manager/assets/modext/widgets/core/modx.searchbar.js

Summary

Maintainability
C
1 day
Test Coverage

Function SearchBar has 113 lines of code (exceeds 25 allowed). Consider refactoring.
Open

MODx.SearchBar = function(config) {
    config = config || {};

    Ext.applyIf(config, {
        renderTo: 'modx-manager-search'
Severity: Major
Found in manager/assets/modext/widgets/core/modx.searchbar.js - About 4 hrs to fix

    Function initList has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        ,initList : function() {
        if(!this.list){
            var cls = 'x-combo-list',
                listParent = Ext.getDom(this.getListParent() || Ext.getBody());
    Severity: Major
    Found in manager/assets/modext/widgets/core/modx.searchbar.js - About 2 hrs to fix

      Function initList has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          ,initList : function() {
        if(!this.list){
            var cls = 'x-combo-list',
                listParent = Ext.getDom(this.getListParent() || Ext.getBody());
      Severity: Minor
      Found in manager/assets/modext/widgets/core/modx.searchbar.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function SearchBar has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      MODx.SearchBar = function(config) {
    config = config || {};

    Ext.applyIf(config, {
        renderTo: 'modx-manager-search'
      Severity: Minor
      Found in manager/assets/modext/widgets/core/modx.searchbar.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getClass has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                      getClass: function(values) {
                    if (values.icon) {
                        return values.icon;
                    }
      Severity: Minor
      Found in manager/assets/modext/widgets/core/modx.searchbar.js - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status