Sign upLogin

modxcms/revolution

View on GitHub
Star
manager/assets/modext/widgets/element/modx.grid.plugin.event.js

Summary

Maintainability
D
2 days
Test Coverage

File modx.grid.plugin.event.js has 373 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Loads a grid of Plugin Events
 *
 * @class MODx.grid.PluginEvent
 * @extends MODx.grid.Grid
Severity: Minor
Found in manager/assets/modext/widgets/element/modx.grid.plugin.event.js - About 4 hrs to fix

    Function PluginEvent has 112 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    MODx.grid.PluginEvent = function(config) {
    config = config || {};
    this.ident = config.ident || 'grid-pluge'+Ext.id();
    var ec = new Ext.ux.grid.CheckColumn({
        header: _('enabled')
    Severity: Major
    Found in manager/assets/modext/widgets/element/modx.grid.plugin.event.js - About 4 hrs to fix

      Function PluginEventAssoc has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      MODx.grid.PluginEventAssoc = function(config) {
    config = config || {};
    this.ident = config.ident || 'grid-pluge-assoc'+Ext.id();
    Ext.applyIf(config,{
        title: _('plugins')
      Severity: Major
      Found in manager/assets/modext/widgets/element/modx.grid.plugin.event.js - About 2 hrs to fix

        Function AddPluginToEvent has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        MODx.window.AddPluginToEvent = function(config) {
    config = config || {};
    this.ident = config.ident || 'apluge'+Ext.id();
    Ext.applyIf(config,{
        title: _('plugin_add_to_event')
        Severity: Minor
        Found in manager/assets/modext/widgets/element/modx.grid.plugin.event.js - About 1 hr to fix

          Similar blocks of code found in 11 locations. Consider refactoring.
          Open

                  },{
            xtype: 'textfield'
            ,name: 'search'
            ,id: 'modx-plugin-event-search'
            ,cls: 'x-form-filter'
          Severity: Major
          Found in manager/assets/modext/widgets/element/modx.grid.plugin.event.js and 10 other locations - About 4 hrs to fix
          manager/assets/modext/widgets/core/modx.grid.settings.js on lines 54..70
          manager/assets/modext/widgets/element/modx.grid.template.tv.js on lines 85..101
          manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 83..99
          manager/assets/modext/widgets/security/modx.grid.message.js on lines 141..157
          manager/assets/modext/widgets/security/modx.grid.user.js on lines 130..146
          manager/assets/modext/widgets/source/modx.panel.sources.js on lines 94..110
          manager/assets/modext/widgets/system/modx.grid.context.js on lines 55..71
          manager/assets/modext/widgets/system/modx.grid.dashboard.widgets.js on lines 55..71
          manager/assets/modext/workspace/namespace/modx.namespace.panel.js on lines 84..100
          manager/assets/modext/workspace/package.grid.js on lines 99..115

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 126.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  this.getStore().baseParams.group = Ext.isEmpty(nv) || Ext.isObject(nv) ? cb.getValue() : nv;
          Severity: Major
          Found in manager/assets/modext/widgets/element/modx.grid.plugin.event.js and 2 other locations - About 1 hr to fix
          manager/assets/modext/widgets/security/modx.grid.user.js on lines 320..320
          manager/assets/modext/widgets/system/modx.panel.dashboards.js on lines 238..238

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  ,fields: [{
            fieldLabel: _('name')
            ,name: 'name'
            ,id: 'modx-'+this.ident+'-name'
            ,xtype: 'statictextfield'
          Severity: Minor
          Found in manager/assets/modext/widgets/element/modx.grid.plugin.event.js and 1 other location - About 40 mins to fix
          manager/assets/modext/widgets/system/modx.grid.content.type.js on lines 249..256

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      ,editor: {
                xtype: 'modx-combo-property-set'
                ,renderer: true
                ,baseParams: {
                    action: 'element/propertyset/getList'
          Severity: Minor
          Found in manager/assets/modext/widgets/element/modx.grid.plugin.event.js and 1 other location - About 35 mins to fix
          manager/assets/modext/widgets/element/modx.grid.plugin.event.js on lines 256..265

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      ,editor: {
                xtype: 'modx-combo-property-set'
                ,renderer: true
                ,baseParams: {
                    action: 'element/propertyset/getList'
          Severity: Minor
          Found in manager/assets/modext/widgets/element/modx.grid.plugin.event.js and 1 other location - About 35 mins to fix
          manager/assets/modext/widgets/element/modx.grid.plugin.event.js on lines 60..69

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status