Sign upLogin

modxcms/revolution

View on GitHub
Star
manager/assets/modext/widgets/fc/modx.grid.fcprofile.js

Summary

Maintainability
F
5 days
Test Coverage

File modx.grid.fcprofile.js has 346 lines of code (exceeds 250 allowed). Consider refactoring.
Open

MODx.panel.FCProfiles = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        id: 'modx-panel-fc-profiles'
        ,cls: 'container'
Severity: Minor
Found in manager/assets/modext/widgets/fc/modx.grid.fcprofile.js - About 4 hrs to fix

    Function FCProfile has 101 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    MODx.grid.FCProfile = function(config) {
    config = config || {};
    this.sm = new Ext.grid.CheckboxSelectionModel();
    Ext.applyIf(config,{
        id: 'modx-grid-fc-profile'
    Severity: Major
    Found in manager/assets/modext/widgets/fc/modx.grid.fcprofile.js - About 4 hrs to fix

      Function getMenu has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          getMenu: function() {
        var r = this.getSelectionModel().getSelected();
        var p = r.data.perm;

        var m = [];
      Severity: Minor
      Found in manager/assets/modext/widgets/fc/modx.grid.fcprofile.js - About 1 hr to fix

        Function CreateFCProfile has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        MODx.window.CreateFCProfile = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        title: _('profile_create')
        ,url: MODx.config.connector_url
        Severity: Minor
        Found in manager/assets/modext/widgets/fc/modx.grid.fcprofile.js - About 1 hr to fix

          Function getMenu has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              getMenu: function() {
        var r = this.getSelectionModel().getSelected();
        var p = r.data.perm;

        var m = [];
          Severity: Minor
          Found in manager/assets/modext/widgets/fc/modx.grid.fcprofile.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function FCProfiles has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          MODx.panel.FCProfiles = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        id: 'modx-panel-fc-profiles'
        ,cls: 'container'
          Severity: Minor
          Found in manager/assets/modext/widgets/fc/modx.grid.fcprofile.js - About 1 hr to fix

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                ,deactivateSelected: function() {
        var cs = this.getSelectedAsList();
        if (cs === false) return false;

        MODx.Ajax.request({
            Severity: Major
            Found in manager/assets/modext/widgets/fc/modx.grid.fcprofile.js and 5 other locations - About 5 hrs to fix
            manager/assets/modext/widgets/fc/modx.grid.fcprofile.js on lines 250..268
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 280..298
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 311..329
            manager/assets/modext/widgets/security/modx.grid.user.js on lines 216..234
            manager/assets/modext/widgets/security/modx.grid.user.js on lines 235..253

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 139.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                ,activateSelected: function() {
        var cs = this.getSelectedAsList();
        if (cs === false) return false;

        MODx.Ajax.request({
            Severity: Major
            Found in manager/assets/modext/widgets/fc/modx.grid.fcprofile.js and 5 other locations - About 5 hrs to fix
            manager/assets/modext/widgets/fc/modx.grid.fcprofile.js on lines 281..299
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 280..298
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 311..329
            manager/assets/modext/widgets/security/modx.grid.user.js on lines 216..234
            manager/assets/modext/widgets/security/modx.grid.user.js on lines 235..253

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 139.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (this.getSelectionModel().getCount() > 1) {
            m.push({
                text: _('selected_activate')
                ,handler: this.activateSelected
            });
            Severity: Major
            Found in manager/assets/modext/widgets/fc/modx.grid.fcprofile.js and 1 other location - About 3 hrs to fix
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 121..168

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

                ,duplicateProfile: function(btn,e) {
        MODx.Ajax.request({
            url: this.config.url
            ,params: {
                action: 'security/forms/profile/duplicate'
            Severity: Major
            Found in manager/assets/modext/widgets/fc/modx.grid.fcprofile.js and 7 other locations - About 3 hrs to fix
            manager/assets/modext/widgets/fc/modx.grid.fcprofile.js on lines 237..248
            manager/assets/modext/widgets/fc/modx.grid.fcprofile.js on lines 269..280
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 254..265
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 267..278
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 299..310
            manager/assets/modext/widgets/source/modx.panel.sources.js on lines 164..175
            manager/assets/modext/widgets/system/modx.panel.dashboards.js on lines 220..231

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 95.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

                ,activateProfile: function(btn,e) {
        MODx.Ajax.request({
            url: this.config.url
            ,params: {
                action: 'security/forms/profile/activate'
            Severity: Major
            Found in manager/assets/modext/widgets/fc/modx.grid.fcprofile.js and 7 other locations - About 3 hrs to fix
            manager/assets/modext/widgets/fc/modx.grid.fcprofile.js on lines 224..235
            manager/assets/modext/widgets/fc/modx.grid.fcprofile.js on lines 269..280
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 254..265
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 267..278
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 299..310
            manager/assets/modext/widgets/source/modx.panel.sources.js on lines 164..175
            manager/assets/modext/widgets/system/modx.panel.dashboards.js on lines 220..231

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 95.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

                ,deactivateProfile: function(btn,e) {
        MODx.Ajax.request({
            url: this.config.url
            ,params: {
                action: 'security/forms/profile/deactivate'
            Severity: Major
            Found in manager/assets/modext/widgets/fc/modx.grid.fcprofile.js and 7 other locations - About 3 hrs to fix
            manager/assets/modext/widgets/fc/modx.grid.fcprofile.js on lines 224..235
            manager/assets/modext/widgets/fc/modx.grid.fcprofile.js on lines 237..248
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 254..265
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 267..278
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 299..310
            manager/assets/modext/widgets/source/modx.panel.sources.js on lines 164..175
            manager/assets/modext/widgets/system/modx.panel.dashboards.js on lines 220..231

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 95.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    },{
            text: _('bulk_actions')
            ,menu: [{
                text: _('selected_activate')
                ,handler: this.activateSelected
            Severity: Major
            Found in manager/assets/modext/widgets/fc/modx.grid.fcprofile.js and 2 other locations - About 2 hrs to fix
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 64..79
            manager/assets/modext/widgets/security/modx.grid.user.js on lines 100..115

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 92.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (r.data.active) {
                    m.push({
                        text: _('deactivate')
                        ,handler: this.deactivateProfile
                    });
            Severity: Major
            Found in manager/assets/modext/widgets/fc/modx.grid.fcprofile.js and 1 other location - About 2 hrs to fix
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 150..160

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 79.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (p.indexOf('premove') != -1) {
                m.push('-',{
                    text: _('remove')
                    ,handler: this.confirm.createDelegate(this,['security/forms/profile/remove','profile_remove_confirm'])
                });
            Severity: Major
            Found in manager/assets/modext/widgets/fc/modx.grid.fcprofile.js and 1 other location - About 1 hr to fix
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 162..167

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                    ,viewConfig: {
            forceFit:true
            ,enableRowBody:true
            ,scrollOffset: 0
            ,autoFill: true
            Severity: Major
            Found in manager/assets/modext/widgets/fc/modx.grid.fcprofile.js and 4 other locations - About 1 hr to fix
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 49..58
            manager/assets/modext/widgets/fc/modx.panel.fcset.js on lines 260..269
            manager/assets/modext/widgets/fc/modx.panel.fcset.js on lines 301..310
            manager/assets/modext/widgets/fc/modx.panel.fcset.js on lines 471..480

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                ,updateProfile: function(btn,e) {
        var r = this.menu.record;
        location.href = '?a=security/forms/profile/update&id='+r.id;
    }
            Severity: Minor
            Found in manager/assets/modext/widgets/fc/modx.grid.fcprofile.js and 1 other location - About 35 mins to fix
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 250..253

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status