Sign upLogin

modxcms/revolution

View on GitHub
Star
manager/assets/modext/widgets/resource/modx.grid.trash.js

Summary

Maintainability
F
1 wk
Test Coverage

File modx.grid.trash.js has 436 lines of code (exceeds 250 allowed). Consider refactoring.
Open

MODx.grid.Trash = function (config) {
    config = config || {};

    this.sm = new Ext.grid.CheckboxSelectionModel();
Severity: Minor
Found in manager/assets/modext/widgets/resource/modx.grid.trash.js - About 6 hrs to fix

    Function Trash has 125 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    MODx.grid.Trash = function (config) {
    config = config || {};

    this.sm = new Ext.grid.CheckboxSelectionModel();
    Severity: Major
    Found in manager/assets/modext/widgets/resource/modx.grid.trash.js - About 5 hrs to fix

      Function restoreAll has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          restoreAll: function () {
        var sm = this.getSelectionModel();
        sm.selectAll();
        var cs = this.getSelectedAsList();
        if (cs === false) return false;
      Severity: Minor
      Found in manager/assets/modext/widgets/resource/modx.grid.trash.js - About 1 hr to fix

        Function purgeAll has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            purgeAll: function () {
        var sm = this.getSelectionModel();
        sm.selectAll();
        var cs = this.getSelectedAsList();
        if (cs === false) return false;
        Severity: Minor
        Found in manager/assets/modext/widgets/resource/modx.grid.trash.js - About 1 hr to fix

          Function getMenu has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              getMenu: function () {
        var r = this.getSelectionModel().getSelected();
        var p = r.data.cls;

        var m = [];
          Severity: Minor
          Found in manager/assets/modext/widgets/resource/modx.grid.trash.js - About 1 hr to fix

            Function purgeSelected has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                purgeSelected: function () {
        var cs = this.getSelectedAsList();
        if (cs === false) return false;

        MODx.msg.confirm({
            Severity: Minor
            Found in manager/assets/modext/widgets/resource/modx.grid.trash.js - About 1 hr to fix

              Function restoreResource has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  restoreResource: function () {
        var withPublish = '';
        if (this.menu.record.published) {
            withPublish = '_with_publish';
        }
              Severity: Minor
              Found in manager/assets/modext/widgets/resource/modx.grid.trash.js - About 1 hr to fix

                Function restoreSelected has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    restoreSelected: function () {
        var cs = this.getSelectedAsList();
        if (cs === false) return false;

        MODx.msg.confirm({
                Severity: Minor
                Found in manager/assets/modext/widgets/resource/modx.grid.trash.js - About 1 hr to fix

                  Function renderTooltip has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      renderTooltip: function (value, metadata, record) {
        if (value) {
            var preview = ((record.json.pagetitle) ? '<p><strong>' + _('pagetitle') + ':</strong> ' + record.json.pagetitle + '</p>' : '')
                + ((record.json.longtitle) ? '<p><strong>' + _('long_title') + ':</strong> ' + record.json.longtitle + '</p>' : '')
                + ((record.data.parentPath) ? '<p><strong>' + _('trash.parent_path') + ':</strong> ' + record.data.parentPath + '</p>' : '')
                  Severity: Minor
                  Found in manager/assets/modext/widgets/resource/modx.grid.trash.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function purgeResource has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      purgeResource: function () {
        MODx.msg.confirm({
            title: _('trash.purge_confirm_title'),
            text: _('trash.purge_confirm_message', {
                'list': this.listResources('')
                  Severity: Minor
                  Found in manager/assets/modext/widgets/resource/modx.grid.trash.js - About 1 hr to fix

                    Function getMenu has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        getMenu: function () {
        var r = this.getSelectionModel().getSelected();
        var p = r.data.cls;

        var m = [];
                    Severity: Minor
                    Found in manager/assets/modext/widgets/resource/modx.grid.trash.js - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        restoreAll: function () {
        var sm = this.getSelectionModel();
        sm.selectAll();
        var cs = this.getSelectedAsList();
        if (cs === false) return false;
                    Severity: Major
                    Found in manager/assets/modext/widgets/resource/modx.grid.trash.js and 1 other location - About 1 day to fix
                    manager/assets/modext/widgets/resource/modx.grid.trash.js on lines 324..369

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 323.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        purgeAll: function () {
        var sm = this.getSelectionModel();
        sm.selectAll();
        var cs = this.getSelectedAsList();
        if (cs === false) return false;
                    Severity: Major
                    Found in manager/assets/modext/widgets/resource/modx.grid.trash.js and 1 other location - About 1 day to fix
                    manager/assets/modext/widgets/resource/modx.grid.trash.js on lines 371..416

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 323.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                            },{
            xtype: 'textfield',
            id: 'modx-trash-search',
            cls: 'x-form-filter',
            emptyText: _('search_ellipsis'),
                    Severity: Major
                    Found in manager/assets/modext/widgets/resource/modx.grid.trash.js and 1 other location - About 4 hrs to fix
                    manager/assets/modext/widgets/element/modx.grid.tv.template.js on lines 59..74

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 121.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                                listeners: {
                'success': {
                    fn: function (data) {
                        this.refreshEverything(data.total);
                    }, scope: this
                    Severity: Major
                    Found in manager/assets/modext/widgets/resource/modx.grid.trash.js and 2 other locations - About 3 hrs to fix
                    manager/assets/modext/widgets/resource/modx.grid.trash.js on lines 238..252
                    manager/assets/modext/widgets/resource/modx.grid.trash.js on lines 305..319

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 99.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                                listeners: {
                'success': {
                    fn: function (data) {
                        this.refreshEverything(data.total);
                    }, scope: this
                    Severity: Major
                    Found in manager/assets/modext/widgets/resource/modx.grid.trash.js and 2 other locations - About 3 hrs to fix
                    manager/assets/modext/widgets/resource/modx.grid.trash.js on lines 205..219
                    manager/assets/modext/widgets/resource/modx.grid.trash.js on lines 238..252

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 99.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 3 locations. Consider refactoring.
                    Open

                                listeners: {
                'success': {
                    fn: function (data) {
                        this.refreshEverything(data.total);
                    }, scope: this
                    Severity: Major
                    Found in manager/assets/modext/widgets/resource/modx.grid.trash.js and 2 other locations - About 3 hrs to fix
                    manager/assets/modext/widgets/resource/modx.grid.trash.js on lines 205..219
                    manager/assets/modext/widgets/resource/modx.grid.trash.js on lines 305..319

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 99.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                            }, {
            xtype: 'button',
            text: _('filter_clear'),
            id: 'modx-filter-clear',
            cls: 'x-form-filter-clear',
                    Severity: Major
                    Found in manager/assets/modext/widgets/resource/modx.grid.trash.js and 3 other locations - About 50 mins to fix
                    manager/assets/modext/widgets/resource/modx.grid.trash.js on lines 78..86
                    manager/assets/modext/widgets/resource/modx.grid.trash.js on lines 86..94
                    manager/assets/modext/widgets/system/modx.grid.manager.log.js on lines 115..123

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 52.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                            }, {
            xtype: 'button',
            text: _('trash.restore_all'),
            id: 'modx-restore-all',
            cls: 'x-btn-restore-all',
                    Severity: Major
                    Found in manager/assets/modext/widgets/resource/modx.grid.trash.js and 3 other locations - About 50 mins to fix
                    manager/assets/modext/widgets/resource/modx.grid.trash.js on lines 78..86
                    manager/assets/modext/widgets/resource/modx.grid.trash.js on lines 119..127
                    manager/assets/modext/widgets/system/modx.grid.manager.log.js on lines 115..123

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 52.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 4 locations. Consider refactoring.
                    Open

                            }, {
            xtype: 'button',
            text: _('trash.purge_all'),
            id: 'modx-purge-all',
            cls: 'x-btn-purge-all',
                    Severity: Major
                    Found in manager/assets/modext/widgets/resource/modx.grid.trash.js and 3 other locations - About 50 mins to fix
                    manager/assets/modext/widgets/resource/modx.grid.trash.js on lines 86..94
                    manager/assets/modext/widgets/resource/modx.grid.trash.js on lines 119..127
                    manager/assets/modext/widgets/system/modx.grid.manager.log.js on lines 115..123

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 52.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status