Sign upLogin

modxcms/revolution

View on GitHub
Star
manager/assets/modext/widgets/security/modx.grid.message.js

Summary

Maintainability
F
3 days
Test Coverage

File modx.grid.message.js has 396 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Loads the panel for managing user messages.
 *
 * @class MODx.panel.Messages
 * @extends MODx.FormPanel
Severity: Minor
Found in manager/assets/modext/widgets/security/modx.grid.message.js - About 5 hrs to fix

    Function Message has 109 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    MODx.grid.Message = function(config) {
    config = config || {};

    this.exp = new Ext.grid.RowExpander({
        tpl : new Ext.Template(
    Severity: Major
    Found in manager/assets/modext/widgets/security/modx.grid.message.js - About 4 hrs to fix

      Function getFields has 74 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          ,getFields: function() {
        var data = [];
        if (MODx.perm.view_user) data.push(['user',_('user')]);
        if (MODx.perm.view_usergroup) data.push(['usergroup',_('usergroup')]);
        if (MODx.perm.view_role) data.push(['role',_('role')]);
      Severity: Major
      Found in manager/assets/modext/widgets/security/modx.grid.message.js - About 2 hrs to fix

        Function Messages has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        MODx.panel.Messages = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        id: 'modx-panel-message'
        ,cls: 'container'
        Severity: Minor
        Found in manager/assets/modext/widgets/security/modx.grid.message.js - About 1 hr to fix

          Function getFields has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              ,getFields: function() {
        var data = [];
        if (MODx.perm.view_user) data.push(['user',_('user')]);
        if (MODx.perm.view_usergroup) data.push(['usergroup',_('usergroup')]);
        if (MODx.perm.view_role) data.push(['role',_('role')]);
          Severity: Minor
          Found in manager/assets/modext/widgets/security/modx.grid.message.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 11 locations. Consider refactoring.
          Open

                  },{
            xtype: 'textfield'
            ,name: 'search'
            ,id: 'modx-messages-search'
            ,cls: 'x-form-filter'
          Severity: Major
          Found in manager/assets/modext/widgets/security/modx.grid.message.js and 10 other locations - About 4 hrs to fix
          manager/assets/modext/widgets/core/modx.grid.settings.js on lines 54..70
          manager/assets/modext/widgets/element/modx.grid.plugin.event.js on lines 89..105
          manager/assets/modext/widgets/element/modx.grid.template.tv.js on lines 85..101
          manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 83..99
          manager/assets/modext/widgets/security/modx.grid.user.js on lines 130..146
          manager/assets/modext/widgets/source/modx.panel.sources.js on lines 94..110
          manager/assets/modext/widgets/system/modx.grid.context.js on lines 55..71
          manager/assets/modext/widgets/system/modx.grid.dashboard.widgets.js on lines 55..71
          manager/assets/modext/workspace/namespace/modx.namespace.panel.js on lines 84..100
          manager/assets/modext/workspace/package.grid.js on lines 99..115

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 126.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              ,clearFilter: function() {
        this.getStore().baseParams = {
            action: 'security/message/getList'
        };
        Ext.getCmp('modx-messages-search').reset();
          Severity: Major
          Found in manager/assets/modext/widgets/security/modx.grid.message.js and 1 other location - About 2 hrs to fix
          manager/assets/modext/widgets/security/modx.grid.user.js on lines 330..337

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 88.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              ,search: function(tf,newValue) {
        var nv = newValue || tf;
        this.getStore().baseParams.search = Ext.isEmpty(nv) || Ext.isObject(nv) ? '' : nv;
        this.getBottomToolbar().changePage(1);
        return true;
          Severity: Major
          Found in manager/assets/modext/widgets/security/modx.grid.message.js and 1 other location - About 2 hrs to fix
          manager/assets/modext/widgets/security/modx.grid.user.js on lines 324..329

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 84.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if (MODx.perm.view_usergroup) items.push({
            xtype: 'modx-combo-usergroup'
            ,id: 'mc-recipient-usergroup'
            ,fieldLabel: _('usergroup')
            ,allowBlank: true
          Severity: Major
          Found in manager/assets/modext/widgets/security/modx.grid.message.js and 2 other locations - About 55 mins to fix
          manager/assets/modext/widgets/security/modx.grid.message.js on lines 342..348
          manager/assets/modext/widgets/security/modx.grid.message.js on lines 356..362

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if (MODx.perm.view_role) items.push({
            xtype: 'modx-combo-role'
            ,id: 'mc-recipient-role'
            ,fieldLabel: _('role')
            ,allowBlank: true
          Severity: Major
          Found in manager/assets/modext/widgets/security/modx.grid.message.js and 2 other locations - About 55 mins to fix
          manager/assets/modext/widgets/security/modx.grid.message.js on lines 342..348
          manager/assets/modext/widgets/security/modx.grid.message.js on lines 349..355

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if (MODx.perm.view_user) items.push({
            xtype: 'modx-combo-user'
            ,id: 'mc-recipient-user'
            ,fieldLabel: _('user')
            ,allowBlank: true
          Severity: Major
          Found in manager/assets/modext/widgets/security/modx.grid.message.js and 2 other locations - About 55 mins to fix
          manager/assets/modext/widgets/security/modx.grid.message.js on lines 349..355
          manager/assets/modext/widgets/security/modx.grid.message.js on lines 356..362

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  if (MODx.user.id != r.data.sender) {
            m.push({
                text: _('delete')
                ,handler: this.remove.createDelegate(this, ['message_remove_confirm', 'security/message/remove'])
            });
          Severity: Minor
          Found in manager/assets/modext/widgets/security/modx.grid.message.js and 2 other locations - About 35 mins to fix
          manager/assets/modext/widgets/security/modx.grid.role.js on lines 66..71
          manager/assets/modext/workspace/namespace/modx.namespace.panel.js on lines 132..137

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (r.data.read && MODx.user.id != r.data.sender) {
            m.push({
                text: _('mark_unread')
                ,handler: this.markUnread
            });
          Severity: Minor
          Found in manager/assets/modext/widgets/security/modx.grid.message.js and 1 other location - About 30 mins to fix
          manager/assets/modext/widgets/security/modx.tree.user.group.js on lines 109..115

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status