Sign upLogin

modxcms/revolution

View on GitHub
Star
manager/assets/modext/widgets/security/modx.panel.access.policy.template.js

Summary

Maintainability
C
1 day
Test Coverage

Function AccessPolicyTemplate has 108 lines of code (exceeds 25 allowed). Consider refactoring.
Open

MODx.panel.AccessPolicyTemplate = function(config) {
    config = config || {};
    var r = config.record || {};
    Ext.applyIf(config,{
        url: MODx.config.connector_url
Severity: Major
Found in manager/assets/modext/widgets/security/modx.panel.access.policy.template.js - About 4 hrs to fix

    File modx.panel.access.policy.template.js has 289 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /**
 * Loads panel for editing an Access Policy Template
 *
 * @class MODx.panel.AccessPolicyTemplate
 * @extends MODx.FormPanel
    Severity: Minor
    Found in manager/assets/modext/widgets/security/modx.panel.access.policy.template.js - About 2 hrs to fix

      Function TemplatePermissions has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      MODx.grid.TemplatePermissions = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        id: 'modx-grid-template-permissions'
        ,fields: ['name','description','description_trans','value','menu']
      Severity: Minor
      Found in manager/assets/modext/widgets/security/modx.panel.access.policy.template.js - About 1 hr to fix

        Function AccessPolicyTemplate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        MODx.panel.AccessPolicyTemplate = function(config) {
    config = config || {};
    var r = config.record || {};
    Ext.applyIf(config,{
        url: MODx.config.connector_url
        Severity: Minor
        Found in manager/assets/modext/widgets/security/modx.panel.access.policy.template.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            ,beforeSubmit: function(o) {
        var g = Ext.getCmp('modx-grid-template-permissions');
        Ext.apply(o.form.baseParams,{
            permissions: g ? g.encode() : {}
        });
        Severity: Major
        Found in manager/assets/modext/widgets/security/modx.panel.access.policy.template.js and 1 other location - About 1 hr to fix
        manager/assets/modext/widgets/security/modx.panel.access.policy.js on lines 136..141

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            },{
                        xtype: 'textarea'
                        ,fieldLabel: _('description')
                        ,description: MODx.expandHelp ? '' : _('policy_template_desc_description')
                        ,name: 'description'
        Severity: Minor
        Found in manager/assets/modext/widgets/security/modx.panel.access.policy.template.js and 1 other location - About 45 mins to fix
        manager/assets/modext/widgets/security/modx.panel.access.policy.js on lines 71..78

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                if (this.config.template === '' || this.config.template === 0) {
            this.fireEvent('ready');
            return false;
        }
        Severity: Major
        Found in manager/assets/modext/widgets/security/modx.panel.access.policy.template.js and 3 other locations - About 40 mins to fix
        manager/assets/modext/widgets/resource/modx.panel.resource.data.js on lines 188..191
        manager/assets/modext/widgets/security/modx.panel.access.policy.js on lines 120..123
        manager/assets/modext/widgets/security/modx.panel.user.js on lines 46..49

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                ,items: [{
            html: _('policy_template')+(config.record ? ': '+config.record.name : '')
            ,id: 'modx-policy-template-header'
            ,xtype: 'modx-header'
        },{
        Severity: Minor
        Found in manager/assets/modext/widgets/security/modx.panel.access.policy.template.js and 1 other location - About 35 mins to fix
        manager/assets/modext/widgets/security/modx.panel.access.policy.js on lines 22..26

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status