Sign upLogin

modxcms/revolution

View on GitHub
Star
manager/assets/modext/widgets/security/modx.panel.user.group.js

Summary

Maintainability
F
6 days
Test Coverage

Function UserGroup has 289 lines of code (exceeds 25 allowed). Consider refactoring.
Open

MODx.panel.UserGroup = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        id: 'modx-panel-user-group'
        ,cls: 'container form-with-labels'
Severity: Major
Found in manager/assets/modext/widgets/security/modx.panel.user.group.js - About 1 day to fix

    File modx.panel.user.group.js has 533 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    MODx.panel.UserGroup = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        id: 'modx-panel-user-group'
        ,cls: 'container form-with-labels'
    Severity: Major
    Found in manager/assets/modext/widgets/security/modx.panel.user.group.js - About 1 day to fix

      Function UserGroupUsers has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      MODx.grid.UserGroupUsers = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        title: ''
        ,id: 'modx-grid-user-group-users'
      Severity: Major
      Found in manager/assets/modext/widgets/security/modx.panel.user.group.js - About 2 hrs to fix

        Function AddUserToUserGroup has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        MODx.window.AddUserToUserGroup = function(config) {
    config = config || {};
    this.ident = config.ident || 'auug'+Ext.id();
    Ext.applyIf(config,{
        title: _('user_group_user_add')
        Severity: Minor
        Found in manager/assets/modext/widgets/security/modx.panel.user.group.js - About 1 hr to fix

          Function UserGroup has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          MODx.panel.UserGroup = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        id: 'modx-panel-user-group'
        ,cls: 'container form-with-labels'
          Severity: Minor
          Found in manager/assets/modext/widgets/security/modx.panel.user.group.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                              },{
                        title: _('user_group_resourcegroup_access')
                        ,hidden: config.record.id === 0
                        ,hideMode: 'offsets'
                        ,layout: 'form'
          Severity: Major
          Found in manager/assets/modext/widgets/security/modx.panel.user.group.js and 2 other locations - About 7 hrs to fix
          manager/assets/modext/widgets/security/modx.panel.user.group.js on lines 218..240
          manager/assets/modext/widgets/security/modx.panel.user.group.js on lines 240..262

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 194.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                              },{
                        title: _('user_group_source_access')
                        ,hidden: config.record.id === 0
                        ,hideMode: 'offsets'
                        ,layout: 'form'
          Severity: Major
          Found in manager/assets/modext/widgets/security/modx.panel.user.group.js and 2 other locations - About 7 hrs to fix
          manager/assets/modext/widgets/security/modx.panel.user.group.js on lines 196..218
          manager/assets/modext/widgets/security/modx.panel.user.group.js on lines 218..240

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 194.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                              },{
                        title: _('user_group_category_access')
                        ,hidden: config.record.id === 0
                        ,hideMode: 'offsets'
                        ,layout: 'form'
          Severity: Major
          Found in manager/assets/modext/widgets/security/modx.panel.user.group.js and 2 other locations - About 7 hrs to fix
          manager/assets/modext/widgets/security/modx.panel.user.group.js on lines 196..218
          manager/assets/modext/widgets/security/modx.panel.user.group.js on lines 240..262

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 194.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status