Sign upLogin

modxcms/revolution

View on GitHub
Star
manager/assets/modext/widgets/source/modx.panel.sources.js

Summary

Maintainability
F
6 days
Test Coverage

Function Sources has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

MODx.grid.Sources = function(config) {
    config = config || {};

    this.sm = new Ext.grid.CheckboxSelectionModel();
    Ext.applyIf(config,{
Severity: Major
Found in manager/assets/modext/widgets/source/modx.panel.sources.js - About 3 hrs to fix

    File modx.panel.sources.js has 287 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    MODx.panel.Sources = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        id: 'modx-panel-sources'
        ,cls: 'container'
    Severity: Minor
    Found in manager/assets/modext/widgets/source/modx.panel.sources.js - About 2 hrs to fix

      Function Sources has 42 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      MODx.panel.Sources = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        id: 'modx-panel-sources'
        ,cls: 'container'
      Severity: Minor
      Found in manager/assets/modext/widgets/source/modx.panel.sources.js - About 1 hr to fix

        Function getMenu has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            getMenu: function() {
        var r = this.getSelectionModel().getSelected();
        var p = r.data.cls;

        var m = [];
        Severity: Minor
        Found in manager/assets/modext/widgets/source/modx.panel.sources.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getMenu has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            getMenu: function() {
        var r = this.getSelectionModel().getSelected();
        var p = r.data.cls;

        var m = [];
        Severity: Minor
        Found in manager/assets/modext/widgets/source/modx.panel.sources.js - About 1 hr to fix

          Function CreateSource has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          MODx.window.CreateSource = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        title: _('source_create')
        ,url: MODx.config.connector_url
          Severity: Minor
          Found in manager/assets/modext/widgets/source/modx.panel.sources.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                getMenu: function() {
        var r = this.getSelectionModel().getSelected();
        var p = r.data.cls;

        var m = [];
            Severity: Major
            Found in manager/assets/modext/widgets/source/modx.panel.sources.js and 1 other location - About 1 day to fix
            manager/assets/modext/widgets/system/modx.panel.dashboards.js on lines 143..178

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 352.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    ,items: [{
            html: _('sources')
            ,id: 'modx-sources-header'
            ,xtype: 'modx-header'
        },MODx.getPageStructure([{
            Severity: Major
            Found in manager/assets/modext/widgets/source/modx.panel.sources.js and 1 other location - About 1 day to fix
            manager/assets/modext/widgets/system/modx.panel.dashboards.js on lines 7..40

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 220.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 11 locations. Consider refactoring.
            Open

                    },'->',{
            xtype: 'textfield'
            ,name: 'search'
            ,id: 'modx-source-search'
            ,cls: 'x-form-filter'
            Severity: Major
            Found in manager/assets/modext/widgets/source/modx.panel.sources.js and 10 other locations - About 4 hrs to fix
            manager/assets/modext/widgets/core/modx.grid.settings.js on lines 54..70
            manager/assets/modext/widgets/element/modx.grid.plugin.event.js on lines 89..105
            manager/assets/modext/widgets/element/modx.grid.template.tv.js on lines 85..101
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 83..99
            manager/assets/modext/widgets/security/modx.grid.message.js on lines 141..157
            manager/assets/modext/widgets/security/modx.grid.user.js on lines 130..146
            manager/assets/modext/widgets/system/modx.grid.context.js on lines 55..71
            manager/assets/modext/widgets/system/modx.grid.dashboard.widgets.js on lines 55..71
            manager/assets/modext/workspace/namespace/modx.namespace.panel.js on lines 84..100
            manager/assets/modext/workspace/package.grid.js on lines 99..115

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 126.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                ,removeSource: function() {
        MODx.msg.confirm({
            title: _('source_remove')
            ,text: _('source_remove_confirm')
            ,url: this.config.url
            Severity: Major
            Found in manager/assets/modext/widgets/source/modx.panel.sources.js and 3 other locations - About 3 hrs to fix
            manager/assets/modext/widgets/security/modx.grid.user.js on lines 276..289
            manager/assets/modext/widgets/system/modx.grid.dashboard.widgets.js on lines 144..157
            manager/assets/modext/widgets/system/modx.panel.dashboards.js on lines 205..218

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 111.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 8 locations. Consider refactoring.
            Open

                ,duplicateSource: function(btn,e) {
        MODx.Ajax.request({
            url: this.config.url
            ,params: {
                action: 'source/duplicate'
            Severity: Major
            Found in manager/assets/modext/widgets/source/modx.panel.sources.js and 7 other locations - About 3 hrs to fix
            manager/assets/modext/widgets/fc/modx.grid.fcprofile.js on lines 224..235
            manager/assets/modext/widgets/fc/modx.grid.fcprofile.js on lines 237..248
            manager/assets/modext/widgets/fc/modx.grid.fcprofile.js on lines 269..280
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 254..265
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 267..278
            manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 299..310
            manager/assets/modext/widgets/system/modx.panel.dashboards.js on lines 220..231

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 95.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    },{
            xtype: 'button'
            ,text: _('filter_clear')
            ,id: 'modx-filter-clear'
            ,cls: 'x-form-filter-clear'
            Severity: Major
            Found in manager/assets/modext/widgets/source/modx.panel.sources.js and 2 other locations - About 2 hrs to fix
            manager/assets/modext/widgets/system/modx.grid.dashboard.widgets.js on lines 71..83
            manager/assets/modext/widgets/system/modx.panel.dashboards.js on lines 126..138

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 80.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                    },{
            header: _('description')
            ,dataIndex: 'description'
            ,width: 300
            ,sortable: false
            Severity: Major
            Found in manager/assets/modext/widgets/source/modx.panel.sources.js and 3 other locations - About 55 mins to fix
            manager/assets/modext/widgets/security/modx.grid.user.js on lines 69..76
            manager/assets/modext/widgets/system/modx.grid.context.js on lines 29..36
            manager/assets/modext/widgets/system/modx.grid.context.js on lines 36..43

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status