Sign upLogin

modxcms/revolution

View on GitHub
Star
manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js

Summary

Maintainability
F
3 days
Test Coverage

Function DashboardWidget has 220 lines of code (exceeds 25 allowed). Consider refactoring.
Open

MODx.panel.DashboardWidget = function(config) {
    config = config || {};

    var itms = [];
    itms.push({
Severity: Major
Found in manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js - About 1 day to fix

    File modx.panel.dashboard.widget.js has 388 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    MODx.panel.DashboardWidget = function(config) {
    config = config || {};

    var itms = [];
    itms.push({
    Severity: Minor
    Found in manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js - About 5 hrs to fix

      Function DashboardWidget has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

      MODx.panel.DashboardWidget = function(config) {
    config = config || {};

    var itms = [];
    itms.push({
      Severity: Minor
      Found in manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function submit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          submit: function() {
        var f = this.fp.getForm();
        var fld = f.findField('widget');
        var g = Ext.getCmp('modx-grid-dashboard-widget-dashboards');
        var s = g.getStore();
      Severity: Minor
      Found in manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          ,success: function(o) {
        if (Ext.isEmpty(this.config.record) || Ext.isEmpty(this.config.record.id)) {
            MODx.loadPage('system/dashboards/widget/update', 'id='+o.result.object.id);
        } else {
            Ext.getCmp('modx-abtn-save').setDisabled(false);
      Severity: Major
      Found in manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js and 1 other location - About 5 hrs to fix
      manager/assets/modext/widgets/system/modx.panel.dashboard.js on lines 169..178

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 148.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                      },{
                    xtype: 'modx-combo-namespace'
                    ,name: 'namespace'
                    ,hiddenName: 'namespace'
                    ,id: 'modx-dashboard-widget-namespace'
      Severity: Major
      Found in manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js and 3 other locations - About 1 hr to fix
      manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js on lines 87..96
      manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js on lines 104..113
      manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js on lines 132..141

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                      },{
                    xtype: 'modx-combo-dashboard-widget-type'
                    ,id: 'modx-dashboard-widget-type'
                    ,name: 'type'
                    ,hiddenName: 'type'
      Severity: Major
      Found in manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js and 3 other locations - About 1 hr to fix
      manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js on lines 104..113
      manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js on lines 118..127
      manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js on lines 132..141

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                      ,items: [{
                    xtype: 'modx-combo-dashboard-widget-size'
                    ,name: 'size'
                    ,hiddenName: 'size'
                    ,id: 'modx-dashboard-widget-size'
      Severity: Major
      Found in manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js and 3 other locations - About 1 hr to fix
      manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js on lines 87..96
      manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js on lines 118..127
      manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js on lines 132..141

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

                      },{
                    xtype: 'textfield'
                    ,name: 'lexicon'
                    ,hiddenName: 'lexicon'
                    ,id: 'modx-dashboard-widget-lexicon'
      Severity: Major
      Found in manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js and 3 other locations - About 1 hr to fix
      manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js on lines 87..96
      manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js on lines 104..113
      manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js on lines 118..127

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              Ext.defer(function() {
            Ext.get('modx-dashboard-widget-header').update(_('widget')+': '+this.config.record.name_trans);
        }, 250, this);
      Severity: Major
      Found in manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js and 1 other location - About 1 hr to fix
      manager/assets/modext/widgets/fc/modx.panel.fcprofile.js on lines 113..115

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              store: new Ext.data.SimpleStore({
            fields: ['d','v']
            ,data: [
                [_('widget_size_half'),'half']
                ,[_('widget_size_full'),'full']
      Severity: Major
      Found in manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js and 1 other location - About 1 hr to fix
      manager/assets/modext/widgets/fc/modx.fc.common.js on lines 5..12

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

              if (s.find('widget',fld.getValue()) != -1) {
            fld.markInvalid(_('dashboard_widget_err_placed'));
            return false;
        }
      Severity: Minor
      Found in manager/assets/modext/widgets/system/modx.panel.dashboard.widget.js and 1 other location - About 35 mins to fix
      manager/assets/modext/widgets/system/modx.panel.dashboard.js on lines 319..322

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status