Sign upLogin

modxcms/revolution

View on GitHub
Star
manager/assets/modext/workspace/namespace/modx.namespace.panel.js

Summary

Maintainability
D
1 day
Test Coverage

Function Namespace has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

MODx.grid.Namespace = function(config) {
    config = config || {};
    this.sm = new Ext.grid.CheckboxSelectionModel();
    Ext.applyIf(config,{
        url: MODx.config.connector_url
Severity: Major
Found in manager/assets/modext/workspace/namespace/modx.namespace.panel.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    MODx.panel.Namespaces = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        id: 'modx-panel-namespaces'
        ,cls: 'container'
    Severity: Major
    Found in manager/assets/modext/workspace/namespace/modx.namespace.panel.js and 1 other location - About 7 hrs to fix
    manager/assets/modext/widgets/system/modx.grid.context.js on lines 268..292

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 188.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

            },'->',{
            xtype: 'textfield'
            ,name: 'search'
            ,id: 'modx-namespace-search'
            ,cls: 'x-form-filter'
    Severity: Major
    Found in manager/assets/modext/workspace/namespace/modx.namespace.panel.js and 10 other locations - About 4 hrs to fix
    manager/assets/modext/widgets/core/modx.grid.settings.js on lines 54..70
    manager/assets/modext/widgets/element/modx.grid.plugin.event.js on lines 89..105
    manager/assets/modext/widgets/element/modx.grid.template.tv.js on lines 85..101
    manager/assets/modext/widgets/fc/modx.grid.fcset.js on lines 83..99
    manager/assets/modext/widgets/security/modx.grid.message.js on lines 141..157
    manager/assets/modext/widgets/security/modx.grid.user.js on lines 130..146
    manager/assets/modext/widgets/source/modx.panel.sources.js on lines 94..110
    manager/assets/modext/widgets/system/modx.grid.context.js on lines 55..71
    manager/assets/modext/widgets/system/modx.grid.dashboard.widgets.js on lines 55..71
    manager/assets/modext/workspace/package.grid.js on lines 99..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 126.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                if (p.indexOf('premove') != -1 && this.menu.record.name != 'core') {
                m.push({
                    text: _('namespace_remove')
                    ,handler: this.remove.createDelegate(this,['namespace_remove_confirm','workspace/namespace/remove'])
                });
    Severity: Minor
    Found in manager/assets/modext/workspace/namespace/modx.namespace.panel.js and 2 other locations - About 35 mins to fix
    manager/assets/modext/widgets/security/modx.grid.message.js on lines 227..232
    manager/assets/modext/widgets/security/modx.grid.role.js on lines 66..71

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status