Sign upLogin

modxcms/revolution

View on GitHub
Star
manager/assets/modext/workspace/package.windows.js

Summary

Maintainability
F
4 days
Test Coverage

File package.windows.js has 280 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * @class MODx.window.PackageUninstall
 * @extends MODx.Window
 * @param {Object} config An object of configuration parameters
 * @xtype modx-window-package-uninstall
Severity: Minor
Found in manager/assets/modext/workspace/package.windows.js - About 2 hrs to fix

    Function ChangeProvider has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    MODx.window.ChangeProvider = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        title: _('provider_select')
        ,width: 600 // prevents primary button text from being cut off if it is a long string
    Severity: Minor
    Found in manager/assets/modext/workspace/package.windows.js - About 1 hr to fix

      Function PackageUninstall has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      MODx.window.PackageUninstall = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        title: _('package_uninstall')
        ,url: MODx.config.connector_url
      Severity: Minor
      Found in manager/assets/modext/workspace/package.windows.js - About 1 hr to fix

        Function SetupOptions has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        MODx.window.SetupOptions = function(config) {
    config = config || {};

    Ext.applyIf(config,{
        title: _('setup_options')
        Severity: Minor
        Found in manager/assets/modext/workspace/package.windows.js - About 1 hr to fix

          Function submit has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              submit: function() {
        var r = this.config.record;
        if (this.fp.getForm().isValid()) {
            Ext.getCmp('modx-package-grid').loadConsole(Ext.getBody(),r.topic);
            this.fp.getForm().baseParams = {
          Severity: Minor
          Found in manager/assets/modext/workspace/package.windows.js - About 1 hr to fix

            Function RemovePackage has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            MODx.window.RemovePackage = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        title: _('package_remove')
        ,url: MODx.config.connector_url
            Severity: Minor
            Found in manager/assets/modext/workspace/package.windows.js - About 1 hr to fix

              Function submit has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  submit: function() {
        var r = this.config.record;
        if (this.fp.getForm().isValid()) {
            Ext.getCmp('modx-package-grid').loadConsole(Ext.getBody(),r.topic);
            this.fp.getForm().baseParams = {
              Severity: Minor
              Found in manager/assets/modext/workspace/package.windows.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                Ext.extend(MODx.window.PurgePackages,MODx.Window,{
    submit: function() {
        var r = this.config.record;
        if (this.fp.getForm().isValid()) {
            Ext.getCmp('modx-package-grid').loadConsole(Ext.getBody(),r.topic);
                Severity: Major
                Found in manager/assets/modext/workspace/package.windows.js and 1 other location - About 2 days to fix
                manager/assets/modext/workspace/package/package.versions.grid.js on lines 139..172

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 380.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                MODx.window.PurgePackages = function(config) {
    config = config || {};
    Ext.applyIf(config,{
        title: _('packages_purge')
        ,url: MODx.config.connector_url
                Severity: Major
                Found in manager/assets/modext/workspace/package.windows.js and 1 other location - About 7 hrs to fix
                manager/assets/modext/workspace/package/package.versions.grid.js on lines 117..138

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 177.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        ,buttons :[{
            text: config.cancelBtnText || _('cancel')
            ,scope: this
            ,handler: function() { this.hide(); }
        },{
                Severity: Major
                Found in manager/assets/modext/workspace/package.windows.js and 1 other location - About 2 hrs to fix
                manager/assets/modext/workspace/package.windows.js on lines 286..296

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 85.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        ,buttons :[{
            text: config.cancelBtnText || _('cancel')
            ,scope: this
            ,handler: function() { this.hide(); }
        },{
                Severity: Major
                Found in manager/assets/modext/workspace/package.windows.js and 1 other location - About 2 hrs to fix
                manager/assets/modext/workspace/package.windows.js on lines 223..233

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 85.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status