Sign upLogin

mokevnin/rails-examples

View on GitHub
Star

Showing 3 of 3 total issues

Method facebook has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def facebook
    auth_hash = request.env['omniauth.auth']
    authorization = User::Authorization.where(auth_hash.extract(:provider, :uid)).first_or_initialize

    if authorization.persisted?
Severity: Minor
Found in app/controllers/web/social_networks_controller.rb - About 1 hr to fix

    Method facebook has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def facebook
    auth_hash = request.env['omniauth.auth']
    authorization = User::Authorization.where(auth_hash.extract(:provider, :uid)).first_or_initialize

    if authorization.persisted?
    Severity: Minor
    Found in app/controllers/web/social_networks_controller.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method item has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def item(tag, name, path, link_options = {}, &block)
    Severity: Minor
    Found in app/helpers/application_helper.rb - About 35 mins to fix
      Severity
      Category
      Status
      Source
      Language