Sign upLogin

mondora/mondora-website-back

View on GitHub
Star
server/models/channels/permissions.js

Summary

Maintainability
D
2 days
Test Coverage

Function getPermissionsSelector has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

PermissionsEnum.Channels.getPermissionsSelector = function (user) {
    return {
        // For the channel to be selected either:
        $or: [
            {
Severity: Minor
Found in server/models/channels/permissions.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    PermissionsEnum.Channels.userHasAccess = function (user, channel) {
    // The user can access the channel when either:
    return (
        // the user is the owner
        PermissionsEnum.Channels.isOwner(user._id, channel) ||
    Severity: Major
    Found in server/models/channels/permissions.js and 1 other location - About 6 hrs to fix
    server/models/posts/permissions.js on lines 32..52

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 163.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    PermissionsEnum.Channels.getPermissionsSelector = function (user) {
    return {
        // For the channel to be selected either:
        $or: [
            {
    Severity: Major
    Found in server/models/channels/permissions.js and 1 other location - About 6 hrs to fix
    server/models/posts/permissions.js on lines 54..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 156.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    PermissionsEnum.Channels.isCurator = function (userId, channel) {
    var isCurator = false;
    _.forEach(channel.curators, function (curator) {
        if (curator.userId === userId) {
            isCurator = true;
    Severity: Major
    Found in server/models/channels/permissions.js and 2 other locations - About 2 hrs to fix
    server/models/posts/permissions.js on lines 19..27
    server/models/tasks/permissions.js on lines 19..27

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    Channels.deny({
    update: function (userId, channel, fields) {
        if (PermissionsEnum.Channels.isNotCurator(userId, channel)) return;
        if (PermissionsEnum.Channels.isOwner(userId, channel)) return;
        return _.contains(fields, "userId");
    Severity: Major
    Found in server/models/channels/permissions.js and 2 other locations - About 1 hr to fix
    server/models/channels/permissions.js on lines 177..183
    server/models/tasks/permissions.js on lines 113..119

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    Channels.deny({
    update: function (userId, channel, fields) {
        if (PermissionsEnum.Channels.isNotCurator(userId, channel)) return;
        if (PermissionsEnum.Channels.isOwner(userId, channel)) return;
        return _.contains(fields, "curators");
    Severity: Major
    Found in server/models/channels/permissions.js and 2 other locations - About 1 hr to fix
    server/models/channels/permissions.js on lines 170..176
    server/models/tasks/permissions.js on lines 113..119

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 73.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    Channels.deny({
    update: function (userId, channel, fields) {
        if (PermissionsEnum.Channels.isNotOwner(userId, channel)) return;
        return _.contains(fields, "userId");
    }
    Severity: Major
    Found in server/models/channels/permissions.js and 1 other location - About 1 hr to fix
    server/models/tasks/permissions.js on lines 107..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status