Sign upLogin

mondora/mondora-website-back

View on GitHub
Star
server/models/posts/methods.js

Summary

Maintainability
F
5 days
Test Coverage

File methods.js has 336 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/////////////////////////
// Posts API (methods) //
/////////////////////////

Meteor.methods({
Severity: Minor
Found in server/models/posts/methods.js - About 4 hrs to fix

    Function publishCommentOfPost has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        publishCommentOfPost: function (postId, commentId) {

        // Get the post
        var post = Posts.findOne(postId);
    Severity: Major
    Found in server/models/posts/methods.js - About 2 hrs to fix

      Function bookmarkPost has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          bookmarkPost: function (postId) {
        var user = Meteor.user();
        if (!user) {
            throw new Meteor.Error("Login required");
        }
      Severity: Minor
      Found in server/models/posts/methods.js - About 1 hr to fix

        Function addCommentToPost has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            addCommentToPost: function (postId, comment) {

        // Get the user
        var user = Meteor.user();
        // Only allow logged in users to comment
        Severity: Minor
        Found in server/models/posts/methods.js - About 1 hr to fix

          Function recommendPost has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              recommendPost: function (postId, userId, message) {
        // Check arguments
        check(postId, String);
        check(userId, String);
        if (message === null) {
          Severity: Minor
          Found in server/models/posts/methods.js - About 1 hr to fix

            Function getTopic has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                getTopic: function (name) {
        var selector = {
            // Select only published posts
            published: true,
            // Which have "name" as text of a first level children
            Severity: Minor
            Found in server/models/posts/methods.js - About 1 hr to fix

              Function publishCommentOfPost has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  publishCommentOfPost: function (postId, commentId) {

        // Get the post
        var post = Posts.findOne(postId);
              Severity: Minor
              Found in server/models/posts/methods.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function recommendPost has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  recommendPost: function (postId, userId, message) {
        // Check arguments
        check(postId, String);
        check(userId, String);
        if (message === null) {
              Severity: Minor
              Found in server/models/posts/methods.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  recommendPost: function (postId, userId, message) {
        // Check arguments
        check(postId, String);
        check(userId, String);
        if (message === null) {
              Severity: Major
              Found in server/models/posts/methods.js and 1 other location - About 2 days to fix
              server/models/channels/methods.js on lines 87..135

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 389.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          var notification = {
                channel: "user:" + author.userId,
                type: "commentToPost",
                details: {
                    postId: post._id,
              Severity: Major
              Found in server/models/posts/methods.js and 1 other location - About 4 hrs to fix
              server/models/posts/methods.js on lines 148..162

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 116.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              var notification = {
                    channel: "user:" + user._id,
                    type: "mentionInComment",
                    details: {
                        postId: post._id,
              Severity: Major
              Found in server/models/posts/methods.js and 1 other location - About 4 hrs to fix
              server/models/posts/methods.js on lines 52..66

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 116.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  unlikePost: function (postId) {
        var user = Meteor.user();
        if (!user) {
            return;
        }
              Severity: Major
              Found in server/models/posts/methods.js and 1 other location - About 3 hrs to fix
              server/models/posts/methods.js on lines 194..214

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 106.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  likePost: function (postId) {
        var user = Meteor.user();
        if (!user) {
            return;
        }
              Severity: Major
              Found in server/models/posts/methods.js and 1 other location - About 3 hrs to fix
              server/models/posts/methods.js on lines 216..236

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 106.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status