Sign upLogin

mongaku/mongaku

View on GitHub
Star
src/logic/edit.js

Summary

Maintainability
D
2 days
Test Coverage

Function exports has 223 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(app: express$Application) {
    const Image = models("Image");

    const {auth, canEdit} = require("./shared/auth");
Severity: Major
Found in src/logic/edit.js - About 1 day to fix

    Function edit has 110 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const edit = (req: express$Request, res, next) => {
        const {
            params: {type, recordName, source},
            i18n,
            lang,
    Severity: Major
    Found in src/logic/edit.js - About 4 hrs to fix

      Function removeImage has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const removeImage = (req: express$Request, res, next) => {
        const {
            params: {type, source, recordName},
            i18n,
            lang,
      Severity: Minor
      Found in src/logic/edit.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                                res.render("EditRecord", {
                            title,
                            mode: "edit",
                            record: clonedRecord,
                            source,
        Severity: Minor
        Found in src/logic/edit.js and 1 other location - About 40 mins to fix
        src/logic/create.js on lines 60..68

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

                    if (err || !record) {
                return res.status(404).render("Error", {
                    title: i18n.gettext("Page not found."),
                });
            }
        Severity: Major
        Found in src/logic/edit.js and 5 other locations - About 35 mins to fix
        src/logic/create.js on lines 28..32
        src/logic/edit.js on lines 177..181
        src/logic/source-admin.js on lines 22..26
        src/logic/source-admin.js on lines 90..94
        src/logic/uploads.js on lines 150..154

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

                                if (err || !record) {
                            return res.status(404).render("Error", {
                                title: i18n.gettext("Not found."),
                            });
                        }
        Severity: Major
        Found in src/logic/edit.js and 5 other locations - About 35 mins to fix
        src/logic/create.js on lines 28..32
        src/logic/edit.js on lines 50..54
        src/logic/source-admin.js on lines 22..26
        src/logic/source-admin.js on lines 90..94
        src/logic/uploads.js on lines 150..154

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    const images = Array.isArray(files.images)
                ? files.images
                : files.images
                    ? [files.images]
                    : [];
        Severity: Minor
        Found in src/logic/edit.js and 1 other location - About 35 mins to fix
        src/logic/create.js on lines 136..140

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 46.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status