mongaku/mongaku

View on GitHub
src/logic/shared/search.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function exports has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = (fields, {originalUrl, i18n, user}, callback) => {
    // Collect all the values from the request to construct
    // the search URL and matches later
    // Generate the filters and facets which will be fed in to Elasticsearch
    // to build the query filter and aggregations
Severity: Minor
Found in src/logic/shared/search.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buckets has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

                        .filter(bucket => {
                            const url = Object.assign({}, values);
                            for (const param in bucket.url) {
                                const curValue = url[param];
                                const value = bucket.url[param];
Severity: Minor
Found in src/logic/shared/search.js - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                                    } else if (curValue) {
                                        if (curValue === value) {
                                            return false;
                                        }
                                        url[param] = [curValue, value];
    Severity: Major
    Found in src/logic/shared/search.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                          if (curValue.includes(value)) {
                                              return false;
                                          }
      Severity: Major
      Found in src/logic/shared/search.js - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status