Sign upLogin

mongaku/mongaku

View on GitHub
Star
src/logic/source-admin.js

Summary

Maintainability
F
5 days
Test Coverage

Function exports has 430 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(app) {
    const ImageImport = models("ImageImport");
    const RecordImport = models("RecordImport");

    const {auth, canEdit} = require("./shared/auth");
Severity: Major
Found in src/logic/source-admin.js - About 2 days to fix

    File source-admin.js has 439 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    const fs = require("fs");

const async = require("async");
const formidable = require("formidable");
const jdp = require("jsondiffpatch");
    Severity: Minor
    Found in src/logic/source-admin.js - About 6 hrs to fix

      Function routes has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              routes() {
            const source = (req, res, next) => {
                const {
                    params: {source},
                } = req;
      Severity: Minor
      Found in src/logic/source-admin.js - About 2 hrs to fix

        Function uploadData has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                uploadData(req, res, next) {
            const {source, i18n, lang} = req;

            const form = new formidable.IncomingForm();
            form.encoding = "utf-8";
        Severity: Minor
        Found in src/logic/source-admin.js - About 1 hr to fix

          Function uploadZipFile has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  uploadZipFile(req, res, next) {
            const {source, i18n, lang} = req;

            const form = new formidable.IncomingForm();
            form.encoding = "utf-8";
          Severity: Minor
          Found in src/logic/source-admin.js - About 1 hr to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                                batch.save(err => {
                        /* istanbul ignore if */
                        if (err) {
                            return next(
                                new Error(
            Severity: Major
            Found in src/logic/source-admin.js and 2 other locations - About 1 hr to fix
            src/logic/source-admin.js on lines 308..317
            src/logic/source-admin.js on lines 344..353

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                            batch.save(err => {
                    /* istanbul ignore if */
                    if (err) {
                        return next(
                            new Error(i18n.gettext("Error saving directory.")),
            Severity: Major
            Found in src/logic/source-admin.js and 2 other locations - About 1 hr to fix
            src/logic/source-admin.js on lines 308..317
            src/logic/source-admin.js on lines 405..416

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                            batch.save(err => {
                    /* istanbul ignore if */
                    if (err) {
                        return next(
                            new Error(i18n.gettext("Error saving zip file.")),
            Severity: Major
            Found in src/logic/source-admin.js and 2 other locations - About 1 hr to fix
            src/logic/source-admin.js on lines 344..353
            src/logic/source-admin.js on lines 405..416

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        for (const name of Object.keys(filteredResults)) {
                if (!expanded || expanded !== name) {
                    filteredResults[name] = filteredResults[name].slice(0, 8);
                }
            }
            Severity: Major
            Found in src/logic/source-admin.js and 1 other location - About 1 hr to fix
            src/logic/source-admin.js on lines 60..64

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        for (const name of Object.keys(filteredResults)) {
                if (!expanded || expanded !== name) {
                    filteredResults[name] = filteredResults[name].slice(0, 8);
                }
            }
            Severity: Major
            Found in src/logic/source-admin.js and 1 other location - About 1 hr to fix
            src/logic/source-admin.js on lines 109..113

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                    dataImport.length > 0 &&
                        dataImport.every(batch => batch.isCompleted()) &&
                        dataImport.some(batch => batch.isSuccessful()),
            Severity: Major
            Found in src/logic/source-admin.js and 1 other location - About 1 hr to fix
            src/logic/source-admin.js on lines 254..256

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                    imageImport.length > 0 &&
                        imageImport.every(batch => batch.isCompleted()) &&
                        imageImport.some(batch => batch.isSuccessful()) ||
            Severity: Major
            Found in src/logic/source-admin.js and 1 other location - About 1 hr to fix
            src/logic/source-admin.js on lines 259..261

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                    {
                            state: true,
                            fileName: true,
                            source: true,
                            created: true,
            Severity: Minor
            Found in src/logic/source-admin.js and 1 other location - About 35 mins to fix
            src/logic/source-admin.js on lines 176..186

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                        if (err || !batch) {
                return res.status(404).render("Error", {
                    title: i18n.gettext("Import not found."),
                });
            }
            Severity: Major
            Found in src/logic/source-admin.js and 5 other locations - About 35 mins to fix
            src/logic/create.js on lines 28..32
            src/logic/edit.js on lines 50..54
            src/logic/edit.js on lines 177..181
            src/logic/source-admin.js on lines 90..94
            src/logic/uploads.js on lines 150..154

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

                        if (err || !batch) {
                return res.status(404).render("Error", {
                    title: i18n.gettext("Import not found."),
                });
            }
            Severity: Major
            Found in src/logic/source-admin.js and 5 other locations - About 35 mins to fix
            src/logic/create.js on lines 28..32
            src/logic/edit.js on lines 50..54
            src/logic/edit.js on lines 177..181
            src/logic/source-admin.js on lines 22..26
            src/logic/uploads.js on lines 150..154

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                    {
                            state: true,
                            fileName: true,
                            source: true,
                            created: true,
            Severity: Minor
            Found in src/logic/source-admin.js and 1 other location - About 35 mins to fix
            src/logic/source-admin.js on lines 159..169

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status