Sign upLogin

mongaku/mongaku

View on GitHub
Star
src/logic/uploads.js

Summary

Maintainability
C
1 day
Test Coverage

Function exports has 151 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = app => {
    const Upload = models("Upload");
    const UploadImage = models("UploadImage");
    const Source = models("Source");
Severity: Major
Found in src/logic/uploads.js - About 6 hrs to fix

    Function show has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            show({params, i18n, user}, res) {
            // TODO: Update similar matches if new image data has
            // since come in since it was last updated.
            const _id = `uploads/${params.upload}`;
            Upload.findById(_id, (err, upload) => {
    Severity: Minor
    Found in src/logic/uploads.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              routes() {
            app.get("/:type/uploads/:upload", this.show);
            app.get("/:type/url-upload", this.urlUpload);
            app.post("/:type/file-upload", this.fileUpload);
        },
      Severity: Major
      Found in src/logic/uploads.js and 1 other location - About 1 hr to fix
      src/logic/users.js on lines 45..49

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 56.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

                      if (err || !upload) {
                    return res.status(404).render("Error", {
                        title: i18n.gettext("Uploaded image not found."),
                    });
                }
      Severity: Major
      Found in src/logic/uploads.js and 5 other locations - About 35 mins to fix
      src/logic/create.js on lines 28..32
      src/logic/edit.js on lines 50..54
      src/logic/edit.js on lines 177..181
      src/logic/source-admin.js on lines 22..26
      src/logic/source-admin.js on lines 90..94

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status