mongaku/mongaku

View on GitHub
src/schemas/Image.js

Summary

Maintainability
D
2 days
Test Coverage

File Image.js has 537 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const fs = require("fs");
const path = require("path");

const farmhash = require("farmhash");
const imageinfo = require("imageinfo");
Severity: Major
Found in src/schemas/Image.js - About 1 day to fix

    Function fromFile has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        fromFile(batch, file, callback) {
            const Image = models("Image");
            const Source = models("Source");
    
            const filePath = file.path || file;
    Severity: Major
    Found in src/schemas/Image.js - About 2 hrs to fix

      Function updateSimilarity has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          updateSimilarity(callback) {
              // Skip small images
              if (!this.canIndex()) {
                  return process.nextTick(callback);
              }
      Severity: Major
      Found in src/schemas/Image.js - About 2 hrs to fix

        Function processImage has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            processImage(sourceFile, baseDir, callback) {
                let hash;
                let imageFile;
                const existsError = new Error("Already exists.");
        
        
        Severity: Minor
        Found in src/schemas/Image.js - About 1 hr to fix

          Function updateSimilarity has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              updateSimilarity(callback) {
                  models("Image").findOne(
                      {
                          needsSimilarUpdate: true,
                      },
          Severity: Minor
          Found in src/schemas/Image.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                image.save(err => {
                                    /* istanbul ignore if */
                                    if (err) {
                                        console.error(err);
                                        return callback(err);
            Severity: Major
            Found in src/schemas/Image.js and 1 other location - About 2 hrs to fix
            src/schemas/Record.js on lines 762..777

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 85.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                similarImages: [
                    {
                        // The ID of the visually similar image
                        _id: {
                            type: String,
            Severity: Minor
            Found in src/schemas/Image.js and 1 other location - About 50 mins to fix
            src/schemas/UploadImage.js on lines 63..78

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                canView(user) {
                    const source = this.getSource();
            
                    if (!source) {
                        return true;
            Severity: Minor
            Found in src/schemas/Image.js and 1 other location - About 35 mins to fix
            src/schemas/Record.js on lines 386..394

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status