Sign upLogin

mongaku/mongaku

View on GitHub
Star
src/schemas/Record.js

Summary

Maintainability
F
6 days
Test Coverage

File Record.js has 655 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const async = require("async");
const jdp = require("jsondiffpatch").create({
    objectHash: obj => obj._id,
});
Severity: Major
Found in src/schemas/Record.js - About 1 day to fix

    Function lintData has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
    Open

        lintData(data, i18n, optionalSchema) {
        const schema = optionalSchema || recordModel(this.getType()).schema;

        const cleaned = {};
        const warnings = [];
    Severity: Minor
    Found in src/schemas/Record.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function lintData has 137 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        lintData(data, i18n, optionalSchema) {
        const schema = optionalSchema || recordModel(this.getType()).schema;

        const cleaned = {};
        const warnings = [];
    Severity: Major
    Found in src/schemas/Record.js - About 5 hrs to fix

      Function fromData has 96 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          fromData(tmpData, i18n, callback) {
        const Record = recordModel(this.getType());
        const Image = models("Image");

        const {error, warnings, data} = this.lintData(tmpData, i18n);
      Severity: Major
      Found in src/schemas/Record.js - About 3 hrs to fix

        Function updateSimilarity has 60 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            updateSimilarity(callback) {
        this.getImages((err, images) => {
            /* istanbul ignore if */
            if (err) {
                return callback(err);
        Severity: Major
        Found in src/schemas/Record.js - About 2 hrs to fix

          Function getExpectedType has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

          const getExpectedType = (options, value) => {
    if (Array.isArray(options.type)) {
        return Array.isArray(value) ? false : "array";
    }
          Severity: Minor
          Found in src/schemas/Record.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function loadImages has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              loadImages(loadSimilarRecords, callback) {
        async.parallel(
            [
                callback => {
                    this.getImages((err, images) => {
          Severity: Minor
          Found in src/schemas/Record.js - About 1 hr to fix

            Function getFacets has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                getFacets(i18n, callback) {
        const {lang} = i18n;

        if (!this.facetCache) {
            this.facetCache = {};
            Severity: Minor
            Found in src/schemas/Record.js - About 1 hr to fix

              Avoid deeply nested control flow statements.
              Open

                                      if (value.length !== results.length) {
                            warnings.push(options.validationMsg(i18n));
                        }
              Severity: Major
              Found in src/schemas/Record.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                                if (results.error) {
                                    warnings.push(
                                        `\`${field}\`: ${results.error}`,
                                    );
                                    return undefined;
                Severity: Major
                Found in src/schemas/Record.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                                  for (const warning of results.warnings) {
                                    warnings.push(`\`${field}\`: ${warning}`);
                                }
                  Severity: Major
                  Found in src/schemas/Record.js - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                                if (expectedType) {
                                warnings.push(
                                    i18n.format(
                                        i18n.gettext(
                                            "`%(field)s` value is the wrong " +
                    Severity: Major
                    Found in src/schemas/Record.js - About 45 mins to fix

                      Avoid too many return statements within this function.
                      Open

                          return typeof value === "string" ? false : "string";
                      Severity: Major
                      Found in src/schemas/Record.js - About 30 mins to fix

                        Function stripProp has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                        Open

                        const stripProp = (obj, name) => {
    if (!obj) {
        return obj;
    }
                        Severity: Minor
                        Found in src/schemas/Record.js - About 25 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                        record.updateSimilarity(err => {
                    /* istanbul ignore if */
                    if (err) {
                        console.error(err);
                        return callback(err);
                        Severity: Major
                        Found in src/schemas/Record.js and 1 other location - About 2 hrs to fix
                        src/schemas/Image.js on lines 477..492

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 85.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            getImages(callback) {
        async.mapLimit(
            this.images,
            4,
            (id, callback) => {
                        Severity: Major
                        Found in src/schemas/Record.js and 1 other location - About 2 hrs to fix
                        src/schemas/Upload.js on lines 92..104

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 82.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            getThumbURL() {
        if (!this.defaultImageHash) {
            return options.types[this.type].defaultImage;
        }
                        Severity: Major
                        Found in src/schemas/Record.js and 1 other location - About 1 hr to fix
                        src/schemas/Record.js on lines 172..180

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 72.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            getOriginalURL() {
        if (!this.defaultImageHash) {
            return options.types[this.type].defaultImage;
        }
                        Severity: Major
                        Found in src/schemas/Record.js and 1 other location - About 1 hr to fix
                        src/schemas/Record.js on lines 182..190

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 72.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            source: {
        type: String,
        es_indexed: true,
        es_type: "string",
        // A raw name to use for building aggregations in Elasticsearch
                        Severity: Major
                        Found in src/schemas/Record.js and 1 other location - About 1 hr to fix
                        src/schemas/types/Name.js on lines 106..116

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 63.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                            canView(user) {
        const source = this.getSource();

        if (!source) {
            return true;
                        Severity: Minor
                        Found in src/schemas/Record.js and 1 other location - About 35 mins to fix
                        src/schemas/Image.js on lines 329..337

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 46.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                            this.getImages((err, images) => {
                        // We filter out any invalid/un-found images
                        // TODO: We should log out some details on when this
                        // happens (hopefully never).
                        this.images = images.filter(image => !!image);
                        Severity: Minor
                        Found in src/schemas/Record.js and 1 other location - About 30 mins to fix
                        src/schemas/Record.js on lines 370..378

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 45.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                                (err, similar) => {
                            // We filter out any invalid/un-found records
                            // TODO: We should log out some details on when this
                            // happens (hopefully never).
                            this.similarRecords = similar.filter(
                        Severity: Minor
                        Found in src/schemas/Record.js and 1 other location - About 30 mins to fix
                        src/schemas/Record.js on lines 333..339

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 45.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status