mongaku/mongaku

View on GitHub
src/schemas/RecordImport.js

Summary

Maintainability
D
1 day
Test Coverage

File RecordImport.js has 301 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const async = require("async");

const record = require("../lib/record");
const models = require("../lib/models");
const db = require("../lib/db");
Severity: Minor
Found in src/schemas/RecordImport.js - About 3 hrs to fix

    Function importRecords has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        importRecords(callback) {
            const Record = record(this.type);
            const Source = models("Source");
    
            async.eachLimit(
    Severity: Major
    Found in src/schemas/RecordImport.js - About 2 hrs to fix

      Function processRecords has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          processRecords(callback) {
              const Record = record(this.type);
              const incomingIDs = {};
      
              const results = this.results;
      Severity: Major
      Found in src/schemas/RecordImport.js - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        RecordImport.pre("validate", function(next) {
            // Create the ID if one hasn't been set before
            if (!this._id) {
                this._id = `${this.source}/${Date.now()}`;
            }
        Severity: Major
        Found in src/schemas/RecordImport.js and 1 other location - About 2 hrs to fix
        src/schemas/ImageImport.js on lines 313..320

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 76.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            getURL(lang) {
                return urls.gen(
                    lang,
                    `/${this.getSource().type}` +
                        `/source/${this.source}/admin?records=${this._id}`,
        Severity: Major
        Found in src/schemas/RecordImport.js and 1 other location - About 1 hr to fix
        src/schemas/ImageImport.js on lines 97..103

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 66.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            {
                id: "similarity.sync.completed",
                name: i18n => i18n.gettext("Completed."),
                advance(batch, callback) {
                    // NOTE(jeresig): Currently nothing needs to be done to finish
        Severity: Minor
        Found in src/schemas/RecordImport.js and 1 other location - About 40 mins to fix
        src/schemas/ImageImport.js on lines 37..45

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            {
                id: "import.completed",
                name: i18n => i18n.gettext("Awaiting similarity sync..."),
                advance(batch, callback) {
                    batch.updateSimilarity(callback);
        Severity: Minor
        Found in src/schemas/RecordImport.js and 1 other location - About 30 mins to fix
        src/schemas/RecordImport.js on lines 13..19

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            {
                id: "started",
                name: i18n => i18n.gettext("Awaiting processing..."),
                advance(batch, callback) {
                    batch.processRecords(callback);
        Severity: Minor
        Found in src/schemas/RecordImport.js and 1 other location - About 30 mins to fix
        src/schemas/RecordImport.js on lines 36..42

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status