Sign upLogin

mongaku/mongaku

View on GitHub
Star
src/views/EditRecord.js

Summary

Maintainability
D
2 days
Test Coverage

File EditRecord.js has 525 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// @flow

const React = require("react");

const FixedStringEdit = require("./types/edit/FixedString.js");
Severity: Major
Found in src/views/EditRecord.js - About 1 day to fix

    Function render has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        render() {
        const {mode, type, globalFacets, dynamicValues} = this.props;
        const {gettext, options} = this.context;
        const {model} = options.types[type];
        const types = Object.keys(model);
    Severity: Major
    Found in src/views/EditRecord.js - About 2 hrs to fix

      Function TypeEdit has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

      const TypeEdit = ({
    name,
    type,
    value,
    allValues,
      Severity: Minor
      Found in src/views/EditRecord.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function EditRecord has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const EditRecord = (props: Props) => {
    const {record, mode, title} = props;
    const postURL = record
        ? record._id
            ? record.getEditURL
      Severity: Minor
      Found in src/views/EditRecord.js - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

                return <YearRangeEdit name={name} type={type} value={value} />;
        Severity: Major
        Found in src/views/EditRecord.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return (
            <FixedStringEdit
                name={name}
                type={type}
                value={value}
          Severity: Major
          Found in src/views/EditRecord.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return (
            <NameEdit
                name={name}
                type={type}
                value={value}
            Severity: Major
            Found in src/views/EditRecord.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return null;
              Severity: Major
              Found in src/views/EditRecord.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return <SimpleDateEdit name={name} type={type} value={value} />;
                Severity: Major
                Found in src/views/EditRecord.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return <FixedStringEdit name={name} type={type} value={value} />;
                  Severity: Major
                  Found in src/views/EditRecord.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return (
            <FixedStringEdit
                name={name}
                type={type}
                value={value && String(value)}
                    Severity: Major
                    Found in src/views/EditRecord.js - About 30 mins to fix

                      Function render has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          render() {
        const {mode, type, globalFacets, dynamicValues} = this.props;
        const {gettext, options} = this.context;
        const {model} = options.types[type];
        const types = Object.keys(model);
                      Severity: Minor
                      Found in src/views/EditRecord.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                              let values = Object.keys(expectedValues).map(id => ({
            id,
            name: expectedValues[id].name,
        }));
                      Severity: Minor
                      Found in src/views/EditRecord.js and 1 other location - About 35 mins to fix
                      src/views/Record.js on lines 224..227

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 46.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status