Sign upLogin

mongaku/mongaku

View on GitHub
Star
src/views/shared/Select.js

Summary

Maintainability
F
5 days
Test Coverage

File Select.js has 1252 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// @flow

const React = require("react");

import type {Context} from "../types.js";
Severity: Major
Found in src/views/shared/Select.js - About 3 days to fix

    Function renderMenu has 85 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        renderMenu() {
        const {create} = this.props;
        const {searchValue, options, error} = this.state;
        const {gettext, format} = this.context;
    Severity: Major
    Found in src/views/shared/Select.js - About 3 hrs to fix

      Function handleInput has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          handleInput(searchValue: string) {
        const {loadOptions, options} = this.props;

        this.setState({
            searchValue,
      Severity: Minor
      Found in src/views/shared/Select.js - About 1 hr to fix

        Function addValue has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            addValue(addedValue: string, addedLabel: string) {
        const {onChange, value} = this.props;
        if ((!value || Array.isArray(value)) && onChange) {
            this.labelCache[addedValue] = addedLabel;
            onChange(
        Severity: Minor
        Found in src/views/shared/Select.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

                if (
            searchValue !== undefined &&
            (!target ||
                (target instanceof Node &&
                    this.control &&
        Severity: Major
        Found in src/views/shared/Select.js - About 1 hr to fix

          Function handleKey has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              handleKey(e: SyntheticKeyboardEvent<HTMLInputElement>) {
        if (
            e.target instanceof HTMLInputElement &&
            (e.key === "Enter" || e.key === "Tab")
        ) {
          Severity: Minor
          Found in src/views/shared/Select.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function handleInput has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              handleInput(searchValue: string) {
        const {loadOptions, options} = this.props;

        this.setState({
            searchValue,
          Severity: Minor
          Found in src/views/shared/Select.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                  return (
            <ul
                className="dropdown-menu"
                style={{
                    display: "block",
          Severity: Major
          Found in src/views/shared/Select.js - About 30 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                componentDidMount() {
        this.boundHandleBlur = (e: Event) => this.handleBlur(e);
        document.addEventListener("focusin", this.boundHandleBlur);
        document.addEventListener("click", this.boundHandleBlur);
    }
            Severity: Major
            Found in src/views/shared/Select.js and 1 other location - About 1 hr to fix
            src/views/Page.js on lines 44..48

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (!options) {
            return (
                <div style={{marginTop: "8px"}}>
                    <span className="label label-default">
                        {gettext("Loading...")}
            Severity: Major
            Found in src/views/shared/Select.js and 2 other locations - About 1 hr to fix
            src/views/shared/Select.js on lines 285..293
            src/views/shared/Select.js on lines 307..315

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (error) {
            return (
                <div style={{marginTop: "8px"}}>
                    <span className="label label-danger">
                        {gettext("Error loading options.")}
            Severity: Major
            Found in src/views/shared/Select.js and 2 other locations - About 1 hr to fix
            src/views/shared/Select.js on lines 295..303
            src/views/shared/Select.js on lines 307..315

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (filteredOptions.length === 0 && !create) {
            return (
                <div style={{marginTop: "8px"}}>
                    <span className="label label-default">
                        {gettext("No results found.")}
            Severity: Major
            Found in src/views/shared/Select.js and 2 other locations - About 1 hr to fix
            src/views/shared/Select.js on lines 285..293
            src/views/shared/Select.js on lines 295..303

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 57.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status