Sign upLogin

mongoclient/mongoclient

View on GitHub
Star
client/imports/ui/user_management/users.js

Summary

Maintainability
F
5 days
Test Coverage

File users.js has 271 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Communicator, ReactivityProvider } from '/client/imports/facades';
import { Notification, ErrorHandler, SessionManager, UIComponents, ExtendedJSON } from '/client/imports/modules';
import Helper from '/client/imports/helpers/helper';
import UsermanagementHelper from './helper';
import $ from 'jquery';
Severity: Minor
Found in client/imports/ui/user_management/users.js - About 2 hrs to fix

    Function initUsers has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      initUsers() {
    Notification.start('#btnCloseUMDB');

    const command = {
      usersInfo: 1,
    Severity: Minor
    Found in client/imports/ui/user_management/users.js - About 1 hr to fix

      Function saveUser has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        saveUser() {
    const usernameSelector = $('#inputUsernameUM');
    const passwordSelector = $('#inputPasswordUM');
    const titleSelector = $('#addEditUserModalTitle');
      Severity: Minor
      Found in client/imports/ui/user_management/users.js - About 1 hr to fix

        Function saveUser has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

          saveUser() {
    const usernameSelector = $('#inputUsernameUM');
    const passwordSelector = $('#inputPasswordUM');
    const titleSelector = $('#addEditUserModalTitle');
        Severity: Minor
        Found in client/imports/ui/user_management/users.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function popEditUserModal has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          popEditUserModal(user) {
    $('#addEditUserModalTitle').text(Helper.translate({ key: 'edit_user' }));

    Notification.start('#btnCloseUMDB');
        Severity: Minor
        Found in client/imports/ui/user_management/users.js - About 1 hr to fix

          Function callback has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                callback: (err, result) => {
        if (err || result.error) ErrorHandler.showMeteorFuncError(err, result);
        else {
          UIComponents.DataTable.setupDatatable({
            data: this.populateTableData(result.result.users),
          Severity: Minor
          Found in client/imports/ui/user_management/users.js - About 1 hr to fix

            Function applyNewRoleToUser has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              applyNewRoleToUser() {
    Communicator.call({
      methodName: 'getDatabases',
      callback: (err, result) => {
        let data;
            Severity: Minor
            Found in client/imports/ui/user_management/users.js - About 1 hr to fix

              Function showCustomData has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                showCustomData() {
    Notification.start('#btnCloseUMDB');

    const selectedUser = SessionManager.get(SessionManager.strSessionUsermanagementUser);
    if (selectedUser) {
              Severity: Minor
              Found in client/imports/ui/user_management/users.js - About 1 hr to fix

                Function applyNewRoleToUser has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                  applyNewRoleToUser() {
    Communicator.call({
      methodName: 'getDatabases',
      callback: (err, result) => {
        let data;
                Severity: Minor
                Found in client/imports/ui/user_management/users.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function showCustomData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  showCustomData() {
    Notification.start('#btnCloseUMDB');

    const selectedUser = SessionManager.get(SessionManager.strSessionUsermanagementUser);
    if (selectedUser) {
                Severity: Minor
                Found in client/imports/ui/user_management/users.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function popEditUserModal has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  popEditUserModal(user) {
    $('#addEditUserModalTitle').text(Helper.translate({ key: 'edit_user' }));

    Notification.start('#btnCloseUMDB');
                Severity: Minor
                Found in client/imports/ui/user_management/users.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function addRoleToUser has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  addRoleToUser() {
    const db = $('#cmbDatabasesForAddRoleToUser').val();
    const roleName = $('#inputAddRoleToUserRolename').val();
    if (!db) {
      Notification.error('db-required');
                Severity: Minor
                Found in client/imports/ui/user_management/users.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  addRoleToUser() {
    const db = $('#cmbDatabasesForAddRoleToUser').val();
    const roleName = $('#inputAddRoleToUserRolename').val();
    if (!db) {
      Notification.error('db-required');
                Severity: Major
                Found in client/imports/ui/user_management/users.js and 1 other location - About 1 day to fix
                client/imports/ui/user_management/roles.js on lines 45..72

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 335.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  populateUserRolesToSave() {
    const result = [];
    const roles = $('#tblUserRoles').DataTable().rows().data();
    for (let i = 0; i < roles.length; i += 1) {
      result.push({
                Severity: Major
                Found in client/imports/ui/user_management/users.js and 1 other location - About 4 hrs to fix
                client/imports/ui/user_management/roles.js on lines 431..442

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 118.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  deleteUser() {
    if (!SessionManager.get(SessionManager.strSessionUsermanagementUser)) return;

    const command = { dropUser: SessionManager.get(SessionManager.strSessionUsermanagementUser).user };
    UsermanagementHelper.proceedDroppingRoleOrUser('#btnCloseUMDB', command, () => { this.initUsers(); });
                Severity: Major
                Found in client/imports/ui/user_management/users.js and 1 other location - About 2 hrs to fix
                client/imports/ui/user_management/roles.js on lines 479..484

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 84.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            columnDefs: [
              {
                targets: [2],
                data: null,
                width: '5%',
                Severity: Major
                Found in client/imports/ui/user_management/users.js and 1 other location - About 2 hrs to fix
                client/imports/ui/file_management/index.js on lines 56..75

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 78.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        if (err || result.error) ErrorHandler.showMeteorFuncError(err, result);
        else {
          this.initUsers();
          Notification.success('saved-successfully');
          $('#editUserModal').modal('hide');
                Severity: Major
                Found in client/imports/ui/user_management/users.js and 1 other location - About 1 hr to fix
                client/imports/ui/user_management/roles.js on lines 153..159

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 64.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    if (customData) {
      customData = ExtendedJSON.convertAndCheckJSON(customData);
      if (customData.ERROR) {
        Notification.error('syntax-error-custom-data', null, { error: customData.ERROR });
        return;
                Severity: Major
                Found in client/imports/ui/user_management/users.js and 2 other locations - About 1 hr to fix
                client/imports/ui/index_management/index.js on lines 199..205
                client/imports/ui/index_management/index.js on lines 208..214

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 57.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 12 locations. Consider refactoring.
                Open

                      const connection = ReactivityProvider.findOne(ReactivityProvider.types.Connections, { _id: SessionManager.get(SessionManager.strSessionConnection)._id });
                Severity: Major
                Found in client/imports/ui/user_management/users.js and 11 other locations - About 35 mins to fix
                client/imports/ui/backup/index.js on lines 204..204
                client/imports/ui/collection/add.js on lines 277..277
                client/imports/ui/collection/update_view_pipeline.js on lines 36..36
                client/imports/ui/collection/validation_rules.js on lines 25..25
                client/imports/ui/connection/helper.js on lines 117..117
                client/imports/ui/connection/index.js on lines 128..128
                client/imports/ui/user_management/roles.js on lines 217..217
                client/imports/ui/user_management/tree.js on lines 116..116
                client/imports/ui/user_management/users.js on lines 226..226
                client/imports/views/layouts/navigation/navigation.js on lines 28..28
                client/imports/views/layouts/navigation/navigation.js on lines 110..110

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 12 locations. Consider refactoring.
                Open

                    const connection = ReactivityProvider.findOne(ReactivityProvider.types.Connections, { _id: SessionManager.get(SessionManager.strSessionConnection)._id });
                Severity: Major
                Found in client/imports/ui/user_management/users.js and 11 other locations - About 35 mins to fix
                client/imports/ui/backup/index.js on lines 204..204
                client/imports/ui/collection/add.js on lines 277..277
                client/imports/ui/collection/update_view_pipeline.js on lines 36..36
                client/imports/ui/collection/validation_rules.js on lines 25..25
                client/imports/ui/connection/helper.js on lines 117..117
                client/imports/ui/connection/index.js on lines 128..128
                client/imports/ui/user_management/roles.js on lines 217..217
                client/imports/ui/user_management/tree.js on lines 116..116
                client/imports/ui/user_management/users.js on lines 132..132
                client/imports/views/layouts/navigation/navigation.js on lines 28..28
                client/imports/views/layouts/navigation/navigation.js on lines 110..110

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status