mongodb/mongo-ruby-driver

View on GitHub

Showing 393 of 447 total issues

Avoid deeply nested control flow statements.
Open

              if key.to_s.start_with?("$")
                if Mongo.validate_update_replace
                  raise Error::InvalidReplacementDocument.new(key: key)
                else
                  Error::InvalidReplacementDocument.warn(Logger.logger, key)
Severity: Major
Found in lib/mongo/bulk_write.rb - About 45 mins to fix

    Method delete_one has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def delete_one(documents, connection, context, operation_id, session, txn_num)
    Severity: Minor
    Found in lib/mongo/bulk_write.rb - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                      unless key.to_s.start_with?("$")
                        if Mongo.validate_update_replace
                          raise Error::InvalidUpdateDocument.new(key: key)
                        else
                          Error::InvalidUpdateDocument.warn(Logger.logger, key)
      Severity: Major
      Found in lib/mongo/bulk_write.rb - About 45 mins to fix

        Method update_many has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def update_many(documents, connection, context, operation_id, session, txn_num)
        Severity: Minor
        Found in lib/mongo/bulk_write.rb - About 45 mins to fix

          Method set_cert has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def set_cert(context, options)
                  # Since we clear cert_text during processing, we need to examine
                  # ssl_cert_object here to avoid considering it if we have also
                  # processed the text.
                  if options[:ssl_cert]
          Severity: Minor
          Found in lib/mongo/socket/ssl.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method delete_many has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def delete_many(documents, connection, context, operation_id, session, txn_num)
          Severity: Minor
          Found in lib/mongo/bulk_write.rb - About 45 mins to fix

            Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                  def initialize(host, port, host_name, timeout, family, options = {})
            Severity: Minor
            Found in lib/mongo/socket/ssl.rb - About 45 mins to fix

              Method change_stream_resumable? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                    def change_stream_resumable?
                      if @result && @result.is_a?(Mongo::Operation::GetMore::Result)
                        # CursorNotFound exceptions are always resumable because the server
                        # is not aware of the cursor id, and thus cannot determine if
                        # the cursor is a change stream and cannot add the
              Severity: Minor
              Found in lib/mongo/error/operation_failure.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method update_one has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  def update_one(documents, connection, context, operation_id, session, txn_num)
              Severity: Minor
              Found in lib/mongo/bulk_write.rb - About 45 mins to fix

                Method command_completed has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                      def command_completed(result, address, operation_id, payload, duration,
                        started_event:, server_connection_id: nil, service_id: nil
                Severity: Minor
                Found in lib/mongo/monitoring/publishable.rb - About 35 mins to fix

                  Method generate has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          def self.generate(address, operation_id, command_payload,
                            reply_payload, duration, started_event:, server_connection_id: nil,
                            service_id: nil
                  Severity: Minor
                  Found in lib/mongo/monitoring/event/command_succeeded.rb - About 35 mins to fix

                    Method select_server_impl has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                          private def select_server_impl(cluster, ping, session, write_aggregation, deprioritized)
                    Severity: Minor
                    Found in lib/mongo/server_selector/base.rb - About 35 mins to fix

                      Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          def initialize(address, cluster, monitoring, event_listeners, options = {})
                      Severity: Minor
                      Found in lib/mongo/server.rb - About 35 mins to fix

                        Method command_succeeded has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                              def command_succeeded(result, address, operation_id, payload, duration,
                                started_event:, server_connection_id: nil, service_id: nil
                        Severity: Minor
                        Found in lib/mongo/monitoring/publishable.rb - About 35 mins to fix

                          Method create_encrypted_collection has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              def create_encrypted_collection(database, coll_name, coll_opts, kms_provider, master_key)
                          Severity: Minor
                          Found in lib/mongo/client_encryption.rb - About 35 mins to fix

                            Method do_hmac_sha has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                  def do_hmac_sha(digest_name, key_binary_p, input_binary_p,
                                    output_binary_p, status_p)
                            Severity: Minor
                            Found in lib/mongo/crypt/handle.rb - About 35 mins to fix

                              Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                    def initialize(host_name, cert, ca_cert, cert_store, **opts)
                              Severity: Minor
                              Found in lib/mongo/socket/ocsp_verifier.rb - About 35 mins to fix

                                Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                      def initialize(mongocrypt, io, master_key_document, key_alt_names, key_material)
                                Severity: Minor
                                Found in lib/mongo/crypt/data_key_context.rb - About 35 mins to fix

                                  Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                        def initialize(host, port, timeout, family, options = {})
                                  Severity: Minor
                                  Found in lib/mongo/socket/tcp.rb - About 35 mins to fix

                                    Method valid_available_connection? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                                    Open

                                          def valid_available_connection?(connection, pid, connection_global_id)
                                            if connection.pid != pid
                                              log_warn("Detected PID change - Mongo client should have been reconnected (old pid #{connection.pid}, new pid #{pid}")
                                              connection.disconnect!(reason: :stale)
                                              @populate_semaphore.signal
                                    Severity: Minor
                                    Found in lib/mongo/server/connection_pool.rb - About 35 mins to fix

                                    Cognitive Complexity

                                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                    A method's cognitive complexity is based on a few simple rules:

                                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                    • Code is considered more complex for each "break in the linear flow of the code"
                                    • Code is considered more complex when "flow breaking structures are nested"

                                    Further reading

                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language