Showing 393 of 447 total issues
Avoid deeply nested control flow statements. Open
if key.to_s.start_with?("$")
if Mongo.validate_update_replace
raise Error::InvalidReplacementDocument.new(key: key)
else
Error::InvalidReplacementDocument.warn(Logger.logger, key)
Method delete_one
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def delete_one(documents, connection, context, operation_id, session, txn_num)
Avoid deeply nested control flow statements. Open
unless key.to_s.start_with?("$")
if Mongo.validate_update_replace
raise Error::InvalidUpdateDocument.new(key: key)
else
Error::InvalidUpdateDocument.warn(Logger.logger, key)
Method update_many
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def update_many(documents, connection, context, operation_id, session, txn_num)
Method set_cert
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def set_cert(context, options)
# Since we clear cert_text during processing, we need to examine
# ssl_cert_object here to avoid considering it if we have also
# processed the text.
if options[:ssl_cert]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method delete_many
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def delete_many(documents, connection, context, operation_id, session, txn_num)
Method initialize
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def initialize(host, port, host_name, timeout, family, options = {})
Method change_stream_resumable?
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def change_stream_resumable?
if @result && @result.is_a?(Mongo::Operation::GetMore::Result)
# CursorNotFound exceptions are always resumable because the server
# is not aware of the cursor id, and thus cannot determine if
# the cursor is a change stream and cannot add the
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update_one
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
def update_one(documents, connection, context, operation_id, session, txn_num)
Method command_completed
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def command_completed(result, address, operation_id, payload, duration,
started_event:, server_connection_id: nil, service_id: nil
Method generate
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def self.generate(address, operation_id, command_payload,
reply_payload, duration, started_event:, server_connection_id: nil,
service_id: nil
Method select_server_impl
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
private def select_server_impl(cluster, ping, session, write_aggregation, deprioritized)
Method initialize
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def initialize(address, cluster, monitoring, event_listeners, options = {})
Method command_succeeded
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def command_succeeded(result, address, operation_id, payload, duration,
started_event:, server_connection_id: nil, service_id: nil
Method create_encrypted_collection
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def create_encrypted_collection(database, coll_name, coll_opts, kms_provider, master_key)
Method do_hmac_sha
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def do_hmac_sha(digest_name, key_binary_p, input_binary_p,
output_binary_p, status_p)
Method initialize
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def initialize(host_name, cert, ca_cert, cert_store, **opts)
Method initialize
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def initialize(mongocrypt, io, master_key_document, key_alt_names, key_material)
Method initialize
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def initialize(host, port, timeout, family, options = {})
Method valid_available_connection?
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def valid_available_connection?(connection, pid, connection_global_id)
if connection.pid != pid
log_warn("Detected PID change - Mongo client should have been reconnected (old pid #{connection.pid}, new pid #{pid}")
connection.disconnect!(reason: :stale)
@populate_semaphore.signal
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"