Sign upLogin

monotom/html-youtube-mixer

View on GitHub
Star

Showing 4 of 6 total issues

Function AppPlayer has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var AppPlayer = function(id, config){
  config      = $.extend(AppPlayer.default_config, config);
  var self    = this;
  this.ready  = false;
  this.id     = id;
Severity: Minor
Found in js/app-player.js - About 1 hr to fix

    Function AppPlayer has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    var AppPlayer = function(id, config){
  config      = $.extend(AppPlayer.default_config, config);
  var self    = this;
  this.ready  = false;
  this.id     = id;
    Severity: Minor
    Found in js/app-player.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function AppVolumeSlider has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    var AppVolumeSlider = function(id){
  var volume_slider = $('#'+id).slider();
  var volume_slider_state = $('#'+id+'-state');
  var self = this;
    Severity: Minor
    Found in js/app-volume-slider.js - About 1 hr to fix

      Function AppPlayerSearch has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var AppPlayerSearch = function(player){
  var search_button_selector = '#search-'+player.id+'-button';
  var search_input_selector  = '#search-'+player.id+'-input';
  var search_result_selector = '#search-'+player.id+'-result';
      Severity: Minor
      Found in js/app-player-search.js - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language