monsij/StudentPortal

View on GitHub
pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js

Summary

Maintainability
D
2 days
Test Coverage

File DateTimeShortcuts.js has 329 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*global Calendar, findPosX, findPosY, getStyle, get_format, gettext, gettext_noop, interpolate, ngettext, quickElement*/
// Inserts shortcut buttons after all of the following:
//     <input type="text" class="vDateField">
//     <input type="text" class="vTimeField">
(function() {
Severity: Minor
Found in pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js - About 3 hrs to fix

    Function addCalendar has 86 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            addCalendar: function(inp) {
                var num = DateTimeShortcuts.calendars.length;
    
                DateTimeShortcuts.calendarInputs[num] = inp;
                DateTimeShortcuts.dismissCalendarFunc[num] = function() { DateTimeShortcuts.dismissCalendar(num); return true; };
    Severity: Major
    Found in pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js - About 3 hrs to fix

      Function addClock has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              addClock: function(inp) {
                  var num = DateTimeShortcuts.clockInputs.length;
                  DateTimeShortcuts.clockInputs[num] = inp;
                  DateTimeShortcuts.dismissClockFunc[num] = function() { DateTimeShortcuts.dismissClock(num); return true; };
      
      
      Severity: Major
      Found in pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js - About 2 hrs to fix

        Function addTimezoneWarning has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                addTimezoneWarning: function(inp) {
                    var $ = django.jQuery;
                    var warningClass = DateTimeShortcuts.timezoneWarningClass;
                    var timezoneOffset = DateTimeShortcuts.timezoneOffset / 3600;
        
        
        Severity: Minor
        Found in pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (getStyle(document.body, 'direction') !== 'rtl') {
                          cal_box.style.left = findPosX(cal_link) + 17 + 'px';
                      }
                      else {
                          // since style's width is in em, it'd be tough to calculate
          Severity: Major
          Found in pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js and 1 other location - About 2 hrs to fix
          pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js on lines 203..212

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 86.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (getStyle(document.body, 'direction') !== 'rtl') {
                          clock_box.style.left = findPosX(clock_link) + 17 + 'px';
                      }
                      else {
                          // since style's width is in em, it'd be tough to calculate
          Severity: Major
          Found in pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js and 1 other location - About 2 hrs to fix
          pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js on lines 376..385

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 86.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  dismissCalendar: function(num) {
                      document.getElementById(DateTimeShortcuts.calendarDivName1 + num).style.display = 'none';
                      document.removeEventListener('click', DateTimeShortcuts.dismissCalendarFunc[num]);
                  },
          Severity: Major
          Found in pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js and 1 other location - About 1 hr to fix
          pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js on lines 219..222

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  dismissClock: function(num) {
                      document.getElementById(DateTimeShortcuts.clockDivName + num).style.display = 'none';
                      document.removeEventListener('click', DateTimeShortcuts.dismissClockFunc[num]);
                  },
          Severity: Major
          Found in pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js and 1 other location - About 1 hr to fix
          pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js on lines 391..394

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      clock_link.addEventListener('click', function(e) {
                          e.preventDefault();
                          // avoid triggering the document click handler to dismiss the clock
                          e.stopPropagation();
                          DateTimeShortcuts.openClock(num);
          Severity: Minor
          Found in pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js and 1 other location - About 55 mins to fix
          pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js on lines 256..261

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      cal_link.addEventListener('click', function(e) {
                          e.preventDefault();
                          // avoid triggering the document click handler to dismiss the calendar
                          e.stopPropagation();
                          DateTimeShortcuts.openCalendar(num);
          Severity: Minor
          Found in pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js and 1 other location - About 55 mins to fix
          pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js on lines 126..131

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      document.addEventListener('keyup', function(event) {
                          if (event.which === 27) {
                              // ESC key closes popup
                              DateTimeShortcuts.dismissClock(num);
                              event.preventDefault();
          Severity: Minor
          Found in pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js and 1 other location - About 35 mins to fix
          pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js on lines 348..354

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      django.jQuery(document).on('keyup', function(event) {
                          if (event.which === 27) {
                              // ESC key closes popup
                              DateTimeShortcuts.dismissCalendar(num);
                              event.preventDefault();
          Severity: Minor
          Found in pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js and 1 other location - About 35 mins to fix
          pro1/staticfiles/admin/js/admin/DateTimeShortcuts.js on lines 189..195

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status