mozilla/publish.webmaker.org

View on GitHub
api/classes/publisher.js

Summary

Maintainability
C
1 day
Test Coverage

File publisher.js has 363 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"use strict";

const Promise = require(`bluebird`);
const mime = require(`mime`);
const Path = require(`path`);
Severity: Minor
Found in api/classes/publisher.js - About 4 hrs to fix

    Function uploadModifiedFiles has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      uploadModifiedFiles() {
        const publishedProjectId = this.publishedProject.id;
        const remixData = this.remixData;
        const fileRoot = this.publishRoot;
        const username = this.user.name;
    Severity: Minor
    Found in api/classes/publisher.js - About 1 hr to fix

      Function createOrUpdatePublishedProject has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        createOrUpdatePublishedProject() {
          const project = this.project;
          const projectData = {
            title: project.title,
            tags: project.tags,
      Severity: Minor
      Found in api/classes/publisher.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            request.on(`response`, function(response) {
              if (response.statusCode === 200) {
                resolve(`Uploaded "${path}"`);
              } else {
                reject(`S3 upload returned ${response.statusCode}`);
        Severity: Major
        Found in api/classes/publisher.js and 1 other location - About 2 hrs to fix
        api/classes/publisher.js on lines 93..99

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 78.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            request.on(`response`, function(response) {
              if (response.statusCode === 204) {
                resolve(`Deleted "${path}"`);
              } else {
                reject(`S3 delete returned ${response.statusCode}`);
        Severity: Major
        Found in api/classes/publisher.js and 1 other location - About 2 hrs to fix
        api/classes/publisher.js on lines 77..83

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 78.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status