Sign upLogin

mozilla/webmaker.org

View on GitHub
Star
public/js/angular/controllers.js

Summary

Maintainability
D
1 day
Test Coverage

File controllers.js has 614 lines of code (exceeds 250 allowed). Consider refactoring.
Open

angular
  .module('webmakerApp')
  .controller('navigationController', ['$scope', '$location', '$routeParams', '$rootScope', 'weblit', 'wmNav', 'CONFIG',
    function ($scope, $location, $routeParams, $rootScope, weblit, wmNav, config) {
      // Nav data
Severity: Major
Found in public/js/angular/controllers.js - About 1 day to fix

    Function onboardingExperience has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          function onboardingExperience() {
        $('#home-start-form').on('submit', function () {
          $rootScope.joinWebmaker($('.home-email-field').val(), '', $('#onboarding-checkbox').prop('checked'));
        });
        var input = $('.onboarding-input');
    Severity: Minor
    Found in public/js/angular/controllers.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

                if (config.supportLang.indexOf(item) !== -1 &&
            $scope.listLang.indexOf(item) !== 1 && $scope.listLang.length < 1 &&
            item.match(/^[a-z]{2}/) && config.lang.match(/^[a-z]{2}/) &&
            item.match(/^[a-z]{2}/)[0] !== config.lang.match(/^[a-z]{2}/)[0]) {
            $scope.listLang.push(item);
      Severity: Major
      Found in public/js/angular/controllers.js - About 40 mins to fix

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

                  if (matches) {
            if (matches[1] && matches[2]) {
              matchesLang = matches[1].toLowerCase() + matches[2].toUpperCase();
            } else {
              matchesLang = matches[1].toLowerCase();
        Severity: Major
        Found in public/js/angular/controllers.js and 2 other locations - About 2 hrs to fix
        public/js/angular/directives.js on lines 297..303
        public/js/pages/localweb.js on lines 112..118

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 83.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status