Sign upLogin

mpkato/mobileclick

View on GitHub
Star

Showing 7 of 21 total issues

Function add has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def add(self, elem, iid=None):
        '''
        Add Iunit to either the first layer,
        or second layer by specifying intent ID (iid).
        Only Iunit can be added to the second layer
Severity: Minor
Found in mobileclick/summary.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function read has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def read(cls, queryfilepath, iunitfilepath, indexdirpath, webpagedirpath,
        intentfilepath=None):
        '''
        Read all the data
        '''
Severity: Minor
Found in mobileclick/task.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _validation has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def _validation(self):
        '''
        Validation to ensure the format is valid
        '''
        # The first layer consists of only Iunit or Intent
Severity: Minor
Found in mobileclick/summary.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, qid, rank, filepath, title, url, body):
Severity: Minor
Found in mobileclick/index.py - About 45 mins to fix

    Function read has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def read(cls, queryfilepath, iunitfilepath, indexdirpath, webpagedirpath,
    Severity: Minor
    Found in mobileclick/task.py - About 35 mins to fix

      Function download_and_deploy has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      def download_and_deploy(datafilenames):
    import sys, os, getpass
    email = os.environ.get('MOBILECLICK_EMAIL', None)
    password = os.environ.get('MOBILECLICK_PASSWORD', None)
    if email is None or password is None:
      Severity: Minor
      Found in mobileclick/scripts/mobileclick_download_data.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _count has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def _count(self, tasks):
        '''
        Count the frequency of words
        Return: (task_word_freq, total_word_freq)
        '''
      Severity: Minor
      Found in mobileclick/methods/lang_model.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language