mre/kafka-influxdb

View on GitHub

Showing 12 of 22 total issues

Function consume has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def consume(self):
        """
        Run loop. Consume messages from reader, convert it to the
        output format using encoder and write to output with writer
        """
Severity: Minor
Found in kafka_influxdb/worker.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function encode has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def encode(self,
               msg,
               delimiter='.',
               prefix='',
               prefix_tag=None,
Severity: Minor
Found in kafka_influxdb/encoder/collectd_graphite_encoder.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 11 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self,
Severity: Major
Found in kafka_influxdb/writer/influxdb_writer.py - About 1 hr to fix

    Function _handle_read has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def _handle_read(self):
            """
            Read messages from Kafka.
            """
            while True:
    Severity: Minor
    Found in kafka_influxdb/reader/confluent.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function parse_args has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    def parse_args(args=sys.argv[1:]):
        parser = argparse.ArgumentParser(description='A Kafka consumer for InfluxDB',
                                         formatter_class=argparse.ArgumentDefaultsHelpFormatter)
        parser.add_argument('--kafka_host', type=str, default=argparse.SUPPRESS,
                            help="Hostname or IP of Kafka message broker (default: localhost)")
    Severity: Minor
    Found in kafka_influxdb/config/loader.py - About 1 hr to fix

      Function load_reader has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def load_reader(name, host, port, group, topic, offset):
      Severity: Minor
      Found in kafka_influxdb/reader/__init__.py - About 45 mins to fix

        Function encode has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def encode(self,
        Severity: Minor
        Found in kafka_influxdb/encoder/collectd_graphite_encoder.py - About 45 mins to fix

          Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def __init__(self, host, port, group, topic, offset, broker_version=KAFKA_VERSION_ZOOKEEPER_OPTIONAL):
          Severity: Minor
          Found in kafka_influxdb/reader/reader.py - About 45 mins to fix

            Function encode has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def encode(self, msg):
                    # type: (bytes) -> List[Text]
                    measurements = []
            
                    for line in msg.decode().split("\n"):
            Severity: Minor
            Found in kafka_influxdb/encoder/collectd_json_encoder.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function flatten has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            def flatten(d, parent_key='', sep='_'):
                """
                Flatten keys in a dictionary
                Example:
                flatten({'a': 1, 'c': {'a': 2, 'b': {'x': 5, 'y' : 10}}, 'd': [1, 2, 3]})
            Severity: Minor
            Found in kafka_influxdb/config/loader.py - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function format_measurement_name has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def format_measurement_name(entry, args):
                    name = []
                    for arg in args:
                        if arg in entry:
                            # avoid to add extra _ if some entry value is None
            Severity: Minor
            Found in kafka_influxdb/encoder/collectd_json_encoder.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function format_tags has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def format_tags(entry, args):
                    tag = []
                    for arg in args:
                        if arg in entry:
                            # to avoid add None as tag value
            Severity: Minor
            Found in kafka_influxdb/encoder/collectd_json_encoder.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language