Sign upLogin

mrgodhani/raven-reader

View on GitHub
Star
src/main/pocket.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function signInPocketWithPopUp has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function signInPocketWithPopUp () {
  return new Promise((resolve, reject) => {
    let consumerKey
    let code
    const authWindow = new BrowserWindow({
Severity: Major
Found in src/main/pocket.js - About 3 hrs to fix

    Function handleNavigation has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function handleNavigation (url) {
      const urlItem = new URL(url)
      const params = urlItem.searchParams
      const hostname = urlItem.hostname
      if (params) {
    Severity: Minor
    Found in src/main/pocket.js - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                axios
            .post(
              'https://getpocket.com/v3/oauth/authorize', {
                consumer_key: consumerKey,
                code: code
      Severity: Minor
      Found in src/main/pocket.js and 1 other location - About 40 mins to fix
      src/background.js on lines 221..237

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          axios
      .post(
        'https://getpocket.com/v3/oauth/request', {
          consumer_key: consumerKey,
          redirect_uri: 'http://127.0.0.1'
      Severity: Minor
      Found in src/main/pocket.js and 1 other location - About 40 mins to fix
      src/background.js on lines 171..187

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status