Sign upLogin

msimerson/Haraka

View on GitHub
Star
plugins/avg.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function hook_data_post has 109 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.hook_data_post = function (next, connection) {
    if (!connection?.transaction) return next()

    const plugin = this;
    const tmpfile = plugin.get_tmp_file(connection.transaction);
Severity: Major
Found in plugins/avg.js - About 4 hrs to fix

    Avoid too many return statements within this function.
    Open

                        if (!plugin.cfg.defer.error) return do_next();
    Severity: Major
    Found in plugins/avg.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                                  return do_next();
      Severity: Major
      Found in plugins/avg.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                            return do_next(DENYSOFT, 'Virus scanner error (AVG)');
        Severity: Major
        Found in plugins/avg.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                                  return do_next(DENYSOFT, 'Virus scanner error (AVG)');
          Severity: Major
          Found in plugins/avg.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                                        return do_next(DENY, response.join(' '));
            Severity: Major
            Found in plugins/avg.js - About 30 mins to fix

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                  this.cfg = this.config.get('avg.ini', {
        booleans: [
            '+defer.timeout',
            '+defer.error',
        ],
              Severity: Major
              Found in plugins/avg.js and 4 other locations - About 40 mins to fix
              plugins/dnsbl.js on lines 22..26
              plugins/greylist.js on lines 34..41
              plugins/mail_from.is_resolvable.js on lines 14..21
              plugins/queue/smtp_proxy.js on lines 20..28

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status