Sign upLogin

msimerson/Haraka

View on GitHub
Star
plugins/dkim_sign.js

Summary

Maintainability
D
2 days
Test Coverage

File dkim_sign.js has 290 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// dkim_signer
// Implements DKIM core as per www.dkimcore.org

const addrparser = require('address-rfc2822');
const async      = require('async');
Severity: Minor
Found in plugins/dkim_sign.js - About 2 hrs to fix

    Function write has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        write (buf) {
        /*
        ** BODY (simple canonicalization)
        */
    Severity: Minor
    Found in plugins/dkim_sign.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_sender_domain has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.get_sender_domain = function (connection) {

    const txn = connection?.transaction;
    if (!txn) return;
    Severity: Minor
    Found in plugins/dkim_sign.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function get_sender_domain has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.get_sender_domain = function (connection) {

    const txn = connection?.transaction;
    if (!txn) return;
    Severity: Minor
    Found in plugins/dkim_sign.js - About 1 hr to fix

      Function write has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          write (buf) {
        /*
        ** BODY (simple canonicalization)
        */
      Severity: Minor
      Found in plugins/dkim_sign.js - About 1 hr to fix

        Function get_sign_properties has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports.get_sign_properties = function (connection, done) {
    if (!connection.transaction) return;

    const domain = this.get_sender_domain(connection);
        Severity: Minor
        Found in plugins/dkim_sign.js - About 1 hr to fix

          Function end has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              end (buf) {
        this.writable = false;

        // Add trailing CRLF if we have data left over
        if (this.buffer.ar.length) {
          Severity: Minor
          Found in plugins/dkim_sign.js - About 1 hr to fix

            Function hook_pre_send_trans_email has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            exports.hook_queue_outbound = exports.hook_pre_send_trans_email = function (next, connection) {
    if (this.cfg.main.disabled) return next();
    if (!connection?.transaction) return next();

    if (connection.transaction.notes?.dkim_signed) {
            Severity: Minor
            Found in plugins/dkim_sign.js - About 1 hr to fix

              Function hook_pre_send_trans_email has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              exports.hook_queue_outbound = exports.hook_pre_send_trans_email = function (next, connection) {
    if (this.cfg.main.disabled) return next();
    if (!connection?.transaction) return next();

    if (connection.transaction.notes?.dkim_signed) {
              Severity: Minor
              Found in plugins/dkim_sign.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function has_key_data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              exports.has_key_data = function (conn, props) {

    let missing = undefined;

    // Make sure we have all the relevant configuration
              Severity: Minor
              Found in plugins/dkim_sign.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function end has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  end (buf) {
        this.writable = false;

        // Add trailing CRLF if we have data left over
        if (this.buffer.ar.length) {
              Severity: Minor
              Found in plugins/dkim_sign.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this function.
              Open

                  if (!addrs || ! addrs.length) return domain;
              Severity: Major
              Found in plugins/dkim_sign.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return fromHost;
                Severity: Major
                Found in plugins/dkim_sign.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return domain;
                  Severity: Major
                  Found in plugins/dkim_sign.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return domain;
                    Severity: Major
                    Found in plugins/dkim_sign.js - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          this.cfg = this.config.get('dkim_sign.ini', {
        booleans: [
            '-disabled',
        ]
    },
                      Severity: Minor
                      Found in plugins/dkim_sign.js and 1 other location - About 40 mins to fix
                      plugins/queue/qmail-queue.js on lines 22..29

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 48.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  if (!props.selector) {
                connection.transaction.results.add(this, {err: `missing selector for domain ${domain}`});
            }
                      Severity: Minor
                      Found in plugins/dkim_sign.js and 1 other location - About 40 mins to fix
                      plugins/dkim_sign.js on lines 240..242

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 48.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  if (!props.private_key) {
                connection.transaction.results.add(this, {err: `missing dkim private_key for domain ${domain}`});
            }
                      Severity: Minor
                      Found in plugins/dkim_sign.js and 1 other location - About 40 mins to fix
                      plugins/dkim_sign.js on lines 237..239

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 48.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status