Sign upLogin

msimerson/Haraka

View on GitHub
Star
plugins/relay.js

Summary

Maintainability
C
1 day
Test Coverage

Function is_acl_allowed has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

exports.is_acl_allowed = function (connection) {
    if (!this.acl_allow) { return false; }
    if (!this.acl_allow.length) { return false; }

    const { ip } = connection.remote;
Severity: Minor
Found in plugins/relay.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function dest_domains has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.dest_domains = function (next, connection, params) {
    if (!this.cfg.relay.dest_domains) { return next(); }
    const { relaying, transaction } = connection ?? {}
    if (!transaction) return next();
Severity: Minor
Found in plugins/relay.js - About 1 hr to fix

    Function dest_domains has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.dest_domains = function (next, connection, params) {
    if (!this.cfg.relay.dest_domains) { return next(); }
    const { relaying, transaction } = connection ?? {}
    if (!transaction) return next();
    Severity: Minor
    Found in plugins/relay.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function force_routing has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.force_routing = function (next, hmail, domain) {
    if (!this.cfg.relay.force_routing) { return next(); }
    if (!this.dest) { return next(); }
    if (!this.dest.domains) { return next(); }
    let route = this.dest.domains[domain];
    Severity: Minor
    Found in plugins/relay.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

        return next(OK, nexthop);
    Severity: Major
    Found in plugins/relay.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return next(DENY, "Mail for that recipient is not accepted here.");
      Severity: Major
      Found in plugins/relay.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return next(CONT);  // same as next()
        Severity: Major
        Found in plugins/relay.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return next(DENY, "You are not allowed to relay");
          Severity: Major
          Found in plugins/relay.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return next(OK);
            Severity: Major
            Found in plugins/relay.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return next(DENY, "You are not allowed to relay");
              Severity: Major
              Found in plugins/relay.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return next();
                Severity: Major
                Found in plugins/relay.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return next();
                  Severity: Major
                  Found in plugins/relay.js - About 30 mins to fix

                    Function register has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    exports.register = function () {

    this.load_relay_ini();             // plugin.cfg = { }

    if (this.cfg.relay.acl) {
                    Severity: Minor
                    Found in plugins/relay.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function load_acls has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    exports.load_acls = function () {
    const file_name = 'relay_acl_allow';

    // load with a self-referential callback
    this.acl_allow = this.config.get(file_name, 'list', () => {
                    Severity: Minor
                    Found in plugins/relay.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if (!this.dest.domains) {
        transaction.results.add(this, {skip: 'relay_dest_domain(config)'});
        return next();
    }
                    Severity: Minor
                    Found in plugins/relay.js and 1 other location - About 30 mins to fix
                    plugins/helo.checks.js on lines 292..295

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 45.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status