Sign upLogin

msimerson/Haraka

View on GitHub
Star
plugins/xclient.js

Summary

Maintainability
C
1 day
Test Coverage

Function hook_unrecognized_command has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
Open

exports.hook_unrecognized_command = function (next, connection, params) {
    if (params[0] !== 'XCLIENT') return next();

    // XCLIENT is not allowed after transaction start
    if (connection?.transaction) {
Severity: Minor
Found in plugins/xclient.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function hook_unrecognized_command has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.hook_unrecognized_command = function (next, connection, params) {
    if (params[0] !== 'XCLIENT') return next();

    // XCLIENT is not allowed after transaction start
    if (connection?.transaction) {
Severity: Major
Found in plugins/xclient.js - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                        else if (!/\[UNAVAILABLE\]/i.test(match[2])) {
                        // IPv4
                        if (net.isIPv4(match[2])) {
                            xclient[match[1]] = match[2];
                        }
    Severity: Major
    Found in plugins/xclient.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if (net.isIPv6(ipv6[1])) {
                            xclient[match[1]] = ipv6[1];
                        }
      Severity: Major
      Found in plugins/xclient.js - About 45 mins to fix

        Avoid too many return statements within this function.
        Open

            return next(NEXT_HOOK, 'connect');
        Severity: Major
        Found in plugins/xclient.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              if (!xclient.name) return next(NEXT_HOOK, 'lookup_rdns');
          Severity: Major
          Found in plugins/xclient.js - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status