Sign upLogin

msimerson/Haraka

View on GitHub
Star
transaction.js

Summary

Maintainability
C
1 day
Test Coverage

Function end_data has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    end_data (cb) {
        if (!this.found_hb_sep && this.header_lines.length) {
            // Headers not parsed yet - must be a busted email
            // Strategy: Find the first line that doesn't look like a header.
            // Treat anything before that as headers, anything after as body.
Severity: Minor
Found in transaction.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function add_dot_stuffing_and_ensure_crlf_newlines has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    add_dot_stuffing_and_ensure_crlf_newlines (data) {
        if (!data.length) return data;
        if (!Buffer.isBuffer(data)) data = Buffer.from(data);

        // Make a new buffer big enough to hold two bytes for every one input
Severity: Minor
Found in transaction.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function add_data has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    add_data (line) {
        if (typeof line === 'string') { // This shouldn't ever happen.
            line = Buffer.from(line, this.encoding);
        }
        // is this the end of headers line?
Severity: Minor
Found in transaction.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function add_dot_stuffing_and_ensure_crlf_newlines has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    add_dot_stuffing_and_ensure_crlf_newlines (data) {
        if (!data.length) return data;
        if (!Buffer.isBuffer(data)) data = Buffer.from(data);

        // Make a new buffer big enough to hold two bytes for every one input
Severity: Minor
Found in transaction.js - About 1 hr to fix

    Function end_data has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        end_data (cb) {
        if (!this.found_hb_sep && this.header_lines.length) {
            // Headers not parsed yet - must be a busted email
            // Strategy: Find the first line that doesn't look like a header.
            // Treat anything before that as headers, anything after as body.
    Severity: Minor
    Found in transaction.js - About 1 hr to fix

      Function constructor has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          constructor (uuid, cfg) {
        this.uuid = uuid || utils.uuid();
        this.cfg = cfg || load_smtp_ini();
        this.mail_from = null;
        this.rcpt_to = [];
      Severity: Minor
      Found in transaction.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            add_leading_header (key, value) {
        this.header.add(key, value);
        if (this.header_pos > 0) this.reset_headers();
    }
        Severity: Minor
        Found in transaction.js and 1 other location - About 40 mins to fix
        transaction.js on lines 209..212

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            add_header (key, value) {
        this.header.add_end(key, value);
        if (this.header_pos > 0) this.reset_headers();
    }
        Severity: Minor
        Found in transaction.js and 1 other location - About 40 mins to fix
        transaction.js on lines 214..217

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status