mundipagg/magento2

View on GitHub
view/frontend/web/js/core/models/TwoCreditcardsModel.js

Summary

Maintainability
F
1 wk
Test Coverage

Function getData has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

TwoCreditcardsModel.prototype.getData = function () {
    var data = this.fillData();

    if (
        typeof this.formObject[0].multibuyer.showMultibuyer != 'undefined' &&
Severity: Minor
Found in view/frontend/web/js/core/models/TwoCreditcardsModel.js - About 1 hr to fix

    Function fillData has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    TwoCreditcardsModel.prototype.fillData = function () {
    
        var saveFirstCard = 0;
        var saveSecondCard = 0;
    
    
    Severity: Minor
    Found in view/frontend/web/js/core/models/TwoCreditcardsModel.js - About 1 hr to fix

      Function placeOrder has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      TwoCreditcardsModel.prototype.placeOrder = function (placeOrderObject) {
          this.placeOrderObject = placeOrderObject;
          var _self = this;
          var errors = false;
      
      
      Severity: Minor
      Found in view/frontend/web/js/core/models/TwoCreditcardsModel.js - About 1 hr to fix

        Function placeOrder has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        TwoCreditcardsModel.prototype.placeOrder = function (placeOrderObject) {
            this.placeOrderObject = placeOrderObject;
            var _self = this;
            var errors = false;
        
        
        Severity: Minor
        Found in view/frontend/web/js/core/models/TwoCreditcardsModel.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function validate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        TwoCreditcardsModel.prototype.validate = function () {
        
            var formsInvalid = [];
        
            for (id in this.formObject) {
        Severity: Minor
        Found in view/frontend/web/js/core/models/TwoCreditcardsModel.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if (
                typeof this.formObject[0].multibuyer.showMultibuyer != 'undefined' &&
                this.formObject[0].multibuyer.showMultibuyer.prop( "checked" ) == true
            ) {
                multibuyer = this.formObject[0].multibuyer;
        Severity: Major
        Found in view/frontend/web/js/core/models/TwoCreditcardsModel.js and 1 other location - About 2 days to fix
        view/frontend/web/js/core/models/TwoCreditcardsModel.js on lines 125..145

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 433.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if (
                typeof this.formObject[1].multibuyer.showMultibuyer != 'undefined' &&
                this.formObject[1].multibuyer.showMultibuyer.prop( "checked" ) == true
            ) {
                multibuyer = this.formObject[1].multibuyer;
        Severity: Major
        Found in view/frontend/web/js/core/models/TwoCreditcardsModel.js and 1 other location - About 2 days to fix
        view/frontend/web/js/core/models/TwoCreditcardsModel.js on lines 103..123

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 433.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if (
                    typeof this.formObject[id].savedCreditCardSelect.val() != 'undefined' &&
                    this.formObject[id].savedCreditCardSelect.val() != 'new' &&
                    this.formObject[id].savedCreditCardSelect.val() != '' &&
                    this.formObject[id].savedCreditCardSelect.html().length > 1
        Severity: Major
        Found in view/frontend/web/js/core/models/TwoCreditcardsModel.js and 1 other location - About 4 hrs to fix
        view/frontend/web/js/core/models/BoletoCreditcardModel.js on lines 20..27

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 118.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        var TwoCreditcardsModel= function (formObject, publicKey) {
            this.formObject = formObject;
            this.publicKey = publicKey;
            this.modelToken = new CreditCardToken(this.formObject);
            this.errors = [];
        Severity: Major
        Found in view/frontend/web/js/core/models/TwoCreditcardsModel.js and 1 other location - About 2 hrs to fix
        view/frontend/web/js/core/models/BoletoCreditcardModel.js on lines 1..7

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 81.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                this.getCreditCardToken(
                    this.formObject[id],
                    function (data) {
                        _self.formObject[id].creditCardToken.val(data.id);
                    },
        Severity: Major
        Found in view/frontend/web/js/core/models/TwoCreditcardsModel.js and 1 other location - About 2 hrs to fix
        view/frontend/web/js/core/models/BoletoCreditcardModel.js on lines 29..38

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 78.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        TwoCreditcardsModel.prototype.getLastFourNumbers = function(id) {
            var number = this.formObject[id].creditCardNumber.val();
            if (number !== undefined) {
                return number.slice(-4);
            }
        Severity: Major
        Found in view/frontend/web/js/core/models/TwoCreditcardsModel.js and 1 other location - About 1 hr to fix
        view/frontend/web/js/core/models/BoletoCreditcardModel.js on lines 181..187

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        TwoCreditcardsModel.prototype.getFormIdInverted = function (id) {
            var ids = this.formIds.slice(0);
            var index = ids.indexOf(id);
            ids.splice(index, 1);
        
        
        Severity: Major
        Found in view/frontend/web/js/core/models/TwoCreditcardsModel.js and 1 other location - About 1 hr to fix
        view/frontend/web/js/core/models/BoletoCreditcardModel.js on lines 46..52

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        TwoCreditcardsModel.prototype.getCreditCardToken = function (formObject, success, error) {
            var modelToken = new CreditCardToken(formObject);
            modelToken.getToken(this.publicKey)
                .done(success)
                .fail(error);
        Severity: Major
        Found in view/frontend/web/js/core/models/TwoCreditcardsModel.js and 1 other location - About 1 hr to fix
        view/frontend/web/js/core/models/BoletoCreditcardModel.js on lines 60..65

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status