core/modules/_core/res/js/crud/default.js

Summary

Maintainability
B
6 hrs
Test Coverage

Consider simplifying this complex logical expression.
Open

            if (null !== a) {
                var l = n(this), q = l ? this.contentWindow || window : this, r = $(q), e = a, f = {}, t;
                switch (typeof e) {
                    case "number":
                    case "string":
Severity: Critical
Found in core/modules/_core/res/js/crud/default.js - About 3 hrs to fix

    Function has a complexity of 13.
    Open

            return this.each(function () {

    Limit Cyclomatic Complexity (complexity)

    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

    function a(x) {
        if (true) {
            return x; // 1st path
        } else if (false) {
            return x+1; // 2nd path
        } else {
            return 4; // 3rd path
        }
    }

    Rule Details

    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

    Examples of incorrect code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else if (false) {
            return x+1;
        } else {
            return 4; // 3rd path
        }
    }

    Examples of correct code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else {
            return 4;
        }
    }

    Options

    Optionally, you may specify a max object property:

    "complexity": ["error", 2]

    is equivalent to

    "complexity": ["error", { "max": 2 }]

    Deprecated: the object property maximum is deprecated. Please use the property max instead.

    When Not To Use It

    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

    Further Reading

    Related Rules

    • [max-depth](max-depth.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md)
    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

    Function has a complexity of 11.
    Open

                    $.each(b.axis.split(""), function (a, c) {

    Limit Cyclomatic Complexity (complexity)

    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

    function a(x) {
        if (true) {
            return x; // 1st path
        } else if (false) {
            return x+1; // 2nd path
        } else {
            return 4; // 3rd path
        }
    }

    Rule Details

    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

    Examples of incorrect code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else if (false) {
            return x+1;
        } else {
            return 4; // 3rd path
        }
    }

    Examples of correct code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/
    
    function a(x) {
        if (true) {
            return x;
        } else {
            return 4;
        }
    }

    Options

    Optionally, you may specify a max object property:

    "complexity": ["error", 2]

    is equivalent to

    "complexity": ["error", { "max": 2 }]

    Deprecated: the object property maximum is deprecated. Please use the property max instead.

    When Not To Use It

    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

    Further Reading

    Related Rules

    • [max-depth](max-depth.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md)
    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

    Function scrollTo has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        $.fn.scrollTo = function (a, d, b) {
            "object" === typeof d && (b = d, d = 0);
            "function" === typeof b && (b = {onAfter: b});
            "max" === a && (a = 9E9);
            b = $.extend({}, p.defaults, b);
    Severity: Minor
    Found in core/modules/_core/res/js/crud/default.js - About 1 hr to fix

      Expected a 'break' statement before 'case'.
      Open

                          case "object":

      Disallow Case Statement Fallthrough (no-fallthrough)

      The switch statement in JavaScript is one of the more error-prone constructs of the language thanks in part to the ability to "fall through" from one case to the next. For example:

      switch(foo) {
          case 1:
              doSomething();
      
          case 2:
              doSomethingElse();
      }

      In this example, if foo is 1, then execution will flow through both cases, as the first falls through to the second. You can prevent this by using break, as in this example:

      switch(foo) {
          case 1:
              doSomething();
              break;
      
          case 2:
              doSomethingElse();
      }

      That works fine when you don't want a fallthrough, but what if the fallthrough is intentional, there is no way to indicate that in the language. It's considered a best practice to always indicate when a fallthrough is intentional using a comment which matches the /falls?\s?through/i regular expression:

      switch(foo) {
          case 1:
              doSomething();
              // falls through
      
          case 2:
              doSomethingElse();
      }
      
      switch(foo) {
          case 1:
              doSomething();
              // fall through
      
          case 2:
              doSomethingElse();
      }
      
      switch(foo) {
          case 1:
              doSomething();
              // fallsthrough
      
          case 2:
              doSomethingElse();
      }

      In this example, there is no confusion as to the expected behavior. It is clear that the first case is meant to fall through to the second case.

      Rule Details

      This rule is aimed at eliminating unintentional fallthrough of one case to the other. As such, it flags any fallthrough scenarios that are not marked by a comment.

      Examples of incorrect code for this rule:

      /*eslint no-fallthrough: "error"*/
      
      switch(foo) {
          case 1:
              doSomething();
      
          case 2:
              doSomething();
      }

      Examples of correct code for this rule:

      /*eslint no-fallthrough: "error"*/
      
      switch(foo) {
          case 1:
              doSomething();
              break;
      
          case 2:
              doSomething();
      }
      
      function bar(foo) {
          switch(foo) {
              case 1:
                  doSomething();
                  return;
      
              case 2:
                  doSomething();
          }
      }
      
      switch(foo) {
          case 1:
              doSomething();
              throw new Error("Boo!");
      
          case 2:
              doSomething();
      }
      
      switch(foo) {
          case 1:
          case 2:
              doSomething();
      }
      
      switch(foo) {
          case 1:
              doSomething();
              // falls through
      
          case 2:
              doSomething();
      }

      Note that the last case statement in these examples does not cause a warning because there is nothing to fall through into.

      Options

      This rule accepts a single options argument:

      • Set the commentPattern option to a regular expression string to change the test for intentional fallthrough comment

      commentPattern

      Examples of correct code for the { "commentPattern": "break[\\s\\w]*omitted" } option:

      /*eslint no-fallthrough: ["error", { "commentPattern": "break[\\s\\w]*omitted" }]*/
      
      switch(foo) {
          case 1:
              doSomething();
              // break omitted
      
          case 2:
              doSomething();
      }
      
      switch(foo) {
          case 1:
              doSomething();
              // caution: break is omitted intentionally
      
          default:
              doSomething();
      }

      When Not To Use It

      If you don't want to enforce that each case statement should end with a throw, return, break, or comment, then you can safely turn this rule off.

      Related Rules

      Expected an assignment or function call and instead saw an expression.
      Open

                          t ? (f[g] = t[m] + (l ? 0 : h - r.offset()[m]), b.margin && (f[g] -= parseInt(e.css("margin" + d), 10) || 0, f[g] -= parseInt(e.css("border" + d + "Width"), 10) || 0), f[g] += v[m] || 0, b.over[m] && (f[g] += e["x" === c ? "width" : "height"]() * b.over[m])) : (d = e[m], f[g] = d.slice && "%" === d.slice(-1) ? parseFloat(d) / 100 * n : d);

      Disallow Unused Expressions (no-unused-expressions)

      An unused expression which has no effect on the state of the program indicates a logic error.

      For example, n + 1; is not a syntax error, but it might be a typing mistake where a programmer meant an assignment statement n += 1; instead.

      Rule Details

      This rule aims to eliminate unused expressions which have no effect on the state of the program.

      This rule does not apply to function calls or constructor calls with the new operator, because they could have side effects on the state of the program.

      var i = 0;
      function increment() { i += 1; }
      increment(); // return value is unused, but i changed as a side effect
      
      var nThings = 0;
      function Thing() { nThings += 1; }
      new Thing(); // constructed object is unused, but nThings changed as a side effect

      This rule does not apply to directives (which are in the form of literal string expressions such as "use strict"; at the beginning of a script, module, or function).

      Sequence expressions (those using a comma, such as a = 1, b = 2) are always considered unused unless their return value is assigned or used in a condition evaluation, or a function call is made with the sequence expression value.

      Options

      This rule, in its default state, does not require any arguments. If you would like to enable one or more of the following you may pass an object with the options set as follows:

      • allowShortCircuit set to true will allow you to use short circuit evaluations in your expressions (Default: false).
      • allowTernary set to true will enable you to use ternary operators in your expressions similarly to short circuit evaluations (Default: false).
      • allowTaggedTemplates set to true will enable you to use tagged template literals in your expressions (Default: false).

      These options allow unused expressions only if all of the code paths either directly change the state (for example, assignment statement) or could have side effects (for example, function call).

      Examples of incorrect code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      0
      
      if(0) 0
      
      {0}
      
      f(0), {}
      
      a && b()
      
      a, b()
      
      c = a, b;
      
      a() && function namedFunctionInExpressionContext () {f();}
      
      (function anIncompleteIIFE () {});
      
      injectGlobal`body{ color: red; }`

      Note that one or more string expression statements (with or without semi-colons) will only be considered as unused if they are not in the beginning of a script, module, or function (alone and uninterrupted by other statements). Otherwise, they will be treated as part of a "directive prologue", a section potentially usable by JavaScript engines. This includes "strict mode" directives.

      "use strict";
      "use asm"
      "use stricter";
      "use babel"
      "any other strings like this in the prologue";

      Examples of correct code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      {} // In this context, this is a block statement, not an object literal
      
      {myLabel: someVar} // In this context, this is a block statement with a label and expression, not an object literal
      
      function namedFunctionDeclaration () {}
      
      (function aGenuineIIFE () {}());
      
      f()
      
      a = 0
      
      new C
      
      delete a.b
      
      void a

      allowShortCircuit

      Examples of incorrect code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a || b

      Examples of correct code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a && b()
      a() || (b = c)

      allowTernary

      Examples of incorrect code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b : 0
      a ? b : c()

      Examples of correct code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b() : c()
      a ? (b = c) : d()

      allowShortCircuit and allowTernary

      Examples of correct code for the { "allowShortCircuit": true, "allowTernary": true } options:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true, "allowTernary": true }]*/
      
      a ? b() || (c = d) : e()

      allowTaggedTemplates

      Examples of incorrect code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      `some untagged template string`;

      Examples of correct code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      tag`some tagged template string`;

      Source: http://eslint.org/docs/rules/

      Expected an assignment or function call and instead saw an expression.
      Open

              "object" === typeof d && (b = d, d = 0);

      Disallow Unused Expressions (no-unused-expressions)

      An unused expression which has no effect on the state of the program indicates a logic error.

      For example, n + 1; is not a syntax error, but it might be a typing mistake where a programmer meant an assignment statement n += 1; instead.

      Rule Details

      This rule aims to eliminate unused expressions which have no effect on the state of the program.

      This rule does not apply to function calls or constructor calls with the new operator, because they could have side effects on the state of the program.

      var i = 0;
      function increment() { i += 1; }
      increment(); // return value is unused, but i changed as a side effect
      
      var nThings = 0;
      function Thing() { nThings += 1; }
      new Thing(); // constructed object is unused, but nThings changed as a side effect

      This rule does not apply to directives (which are in the form of literal string expressions such as "use strict"; at the beginning of a script, module, or function).

      Sequence expressions (those using a comma, such as a = 1, b = 2) are always considered unused unless their return value is assigned or used in a condition evaluation, or a function call is made with the sequence expression value.

      Options

      This rule, in its default state, does not require any arguments. If you would like to enable one or more of the following you may pass an object with the options set as follows:

      • allowShortCircuit set to true will allow you to use short circuit evaluations in your expressions (Default: false).
      • allowTernary set to true will enable you to use ternary operators in your expressions similarly to short circuit evaluations (Default: false).
      • allowTaggedTemplates set to true will enable you to use tagged template literals in your expressions (Default: false).

      These options allow unused expressions only if all of the code paths either directly change the state (for example, assignment statement) or could have side effects (for example, function call).

      Examples of incorrect code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      0
      
      if(0) 0
      
      {0}
      
      f(0), {}
      
      a && b()
      
      a, b()
      
      c = a, b;
      
      a() && function namedFunctionInExpressionContext () {f();}
      
      (function anIncompleteIIFE () {});
      
      injectGlobal`body{ color: red; }`

      Note that one or more string expression statements (with or without semi-colons) will only be considered as unused if they are not in the beginning of a script, module, or function (alone and uninterrupted by other statements). Otherwise, they will be treated as part of a "directive prologue", a section potentially usable by JavaScript engines. This includes "strict mode" directives.

      "use strict";
      "use asm"
      "use stricter";
      "use babel"
      "any other strings like this in the prologue";

      Examples of correct code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      {} // In this context, this is a block statement, not an object literal
      
      {myLabel: someVar} // In this context, this is a block statement with a label and expression, not an object literal
      
      function namedFunctionDeclaration () {}
      
      (function aGenuineIIFE () {}());
      
      f()
      
      a = 0
      
      new C
      
      delete a.b
      
      void a

      allowShortCircuit

      Examples of incorrect code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a || b

      Examples of correct code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a && b()
      a() || (b = c)

      allowTernary

      Examples of incorrect code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b : 0
      a ? b : c()

      Examples of correct code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b() : c()
      a ? (b = c) : d()

      allowShortCircuit and allowTernary

      Examples of correct code for the { "allowShortCircuit": true, "allowTernary": true } options:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true, "allowTernary": true }]*/
      
      a ? b() || (c = d) : e()

      allowTaggedTemplates

      Examples of incorrect code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      `some untagged template string`;

      Examples of correct code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      tag`some tagged template string`;

      Source: http://eslint.org/docs/rules/

      Expected an assignment or function call and instead saw an expression.
      Open

              u && (d /= 2);

      Disallow Unused Expressions (no-unused-expressions)

      An unused expression which has no effect on the state of the program indicates a logic error.

      For example, n + 1; is not a syntax error, but it might be a typing mistake where a programmer meant an assignment statement n += 1; instead.

      Rule Details

      This rule aims to eliminate unused expressions which have no effect on the state of the program.

      This rule does not apply to function calls or constructor calls with the new operator, because they could have side effects on the state of the program.

      var i = 0;
      function increment() { i += 1; }
      increment(); // return value is unused, but i changed as a side effect
      
      var nThings = 0;
      function Thing() { nThings += 1; }
      new Thing(); // constructed object is unused, but nThings changed as a side effect

      This rule does not apply to directives (which are in the form of literal string expressions such as "use strict"; at the beginning of a script, module, or function).

      Sequence expressions (those using a comma, such as a = 1, b = 2) are always considered unused unless their return value is assigned or used in a condition evaluation, or a function call is made with the sequence expression value.

      Options

      This rule, in its default state, does not require any arguments. If you would like to enable one or more of the following you may pass an object with the options set as follows:

      • allowShortCircuit set to true will allow you to use short circuit evaluations in your expressions (Default: false).
      • allowTernary set to true will enable you to use ternary operators in your expressions similarly to short circuit evaluations (Default: false).
      • allowTaggedTemplates set to true will enable you to use tagged template literals in your expressions (Default: false).

      These options allow unused expressions only if all of the code paths either directly change the state (for example, assignment statement) or could have side effects (for example, function call).

      Examples of incorrect code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      0
      
      if(0) 0
      
      {0}
      
      f(0), {}
      
      a && b()
      
      a, b()
      
      c = a, b;
      
      a() && function namedFunctionInExpressionContext () {f();}
      
      (function anIncompleteIIFE () {});
      
      injectGlobal`body{ color: red; }`

      Note that one or more string expression statements (with or without semi-colons) will only be considered as unused if they are not in the beginning of a script, module, or function (alone and uninterrupted by other statements). Otherwise, they will be treated as part of a "directive prologue", a section potentially usable by JavaScript engines. This includes "strict mode" directives.

      "use strict";
      "use asm"
      "use stricter";
      "use babel"
      "any other strings like this in the prologue";

      Examples of correct code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      {} // In this context, this is a block statement, not an object literal
      
      {myLabel: someVar} // In this context, this is a block statement with a label and expression, not an object literal
      
      function namedFunctionDeclaration () {}
      
      (function aGenuineIIFE () {}());
      
      f()
      
      a = 0
      
      new C
      
      delete a.b
      
      void a

      allowShortCircuit

      Examples of incorrect code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a || b

      Examples of correct code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a && b()
      a() || (b = c)

      allowTernary

      Examples of incorrect code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b : 0
      a ? b : c()

      Examples of correct code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b() : c()
      a ? (b = c) : d()

      allowShortCircuit and allowTernary

      Examples of correct code for the { "allowShortCircuit": true, "allowTernary": true } options:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true, "allowTernary": true }]*/
      
      a ? b() || (c = d) : e()

      allowTaggedTemplates

      Examples of incorrect code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      `some untagged template string`;

      Examples of correct code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      tag`some tagged template string`;

      Source: http://eslint.org/docs/rules/

      Expected an assignment or function call and instead saw an expression.
      Open

          "function" === typeof define && define.amd ? define(["jquery"], f) : "undefined" !== typeof module && module.exports ? module.exports = f(require("jquery")) : f(jQuery)

      Disallow Unused Expressions (no-unused-expressions)

      An unused expression which has no effect on the state of the program indicates a logic error.

      For example, n + 1; is not a syntax error, but it might be a typing mistake where a programmer meant an assignment statement n += 1; instead.

      Rule Details

      This rule aims to eliminate unused expressions which have no effect on the state of the program.

      This rule does not apply to function calls or constructor calls with the new operator, because they could have side effects on the state of the program.

      var i = 0;
      function increment() { i += 1; }
      increment(); // return value is unused, but i changed as a side effect
      
      var nThings = 0;
      function Thing() { nThings += 1; }
      new Thing(); // constructed object is unused, but nThings changed as a side effect

      This rule does not apply to directives (which are in the form of literal string expressions such as "use strict"; at the beginning of a script, module, or function).

      Sequence expressions (those using a comma, such as a = 1, b = 2) are always considered unused unless their return value is assigned or used in a condition evaluation, or a function call is made with the sequence expression value.

      Options

      This rule, in its default state, does not require any arguments. If you would like to enable one or more of the following you may pass an object with the options set as follows:

      • allowShortCircuit set to true will allow you to use short circuit evaluations in your expressions (Default: false).
      • allowTernary set to true will enable you to use ternary operators in your expressions similarly to short circuit evaluations (Default: false).
      • allowTaggedTemplates set to true will enable you to use tagged template literals in your expressions (Default: false).

      These options allow unused expressions only if all of the code paths either directly change the state (for example, assignment statement) or could have side effects (for example, function call).

      Examples of incorrect code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      0
      
      if(0) 0
      
      {0}
      
      f(0), {}
      
      a && b()
      
      a, b()
      
      c = a, b;
      
      a() && function namedFunctionInExpressionContext () {f();}
      
      (function anIncompleteIIFE () {});
      
      injectGlobal`body{ color: red; }`

      Note that one or more string expression statements (with or without semi-colons) will only be considered as unused if they are not in the beginning of a script, module, or function (alone and uninterrupted by other statements). Otherwise, they will be treated as part of a "directive prologue", a section potentially usable by JavaScript engines. This includes "strict mode" directives.

      "use strict";
      "use asm"
      "use stricter";
      "use babel"
      "any other strings like this in the prologue";

      Examples of correct code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      {} // In this context, this is a block statement, not an object literal
      
      {myLabel: someVar} // In this context, this is a block statement with a label and expression, not an object literal
      
      function namedFunctionDeclaration () {}
      
      (function aGenuineIIFE () {}());
      
      f()
      
      a = 0
      
      new C
      
      delete a.b
      
      void a

      allowShortCircuit

      Examples of incorrect code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a || b

      Examples of correct code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a && b()
      a() || (b = c)

      allowTernary

      Examples of incorrect code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b : 0
      a ? b : c()

      Examples of correct code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b() : c()
      a ? (b = c) : d()

      allowShortCircuit and allowTernary

      Examples of correct code for the { "allowShortCircuit": true, "allowTernary": true } options:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true, "allowTernary": true }]*/
      
      a ? b() || (c = d) : e()

      allowTaggedTemplates

      Examples of incorrect code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      `some untagged template string`;

      Examples of correct code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      tag`some tagged template string`;

      Source: http://eslint.org/docs/rules/

      Expected an assignment or function call and instead saw an expression.
      Open

                          b.limit && /^\d+$/.test(f[g]) && (f[g] = 0 >= f[g] ? 0 : Math.min(f[g], n));

      Disallow Unused Expressions (no-unused-expressions)

      An unused expression which has no effect on the state of the program indicates a logic error.

      For example, n + 1; is not a syntax error, but it might be a typing mistake where a programmer meant an assignment statement n += 1; instead.

      Rule Details

      This rule aims to eliminate unused expressions which have no effect on the state of the program.

      This rule does not apply to function calls or constructor calls with the new operator, because they could have side effects on the state of the program.

      var i = 0;
      function increment() { i += 1; }
      increment(); // return value is unused, but i changed as a side effect
      
      var nThings = 0;
      function Thing() { nThings += 1; }
      new Thing(); // constructed object is unused, but nThings changed as a side effect

      This rule does not apply to directives (which are in the form of literal string expressions such as "use strict"; at the beginning of a script, module, or function).

      Sequence expressions (those using a comma, such as a = 1, b = 2) are always considered unused unless their return value is assigned or used in a condition evaluation, or a function call is made with the sequence expression value.

      Options

      This rule, in its default state, does not require any arguments. If you would like to enable one or more of the following you may pass an object with the options set as follows:

      • allowShortCircuit set to true will allow you to use short circuit evaluations in your expressions (Default: false).
      • allowTernary set to true will enable you to use ternary operators in your expressions similarly to short circuit evaluations (Default: false).
      • allowTaggedTemplates set to true will enable you to use tagged template literals in your expressions (Default: false).

      These options allow unused expressions only if all of the code paths either directly change the state (for example, assignment statement) or could have side effects (for example, function call).

      Examples of incorrect code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      0
      
      if(0) 0
      
      {0}
      
      f(0), {}
      
      a && b()
      
      a, b()
      
      c = a, b;
      
      a() && function namedFunctionInExpressionContext () {f();}
      
      (function anIncompleteIIFE () {});
      
      injectGlobal`body{ color: red; }`

      Note that one or more string expression statements (with or without semi-colons) will only be considered as unused if they are not in the beginning of a script, module, or function (alone and uninterrupted by other statements). Otherwise, they will be treated as part of a "directive prologue", a section potentially usable by JavaScript engines. This includes "strict mode" directives.

      "use strict";
      "use asm"
      "use stricter";
      "use babel"
      "any other strings like this in the prologue";

      Examples of correct code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      {} // In this context, this is a block statement, not an object literal
      
      {myLabel: someVar} // In this context, this is a block statement with a label and expression, not an object literal
      
      function namedFunctionDeclaration () {}
      
      (function aGenuineIIFE () {}());
      
      f()
      
      a = 0
      
      new C
      
      delete a.b
      
      void a

      allowShortCircuit

      Examples of incorrect code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a || b

      Examples of correct code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a && b()
      a() || (b = c)

      allowTernary

      Examples of incorrect code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b : 0
      a ? b : c()

      Examples of correct code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b() : c()
      a ? (b = c) : d()

      allowShortCircuit and allowTernary

      Examples of correct code for the { "allowShortCircuit": true, "allowTernary": true } options:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true, "allowTernary": true }]*/
      
      a ? b() || (c = d) : e()

      allowTaggedTemplates

      Examples of incorrect code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      `some untagged template string`;

      Examples of correct code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      tag`some tagged template string`;

      Source: http://eslint.org/docs/rules/

      Expected '!==' and instead saw '!='.
      Open

                  isIframe = (window.location != window.parent.location) || (window.location.href.indexOf('CKEditor=content') != -1);

      Require === and !== (eqeqeq)

      It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

      The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

      • [] == false
      • [] == ![]
      • 3 == "03"

      If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

      Rule Details

      This rule is aimed at eliminating the type-unsafe equality operators.

      Examples of incorrect code for this rule:

      /*eslint eqeqeq: "error"*/
      
      if (x == 42) { }
      
      if ("" == text) { }
      
      if (obj.getStuff() != undefined) { }

      The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

      Options

      always

      The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

      Examples of incorrect code for the "always" option:

      /*eslint eqeqeq: ["error", "always"]*/
      
      a == b
      foo == true
      bananas != 1
      value == undefined
      typeof foo == 'undefined'
      'hello' != 'world'
      0 == 0
      true == true
      foo == null

      Examples of correct code for the "always" option:

      /*eslint eqeqeq: ["error", "always"]*/
      
      a === b
      foo === true
      bananas !== 1
      value === undefined
      typeof foo === 'undefined'
      'hello' !== 'world'
      0 === 0
      true === true
      foo === null

      This rule optionally takes a second argument, which should be an object with the following supported properties:

      • "null": Customize how this rule treats null literals. Possible values:
        • always (default) - Always use === or !==.
        • never - Never use === or !== with null.
        • ignore - Do not apply this rule to null.

      smart

      The "smart" option enforces the use of === and !== except for these cases:

      • Comparing two literal values
      • Evaluating the value of typeof
      • Comparing against null

      Examples of incorrect code for the "smart" option:

      /*eslint eqeqeq: ["error", "smart"]*/
      
      // comparing two variables requires ===
      a == b
      
      // only one side is a literal
      foo == true
      bananas != 1
      
      // comparing to undefined requires ===
      value == undefined

      Examples of correct code for the "smart" option:

      /*eslint eqeqeq: ["error", "smart"]*/
      
      typeof foo == 'undefined'
      'hello' != 'world'
      0 == 0
      true == true
      foo == null

      allow-null

      Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

      ["error", "always", {"null": "ignore"}]

      When Not To Use It

      If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

      Expected an assignment or function call and instead saw an expression.
      Open

                          !a && 1 < b.axis.length && (h === f[g] ? f = {} : u && (k(b.onAfterFirst), f = {}))

      Disallow Unused Expressions (no-unused-expressions)

      An unused expression which has no effect on the state of the program indicates a logic error.

      For example, n + 1; is not a syntax error, but it might be a typing mistake where a programmer meant an assignment statement n += 1; instead.

      Rule Details

      This rule aims to eliminate unused expressions which have no effect on the state of the program.

      This rule does not apply to function calls or constructor calls with the new operator, because they could have side effects on the state of the program.

      var i = 0;
      function increment() { i += 1; }
      increment(); // return value is unused, but i changed as a side effect
      
      var nThings = 0;
      function Thing() { nThings += 1; }
      new Thing(); // constructed object is unused, but nThings changed as a side effect

      This rule does not apply to directives (which are in the form of literal string expressions such as "use strict"; at the beginning of a script, module, or function).

      Sequence expressions (those using a comma, such as a = 1, b = 2) are always considered unused unless their return value is assigned or used in a condition evaluation, or a function call is made with the sequence expression value.

      Options

      This rule, in its default state, does not require any arguments. If you would like to enable one or more of the following you may pass an object with the options set as follows:

      • allowShortCircuit set to true will allow you to use short circuit evaluations in your expressions (Default: false).
      • allowTernary set to true will enable you to use ternary operators in your expressions similarly to short circuit evaluations (Default: false).
      • allowTaggedTemplates set to true will enable you to use tagged template literals in your expressions (Default: false).

      These options allow unused expressions only if all of the code paths either directly change the state (for example, assignment statement) or could have side effects (for example, function call).

      Examples of incorrect code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      0
      
      if(0) 0
      
      {0}
      
      f(0), {}
      
      a && b()
      
      a, b()
      
      c = a, b;
      
      a() && function namedFunctionInExpressionContext () {f();}
      
      (function anIncompleteIIFE () {});
      
      injectGlobal`body{ color: red; }`

      Note that one or more string expression statements (with or without semi-colons) will only be considered as unused if they are not in the beginning of a script, module, or function (alone and uninterrupted by other statements). Otherwise, they will be treated as part of a "directive prologue", a section potentially usable by JavaScript engines. This includes "strict mode" directives.

      "use strict";
      "use asm"
      "use stricter";
      "use babel"
      "any other strings like this in the prologue";

      Examples of correct code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      {} // In this context, this is a block statement, not an object literal
      
      {myLabel: someVar} // In this context, this is a block statement with a label and expression, not an object literal
      
      function namedFunctionDeclaration () {}
      
      (function aGenuineIIFE () {}());
      
      f()
      
      a = 0
      
      new C
      
      delete a.b
      
      void a

      allowShortCircuit

      Examples of incorrect code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a || b

      Examples of correct code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a && b()
      a() || (b = c)

      allowTernary

      Examples of incorrect code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b : 0
      a ? b : c()

      Examples of correct code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b() : c()
      a ? (b = c) : d()

      allowShortCircuit and allowTernary

      Examples of correct code for the { "allowShortCircuit": true, "allowTernary": true } options:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true, "allowTernary": true }]*/
      
      a ? b() || (c = d) : e()

      allowTaggedTemplates

      Examples of incorrect code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      `some untagged template string`;

      Examples of correct code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      tag`some tagged template string`;

      Source: http://eslint.org/docs/rules/

      Expected '!==' and instead saw '!='.
      Open

                  isIframe = (window.location != window.parent.location) || (window.location.href.indexOf('CKEditor=content') != -1);

      Require === and !== (eqeqeq)

      It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

      The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

      • [] == false
      • [] == ![]
      • 3 == "03"

      If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

      Rule Details

      This rule is aimed at eliminating the type-unsafe equality operators.

      Examples of incorrect code for this rule:

      /*eslint eqeqeq: "error"*/
      
      if (x == 42) { }
      
      if ("" == text) { }
      
      if (obj.getStuff() != undefined) { }

      The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

      Options

      always

      The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

      Examples of incorrect code for the "always" option:

      /*eslint eqeqeq: ["error", "always"]*/
      
      a == b
      foo == true
      bananas != 1
      value == undefined
      typeof foo == 'undefined'
      'hello' != 'world'
      0 == 0
      true == true
      foo == null

      Examples of correct code for the "always" option:

      /*eslint eqeqeq: ["error", "always"]*/
      
      a === b
      foo === true
      bananas !== 1
      value === undefined
      typeof foo === 'undefined'
      'hello' !== 'world'
      0 === 0
      true === true
      foo === null

      This rule optionally takes a second argument, which should be an object with the following supported properties:

      • "null": Customize how this rule treats null literals. Possible values:
        • always (default) - Always use === or !==.
        • never - Never use === or !== with null.
        • ignore - Do not apply this rule to null.

      smart

      The "smart" option enforces the use of === and !== except for these cases:

      • Comparing two literal values
      • Evaluating the value of typeof
      • Comparing against null

      Examples of incorrect code for the "smart" option:

      /*eslint eqeqeq: ["error", "smart"]*/
      
      // comparing two variables requires ===
      a == b
      
      // only one side is a literal
      foo == true
      bananas != 1
      
      // comparing to undefined requires ===
      value == undefined

      Examples of correct code for the "smart" option:

      /*eslint eqeqeq: ["error", "smart"]*/
      
      typeof foo == 'undefined'
      'hello' != 'world'
      0 == 0
      true == true
      foo == null

      allow-null

      Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

      ["error", "always", {"null": "ignore"}]

      When Not To Use It

      If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

      Expected an assignment or function call and instead saw an expression.
      Open

              "max" === a && (a = 9E9);

      Disallow Unused Expressions (no-unused-expressions)

      An unused expression which has no effect on the state of the program indicates a logic error.

      For example, n + 1; is not a syntax error, but it might be a typing mistake where a programmer meant an assignment statement n += 1; instead.

      Rule Details

      This rule aims to eliminate unused expressions which have no effect on the state of the program.

      This rule does not apply to function calls or constructor calls with the new operator, because they could have side effects on the state of the program.

      var i = 0;
      function increment() { i += 1; }
      increment(); // return value is unused, but i changed as a side effect
      
      var nThings = 0;
      function Thing() { nThings += 1; }
      new Thing(); // constructed object is unused, but nThings changed as a side effect

      This rule does not apply to directives (which are in the form of literal string expressions such as "use strict"; at the beginning of a script, module, or function).

      Sequence expressions (those using a comma, such as a = 1, b = 2) are always considered unused unless their return value is assigned or used in a condition evaluation, or a function call is made with the sequence expression value.

      Options

      This rule, in its default state, does not require any arguments. If you would like to enable one or more of the following you may pass an object with the options set as follows:

      • allowShortCircuit set to true will allow you to use short circuit evaluations in your expressions (Default: false).
      • allowTernary set to true will enable you to use ternary operators in your expressions similarly to short circuit evaluations (Default: false).
      • allowTaggedTemplates set to true will enable you to use tagged template literals in your expressions (Default: false).

      These options allow unused expressions only if all of the code paths either directly change the state (for example, assignment statement) or could have side effects (for example, function call).

      Examples of incorrect code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      0
      
      if(0) 0
      
      {0}
      
      f(0), {}
      
      a && b()
      
      a, b()
      
      c = a, b;
      
      a() && function namedFunctionInExpressionContext () {f();}
      
      (function anIncompleteIIFE () {});
      
      injectGlobal`body{ color: red; }`

      Note that one or more string expression statements (with or without semi-colons) will only be considered as unused if they are not in the beginning of a script, module, or function (alone and uninterrupted by other statements). Otherwise, they will be treated as part of a "directive prologue", a section potentially usable by JavaScript engines. This includes "strict mode" directives.

      "use strict";
      "use asm"
      "use stricter";
      "use babel"
      "any other strings like this in the prologue";

      Examples of correct code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      {} // In this context, this is a block statement, not an object literal
      
      {myLabel: someVar} // In this context, this is a block statement with a label and expression, not an object literal
      
      function namedFunctionDeclaration () {}
      
      (function aGenuineIIFE () {}());
      
      f()
      
      a = 0
      
      new C
      
      delete a.b
      
      void a

      allowShortCircuit

      Examples of incorrect code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a || b

      Examples of correct code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a && b()
      a() || (b = c)

      allowTernary

      Examples of incorrect code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b : 0
      a ? b : c()

      Examples of correct code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b() : c()
      a ? (b = c) : d()

      allowShortCircuit and allowTernary

      Examples of correct code for the { "allowShortCircuit": true, "allowTernary": true } options:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true, "allowTernary": true }]*/
      
      a ? b() || (c = d) : e()

      allowTaggedTemplates

      Examples of incorrect code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      `some untagged template string`;

      Examples of correct code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      tag`some tagged template string`;

      Source: http://eslint.org/docs/rules/

      'b' is already defined.
      Open

              var b = "client" + b, k = a.ownerDocument || a.document, l = k.documentElement, k = k.body;

      disallow variable redeclaration (no-redeclare)

      In JavaScript, it's possible to redeclare the same variable name using var. This can lead to confusion as to where the variable is actually declared and initialized.

      Rule Details

      This rule is aimed at eliminating variables that have multiple declarations in the same scope.

      Examples of incorrect code for this rule:

      /*eslint no-redeclare: "error"*/
      
      var a = 3;
      var a = 10;

      Examples of correct code for this rule:

      /*eslint no-redeclare: "error"*/
      
      var a = 3;
      // ...
      a = 10;

      Options

      This rule takes one optional argument, an object with a boolean property "builtinGlobals". It defaults to false. If set to true, this rule also checks redeclaration of built-in globals, such as Object, Array, Number...

      builtinGlobals

      Examples of incorrect code for the { "builtinGlobals": true } option:

      /*eslint no-redeclare: ["error", { "builtinGlobals": true }]*/
      
      var Object = 0;

      Examples of incorrect code for the { "builtinGlobals": true } option and the browser environment:

      /*eslint no-redeclare: ["error", { "builtinGlobals": true }]*/
      /*eslint-env browser*/
      
      var top = 0;

      The browser environment has many built-in global variables (for example, top). Some of built-in global variables cannot be redeclared. Source: http://eslint.org/docs/rules/

      'k' is already defined.
      Open

              var b = "client" + b, k = a.ownerDocument || a.document, l = k.documentElement, k = k.body;

      disallow variable redeclaration (no-redeclare)

      In JavaScript, it's possible to redeclare the same variable name using var. This can lead to confusion as to where the variable is actually declared and initialized.

      Rule Details

      This rule is aimed at eliminating variables that have multiple declarations in the same scope.

      Examples of incorrect code for this rule:

      /*eslint no-redeclare: "error"*/
      
      var a = 3;
      var a = 10;

      Examples of correct code for this rule:

      /*eslint no-redeclare: "error"*/
      
      var a = 3;
      // ...
      a = 10;

      Options

      This rule takes one optional argument, an object with a boolean property "builtinGlobals". It defaults to false. If set to true, this rule also checks redeclaration of built-in globals, such as Object, Array, Number...

      builtinGlobals

      Examples of incorrect code for the { "builtinGlobals": true } option:

      /*eslint no-redeclare: ["error", { "builtinGlobals": true }]*/
      
      var Object = 0;

      Examples of incorrect code for the { "builtinGlobals": true } option and the browser environment:

      /*eslint no-redeclare: ["error", { "builtinGlobals": true }]*/
      /*eslint-env browser*/
      
      var top = 0;

      The browser environment has many built-in global variables (for example, top). Some of built-in global variables cannot be redeclared. Source: http://eslint.org/docs/rules/

      Expected an assignment or function call and instead saw an expression.
      Open

                  d !== b && ($(a.elem)[a.prop](b), a._last = this.get(a))

      Disallow Unused Expressions (no-unused-expressions)

      An unused expression which has no effect on the state of the program indicates a logic error.

      For example, n + 1; is not a syntax error, but it might be a typing mistake where a programmer meant an assignment statement n += 1; instead.

      Rule Details

      This rule aims to eliminate unused expressions which have no effect on the state of the program.

      This rule does not apply to function calls or constructor calls with the new operator, because they could have side effects on the state of the program.

      var i = 0;
      function increment() { i += 1; }
      increment(); // return value is unused, but i changed as a side effect
      
      var nThings = 0;
      function Thing() { nThings += 1; }
      new Thing(); // constructed object is unused, but nThings changed as a side effect

      This rule does not apply to directives (which are in the form of literal string expressions such as "use strict"; at the beginning of a script, module, or function).

      Sequence expressions (those using a comma, such as a = 1, b = 2) are always considered unused unless their return value is assigned or used in a condition evaluation, or a function call is made with the sequence expression value.

      Options

      This rule, in its default state, does not require any arguments. If you would like to enable one or more of the following you may pass an object with the options set as follows:

      • allowShortCircuit set to true will allow you to use short circuit evaluations in your expressions (Default: false).
      • allowTernary set to true will enable you to use ternary operators in your expressions similarly to short circuit evaluations (Default: false).
      • allowTaggedTemplates set to true will enable you to use tagged template literals in your expressions (Default: false).

      These options allow unused expressions only if all of the code paths either directly change the state (for example, assignment statement) or could have side effects (for example, function call).

      Examples of incorrect code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      0
      
      if(0) 0
      
      {0}
      
      f(0), {}
      
      a && b()
      
      a, b()
      
      c = a, b;
      
      a() && function namedFunctionInExpressionContext () {f();}
      
      (function anIncompleteIIFE () {});
      
      injectGlobal`body{ color: red; }`

      Note that one or more string expression statements (with or without semi-colons) will only be considered as unused if they are not in the beginning of a script, module, or function (alone and uninterrupted by other statements). Otherwise, they will be treated as part of a "directive prologue", a section potentially usable by JavaScript engines. This includes "strict mode" directives.

      "use strict";
      "use asm"
      "use stricter";
      "use babel"
      "any other strings like this in the prologue";

      Examples of correct code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      {} // In this context, this is a block statement, not an object literal
      
      {myLabel: someVar} // In this context, this is a block statement with a label and expression, not an object literal
      
      function namedFunctionDeclaration () {}
      
      (function aGenuineIIFE () {}());
      
      f()
      
      a = 0
      
      new C
      
      delete a.b
      
      void a

      allowShortCircuit

      Examples of incorrect code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a || b

      Examples of correct code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a && b()
      a() || (b = c)

      allowTernary

      Examples of incorrect code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b : 0
      a ? b : c()

      Examples of correct code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b() : c()
      a ? (b = c) : d()

      allowShortCircuit and allowTernary

      Examples of correct code for the { "allowShortCircuit": true, "allowTernary": true } options:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true, "allowTernary": true }]*/
      
      a ? b() || (c = d) : e()

      allowTaggedTemplates

      Examples of incorrect code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      `some untagged template string`;

      Examples of correct code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      tag`some tagged template string`;

      Source: http://eslint.org/docs/rules/

      Expected an assignment or function call and instead saw an expression.
      Open

              "function" === typeof b && (b = {onAfter: b});

      Disallow Unused Expressions (no-unused-expressions)

      An unused expression which has no effect on the state of the program indicates a logic error.

      For example, n + 1; is not a syntax error, but it might be a typing mistake where a programmer meant an assignment statement n += 1; instead.

      Rule Details

      This rule aims to eliminate unused expressions which have no effect on the state of the program.

      This rule does not apply to function calls or constructor calls with the new operator, because they could have side effects on the state of the program.

      var i = 0;
      function increment() { i += 1; }
      increment(); // return value is unused, but i changed as a side effect
      
      var nThings = 0;
      function Thing() { nThings += 1; }
      new Thing(); // constructed object is unused, but nThings changed as a side effect

      This rule does not apply to directives (which are in the form of literal string expressions such as "use strict"; at the beginning of a script, module, or function).

      Sequence expressions (those using a comma, such as a = 1, b = 2) are always considered unused unless their return value is assigned or used in a condition evaluation, or a function call is made with the sequence expression value.

      Options

      This rule, in its default state, does not require any arguments. If you would like to enable one or more of the following you may pass an object with the options set as follows:

      • allowShortCircuit set to true will allow you to use short circuit evaluations in your expressions (Default: false).
      • allowTernary set to true will enable you to use ternary operators in your expressions similarly to short circuit evaluations (Default: false).
      • allowTaggedTemplates set to true will enable you to use tagged template literals in your expressions (Default: false).

      These options allow unused expressions only if all of the code paths either directly change the state (for example, assignment statement) or could have side effects (for example, function call).

      Examples of incorrect code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      0
      
      if(0) 0
      
      {0}
      
      f(0), {}
      
      a && b()
      
      a, b()
      
      c = a, b;
      
      a() && function namedFunctionInExpressionContext () {f();}
      
      (function anIncompleteIIFE () {});
      
      injectGlobal`body{ color: red; }`

      Note that one or more string expression statements (with or without semi-colons) will only be considered as unused if they are not in the beginning of a script, module, or function (alone and uninterrupted by other statements). Otherwise, they will be treated as part of a "directive prologue", a section potentially usable by JavaScript engines. This includes "strict mode" directives.

      "use strict";
      "use asm"
      "use stricter";
      "use babel"
      "any other strings like this in the prologue";

      Examples of correct code for the default { "allowShortCircuit": false, "allowTernary": false } options:

      /*eslint no-unused-expressions: "error"*/
      
      {} // In this context, this is a block statement, not an object literal
      
      {myLabel: someVar} // In this context, this is a block statement with a label and expression, not an object literal
      
      function namedFunctionDeclaration () {}
      
      (function aGenuineIIFE () {}());
      
      f()
      
      a = 0
      
      new C
      
      delete a.b
      
      void a

      allowShortCircuit

      Examples of incorrect code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a || b

      Examples of correct code for the { "allowShortCircuit": true } option:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
      
      a && b()
      a() || (b = c)

      allowTernary

      Examples of incorrect code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b : 0
      a ? b : c()

      Examples of correct code for the { "allowTernary": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
      
      a ? b() : c()
      a ? (b = c) : d()

      allowShortCircuit and allowTernary

      Examples of correct code for the { "allowShortCircuit": true, "allowTernary": true } options:

      /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true, "allowTernary": true }]*/
      
      a ? b() || (c = d) : e()

      allowTaggedTemplates

      Examples of incorrect code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      `some untagged template string`;

      Examples of correct code for the { "allowTaggedTemplates": true } option:

      /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
      
      tag`some tagged template string`;

      Source: http://eslint.org/docs/rules/

      Unnecessary semicolon.
      Open

      ;

      disallow unnecessary semicolons (no-extra-semi)

      Typing mistakes and misunderstandings about where semicolons are required can lead to semicolons that are unnecessary. While not technically an error, extra semicolons can cause confusion when reading code.

      Rule Details

      This rule disallows unnecessary semicolons.

      Examples of incorrect code for this rule:

      /*eslint no-extra-semi: "error"*/
      
      var x = 5;;
      
      function foo() {
          // code
      };

      Examples of correct code for this rule:

      /*eslint no-extra-semi: "error"*/
      
      var x = 5;
      
      var foo = function() {
          // code
      };

      When Not To Use It

      If you intentionally use extra semicolons then you can disable this rule.

      Related Rules

      Move the invocation into the parens that contain the function.
      Open

      (function (f) {

      Require IIFEs to be Wrapped (wrap-iife)

      You can immediately invoke function expressions, but not function declarations. A common technique to create an immediately-invoked function expression (IIFE) is to wrap a function declaration in parentheses. The opening parentheses causes the contained function to be parsed as an expression, rather than a declaration.

      // function expression could be unwrapped
      var x = function () { return { y: 1 };}();
      
      // function declaration must be wrapped
      function () { /* side effects */ }(); // SyntaxError

      Rule Details

      This rule requires all immediately-invoked function expressions to be wrapped in parentheses.

      Options

      This rule has two options, a string option and an object option.

      String option:

      • "outside" enforces always wrapping the call expression. The default is "outside".
      • "inside" enforces always wrapping the function expression.
      • "any" enforces always wrapping, but allows either style.

      Object option:

      • "functionPrototypeMethods": true additionally enforces wrapping function expressions invoked using .call and .apply. The default is false.

      outside

      Examples of incorrect code for the default "outside" option:

      /*eslint wrap-iife: ["error", "outside"]*/
      
      var x = function () { return { y: 1 };}(); // unwrapped
      var x = (function () { return { y: 1 };})(); // wrapped function expression

      Examples of correct code for the default "outside" option:

      /*eslint wrap-iife: ["error", "outside"]*/
      
      var x = (function () { return { y: 1 };}()); // wrapped call expression

      inside

      Examples of incorrect code for the "inside" option:

      /*eslint wrap-iife: ["error", "inside"]*/
      
      var x = function () { return { y: 1 };}(); // unwrapped
      var x = (function () { return { y: 1 };}()); // wrapped call expression

      Examples of correct code for the "inside" option:

      /*eslint wrap-iife: ["error", "inside"]*/
      
      var x = (function () { return { y: 1 };})(); // wrapped function expression

      any

      Examples of incorrect code for the "any" option:

      /*eslint wrap-iife: ["error", "any"]*/
      
      var x = function () { return { y: 1 };}(); // unwrapped

      Examples of correct code for the "any" option:

      /*eslint wrap-iife: ["error", "any"]*/
      
      var x = (function () { return { y: 1 };}()); // wrapped call expression
      var x = (function () { return { y: 1 };})(); // wrapped function expression

      functionPrototypeMethods

      Examples of incorrect code for this rule with the "inside", { "functionPrototypeMethods": true } options:

      /* eslint wrap-iife: [2, "inside", { functionPrototypeMethods: true }] */
      
      var x = function(){ foo(); }()
      var x = (function(){ foo(); }())
      var x = function(){ foo(); }.call(bar)
      var x = (function(){ foo(); }.call(bar))

      Examples of correct code for this rule with the "inside", { "functionPrototypeMethods": true } options:

      /* eslint wrap-iife: [2, "inside", { functionPrototypeMethods: true }] */
      
      var x = (function(){ foo(); })()
      var x = (function(){ foo(); }).call(bar)

      Source: http://eslint.org/docs/rules/

      Unexpected require().
      Open

          "function" === typeof define && define.amd ? define(["jquery"], f) : "undefined" !== typeof module && module.exports ? module.exports = f(require("jquery")) : f(jQuery)

      Enforce require() on the top-level module scope (global-require)

      In Node.js, module dependencies are included using the require() function, such as:

      var fs = require("fs");

      While require() may be called anywhere in code, some style guides prescribe that it should be called only in the top level of a module to make it easier to identify dependencies. For instance, it's arguably harder to identify dependencies when they are deeply nested inside of functions and other statements:

      function foo() {
      
          if (condition) {
              var fs = require("fs");
          }
      }

      Since require() does a synchronous load, it can cause performance problems when used in other locations.

      Further, ES6 modules mandate that import and export statements can only occur in the top level of the module's body.

      Rule Details

      This rule requires all calls to require() to be at the top level of the module, similar to ES6 import and export statements, which also can occur only at the top level.

      Examples of incorrect code for this rule:

      /*eslint global-require: "error"*/
      /*eslint-env es6*/
      
      // calling require() inside of a function is not allowed
      function readFile(filename, callback) {
          var fs = require('fs');
          fs.readFile(filename, callback)
      }
      
      // conditional requires like this are also not allowed
      if (DEBUG) { require('debug'); }
      
      // a require() in a switch statement is also flagged
      switch(x) { case '1': require('1'); break; }
      
      // you may not require() inside an arrow function body
      var getModule = (name) => require(name);
      
      // you may not require() inside of a function body as well
      function getModule(name) { return require(name); }
      
      // you may not require() inside of a try/catch block
      try {
          require(unsafeModule);
      } catch(e) {
          console.log(e);
      }

      Examples of correct code for this rule:

      /*eslint global-require: "error"*/
      
      // all these variations of require() are ok
      require('x');
      var y = require('y');
      var z;
      z = require('z').initialize();
      
      // requiring a module and using it in a function is ok
      var fs = require('fs');
      function readFile(filename, callback) {
          fs.readFile(filename, callback)
      }
      
      // you can use a ternary to determine which module to require
      var logger = DEBUG ? require('dev-logger') : require('logger');
      
      // if you want you can require() at the end of your module
      function doSomethingA() {}
      function doSomethingB() {}
      var x = require("x"),
          z = require("z");

      When Not To Use It

      If you have a module that must be initialized with information that comes from the file-system or if a module is only used in very rare situations and will cause significant overhead to load it may make sense to disable the rule. If you need to require() an optional dependency inside of a try/catch, you can disable this rule for just that dependency using the // eslint-disable-line global-require comment. Source: http://eslint.org/docs/rules/

      Wrap an immediate function invocation in parentheses.
      Open

      AC.Crud = function() {

      Require IIFEs to be Wrapped (wrap-iife)

      You can immediately invoke function expressions, but not function declarations. A common technique to create an immediately-invoked function expression (IIFE) is to wrap a function declaration in parentheses. The opening parentheses causes the contained function to be parsed as an expression, rather than a declaration.

      // function expression could be unwrapped
      var x = function () { return { y: 1 };}();
      
      // function declaration must be wrapped
      function () { /* side effects */ }(); // SyntaxError

      Rule Details

      This rule requires all immediately-invoked function expressions to be wrapped in parentheses.

      Options

      This rule has two options, a string option and an object option.

      String option:

      • "outside" enforces always wrapping the call expression. The default is "outside".
      • "inside" enforces always wrapping the function expression.
      • "any" enforces always wrapping, but allows either style.

      Object option:

      • "functionPrototypeMethods": true additionally enforces wrapping function expressions invoked using .call and .apply. The default is false.

      outside

      Examples of incorrect code for the default "outside" option:

      /*eslint wrap-iife: ["error", "outside"]*/
      
      var x = function () { return { y: 1 };}(); // unwrapped
      var x = (function () { return { y: 1 };})(); // wrapped function expression

      Examples of correct code for the default "outside" option:

      /*eslint wrap-iife: ["error", "outside"]*/
      
      var x = (function () { return { y: 1 };}()); // wrapped call expression

      inside

      Examples of incorrect code for the "inside" option:

      /*eslint wrap-iife: ["error", "inside"]*/
      
      var x = function () { return { y: 1 };}(); // unwrapped
      var x = (function () { return { y: 1 };}()); // wrapped call expression

      Examples of correct code for the "inside" option:

      /*eslint wrap-iife: ["error", "inside"]*/
      
      var x = (function () { return { y: 1 };})(); // wrapped function expression

      any

      Examples of incorrect code for the "any" option:

      /*eslint wrap-iife: ["error", "any"]*/
      
      var x = function () { return { y: 1 };}(); // unwrapped

      Examples of correct code for the "any" option:

      /*eslint wrap-iife: ["error", "any"]*/
      
      var x = (function () { return { y: 1 };}()); // wrapped call expression
      var x = (function () { return { y: 1 };})(); // wrapped function expression

      functionPrototypeMethods

      Examples of incorrect code for this rule with the "inside", { "functionPrototypeMethods": true } options:

      /* eslint wrap-iife: [2, "inside", { functionPrototypeMethods: true }] */
      
      var x = function(){ foo(); }()
      var x = (function(){ foo(); }())
      var x = function(){ foo(); }.call(bar)
      var x = (function(){ foo(); }.call(bar))

      Examples of correct code for this rule with the "inside", { "functionPrototypeMethods": true } options:

      /* eslint wrap-iife: [2, "inside", { functionPrototypeMethods: true }] */
      
      var x = (function(){ foo(); })()
      var x = (function(){ foo(); }).call(bar)

      Source: http://eslint.org/docs/rules/

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  isIframe = (window.location != window.parent.location) || (window.location.href.indexOf('CKEditor=content') != -1);
      Severity: Minor
      Found in core/modules/_core/res/js/crud/default.js and 1 other location - About 40 mins to fix
      core/modules/_core/res/js/crud/edit.js on lines 29..29

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status