Sign upLogin

naoufal/react-native-apple-pay

View on GitHub
Star
js/PaymentRequest/PaymentRequestUpdateEvent.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function _handleDetailsChange has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  _handleDetailsChange(value: PaymentDetailsBase) {
    const target = this.target;

    validateTotal(value.total, DOMException);
    validateDisplayItems(value.displayItems, DOMException);
Severity: Minor
Found in js/PaymentRequest/PaymentRequestUpdateEvent.js - About 1 hr to fix

    Function updateWith has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async updateWith(
    PaymentDetailsModifierOrPromise:
      | PaymentDetailsUpdate
      | ((
          PaymentDetailsModifier,
    Severity: Minor
    Found in js/PaymentRequest/PaymentRequestUpdateEvent.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

                if (
            target._details.shippingOptions
            && target._details.shippingOptions.length > 0
            && value.shippingOptions
            && ((value.shippingOptions.find(op => op.selected) || {}).id || null) !== target._shippingOption
      Severity: Major
      Found in js/PaymentRequest/PaymentRequestUpdateEvent.js - About 40 mins to fix

        Function updateWith has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          async updateWith(
    PaymentDetailsModifierOrPromise:
      | PaymentDetailsUpdate
      | ((
          PaymentDetailsModifier,
        Severity: Minor
        Found in js/PaymentRequest/PaymentRequestUpdateEvent.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status