Sign upLogin

nathanhammond/ember-route-alias

View on GitHub
Star

Showing 5 of 5 total issues

Function patchRoute has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

function patchRoute(lookup) {
  // Save off the original method in scope of the prototype modifications.
  let originalRouteMethod = Ember.RouterDSL.prototype.route;

  // We need to do a few things before and after the original route function.
Severity: Minor
Found in addon/initializers/route-alias.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function patchRoute has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function patchRoute(lookup) {
  // Save off the original method in scope of the prototype modifications.
  let originalRouteMethod = Ember.RouterDSL.prototype.route;

  // We need to do a few things before and after the original route function.
Severity: Minor
Found in addon/initializers/route-alias.js - About 1 hr to fix

    Function route has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      Ember.RouterDSL.prototype.route = function(name, options, callback) {
    Ember.assert('You may not include a "." in your route name.', !~name.indexOf('.'));

    // Method signature identification from the original method.
    if (arguments.length === 2 && typeof options === 'function') {
    Severity: Minor
    Found in addon/initializers/route-alias.js - About 1 hr to fix

      Function _process has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        _process(base, targetRouteName) {
    let nextBase, nextTarget, result;

    if (targetRouteName === '' || targetRouteName === './') {
      // Support non-traversing paths.
      Severity: Minor
      Found in addon/mixins/rel-link-to.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function aliasedModuleName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        aliasedModuleName(parsedName) {
    // Short circuit if you're not aliased or a type we care about for aliasing.
    if (!this.namespace || !this.namespace._routeAliasLookup) { return false; }
    if (!~['controller','route','template','view'].indexOf(parsedName.type)) { return false; }
      Severity: Minor
      Found in addon/mixins/route-alias-resolver.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language