ncbo/bioportal_web_ui

View on GitHub
app/assets/javascripts/bp_crossdomain_autocomplete.js

Summary

Maintainability
F
1 mo
Test Coverage

Function bp_autocomplete has 371 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    jQuery.bp_autocomplete = function(input, options) {
      // Create a link to self
      var me = this;

      // Create jQuery object for input element
Severity: Major
Found in app/assets/javascripts/bp_crossdomain_autocomplete.js - About 1 day to fix

    File bp_crossdomain_autocomplete.js has 414 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Generally we use jQuery as the keyword but some people
    // will use another framework which takes control of the $.
    // To avoid re-writing this script we'll use a wrapper.
    (function($) {
      $(function() {
    Severity: Minor
    Found in app/assets/javascripts/bp_crossdomain_autocomplete.js - About 5 hrs to fix

      Function dataToDom has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            function dataToDom(data) {
              var ul = document.createElement("ul");
              var num = data.length;
      
              // limited results to a max number
      Severity: Minor
      Found in app/assets/javascripts/bp_crossdomain_autocomplete.js - About 1 hr to fix

        Function bp_autocomplete has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            jQuery.fn.bp_autocomplete = function(url, options, data) {
              // Make sure options exists
              options = options || {};
              // Set url as option
              options.url = url;
        Severity: Minor
        Found in app/assets/javascripts/bp_crossdomain_autocomplete.js - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                          if (matchSubset(x0, q)) {
                            csub[csub.length] = x;
                          }
          Severity: Major
          Found in app/assets/javascripts/bp_crossdomain_autocomplete.js - About 45 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            (function($) {
              $(function() {
                jQuery.bp_autocomplete = function(input, options) {
                  // Create a link to self
                  var me = this;
            Severity: Major
            Found in app/assets/javascripts/bp_crossdomain_autocomplete.js and 1 other location - About 1 mo to fix
            public/javascripts/bp_crossdomain_autocomplete.js on lines 4..533

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 4951.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status