Sign upLogin

ncbo/bioportal_web_ui

View on GitHub
Star
app/assets/javascripts/bp_recommender.js

Summary

Maintainability
F
4 days
Test Coverage

Function getRecommendations has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

rec.getRecommendations = function() {
    rec.hideErrorMessages();
    var errors = false;
    // Checks if the input text field is empty
    if (($("#inputText").val().length == 0) || (rec.emptyInput==true))  {
Severity: Minor
Found in app/assets/javascripts/bp_recommender.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getRecommendations has 173 lines of code (exceeds 25 allowed). Consider refactoring.
Open

rec.getRecommendations = function() {
    rec.hideErrorMessages();
    var errors = false;
    // Checks if the input text field is empty
    if (($("#inputText").val().length == 0) || (rec.emptyInput==true))  {
Severity: Major
Found in app/assets/javascripts/bp_recommender.js - About 6 hrs to fix

    Function success has 104 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                success: function(data) {
                $('.recommenderSpinner').hide();
                if (data) {
                    if (data.length > 0) {
                        $("#recommender-results").empty();
    Severity: Major
    Found in app/assets/javascripts/bp_recommender.js - About 4 hrs to fix

      File bp_recommender.js has 313 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      // Namespace for global variables and functions
var rec = { }
rec.maxInputWords = 500;

rec.showOrHideAdvancedOptions = function() {
      Severity: Minor
      Found in app/assets/javascripts/bp_recommender.js - About 3 hrs to fix

        Function getHighlightedTerms has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        rec.getHighlightedTerms = function(data, rowNumber) {
    var inputText = document.getElementById("inputText").value;
    var newText = '';
    var lastPosition = 0;
    var ontologyIds = [ ];
        Severity: Minor
        Found in app/assets/javascripts/bp_recommender.js - About 1 hr to fix

          Avoid deeply nested control flow statements.
          Open

                                          if (params.output_type == 2) {
                                    ontologyLinkStyle = 'style="color: ' + rec.colors[j] + '"';
                                }
          Severity: Major
          Found in app/assets/javascripts/bp_recommender.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                            if ($this.is(':checked')) {
                                    // Deselect all the rest checkboxes
                                    for (var j = 0; j < data.length; j++) {
                                        if (j!=$rowNumber) {
                                            $("#chk" + j).prop('checked', false);
            Severity: Major
            Found in app/assets/javascripts/bp_recommender.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                          for (var j = 0; j < data[i].coverageResult.annotations.length; j++) {
                                terms += ('<a target="_blank" href=' + data[i].coverageResult.annotations[j].annotatedClass.links.ui + '>' + data[i].coverageResult.annotations[j].text + '</a>, ');
                            }
              Severity: Major
              Found in app/assets/javascripts/bp_recommender.js - About 45 mins to fix

                Function getHighlightedTerms has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                rec.getHighlightedTerms = function(data, rowNumber) {
    var inputText = document.getElementById("inputText").value;
    var newText = '';
    var lastPosition = 0;
    var ontologyIds = [ ];
                Severity: Minor
                Found in app/assets/javascripts/bp_recommender.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                rec.insertSampleKeywords = function() {
    rec.enableEdition();
    var text = "Backpain, White blood cell, Carcinoma, Cavity of stomach, Ductal Carcinoma in Situ, Adjuvant chemotherapy, Axillary lymph node staging, Mastectomy, tamoxifen, serotonin reuptake inhibitors, Invasive Breast Cancer, hormone receptor positive breast cancer, ovarian ablation, premenopausal women, surgical management, biopsy of breast tumor, Fine needle aspiration, entinel lymph node, breast preservation, adjuvant radiation therapy, prechemotherapy, Inflammatory Breast Cancer, ovarian failure, Bone scan, lumpectomy, brain metastases, pericardial effusion, aromatase inhibitor, postmenopausal, Palliative care, Guidelines, Stage IV breast cancer disease, Trastuzumab, Breast MRI examination";
    jQuery("#inputText").focus();
    jQuery("#inputText").val(text);
                Severity: Major
                Found in app/assets/javascripts/bp_recommender.js and 1 other location - About 2 hrs to fix
                app/assets/javascripts/bp_recommender.js on lines 42..49

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 92.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                rec.insertSampleText = function() {
    rec.enableEdition();
    var text = 'Primary treatment of DCIS now includes 3 options: lumpectomy without lymph node surgery plus whole breast radiation (category 1); total mastectomy with or without sentinel node biopsy with or without reconstruction (category 2A); lumpectomy without lymph node surgery without radiation (category 2B). Workup for patients with clinical stage l, llA, llB, or T3,N1,M0 disease was reorganized to distinguish optional additional studies from those recommended for all of these patients. Recommendation for locoregional treatment for patients with clinical stage l, llA, llB, or T3,N1,M0 disease with 1-3 positive axillary nodes following total mastectomy was changed from "Consider" to "Strongly consider" postmastectomy radiation therapy. ';
    jQuery("#inputText").focus();
    jQuery("#inputText").val(text);
                Severity: Major
                Found in app/assets/javascripts/bp_recommender.js and 1 other location - About 2 hrs to fix
                app/assets/javascripts/bp_recommender.js on lines 51..58

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 92.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                rec.showOrHideAdvancedOptions = function() {
  $("#advancedOptions").toggle();
  var text = $("#advancedOptions").is(':visible') ? "Hide advanced options <<" : "Show advanced options >>";
  $("#advancedOptionsLink").text(text);
}
                Severity: Major
                Found in app/assets/javascripts/bp_recommender.js and 1 other location - About 1 hr to fix
                app/assets/javascripts/bp_annotatorplus.js on lines 881..885

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status