ncbo/bioportal_web_ui

View on GitHub

Showing 306 of 628 total issues

Method create has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create
    params[:mappings] ||= []
    params[:max_level] ||= 0
    params[:ontologies] ||= []
    params[:semantic_types] ||= []
Severity: Major
Found in app/controllers/annotatorplus_controller.rb - About 2 hrs to fix

    Function jumpTo_formatItem has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function jumpTo_formatItem(row) {
        var specials = new RegExp("[.*+?|()\\[\\]{}\\\\]", "g"), // .*+?|()[]{}\
            keywords = jQuery(jumpTo_searchBoxSelector).val().trim().replace(specials, "\\$&").split(' ').join('|'),
            regex = new RegExp('(' + keywords + ')', 'gi');
        var resultTypeSpan = jQuery("<span>");
    Severity: Major
    Found in public/javascripts/widgets/quick_jump.js - About 2 hrs to fix

      Method show has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def show
          # Hack to make ontologyid and conceptid work in addition to id and ontology params
          params[:id] = params[:id].nil? ? params[:ontologyid] : params[:id]
          params[:ontology] = params[:ontology].nil? ? params[:id] : params[:ontology]
      
      
      Severity: Major
      Found in app/controllers/ontologies_controller.rb - About 2 hrs to fix

        Method concept_properties2hash has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
        Open

          def concept_properties2hash(properties)
            # NOTE: example properties
            #
            # properties
            #=> #<struct
        Severity: Minor
        Found in app/helpers/concepts_helper.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function $Browser has 60 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        angular.mock.$Browser = function() {
          var self = this;
        
          this.isMock = true;
          self.$$url = "http://server/";
        Severity: Major
        Found in public/browse/lib/angular-mocks/angular-mocks.js - About 2 hrs to fix

          Method get_class has 60 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def get_class(params)
          
              if @ontology.flat?
          
                ignore_concept_param = params[:conceptid].nil? ||
          Severity: Major
          Found in app/controllers/application_controller.rb - About 2 hrs to fix

            Function get_annotations has 59 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function get_annotations() {
              jQuery("#results_error").html("");
              jQuery("#annotator_error").html("");
            
              // Validation
            Severity: Major
            Found in app/assets/javascripts/bp_annotator.js - About 2 hrs to fix

              File quick_jump.js has 264 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              // jQuery check, if it's not present then include it
              // jQuery check, if it's not present then include it
              function bpMinVersion(min, actual) {
                function parseVersionString (str) {
                  if (typeof(str) != 'string') { return false; }
              Severity: Minor
              Found in public/javascripts/widgets/quick_jump.js - About 2 hrs to fix

                Class AdminController has 22 methods (exceeds 20 allowed). Consider refactoring.
                Open

                class AdminController < ApplicationController
                  layout :determine_layout
                  before_action :cache_setup
                
                  DEBUG_BLACKLIST = [:"$,", :$ADDITIONAL_ONTOLOGY_DETAILS, :$rdebug_state, :$PROGRAM_NAME, :$LOADED_FEATURES, :$KCODE, :$-i, :$rails_rake_task, :$$, :$gems_build_rake_task, :$daemons_stop_proc, :$VERBOSE, :$DAEMONS_ARGV, :$daemons_sigterm, :$DEBUG_BEFORE, :$stdout, :$-0, :$-l, :$-I, :$DEBUG, :$', :$gems_rake_task, :$_, :$CODERAY_DEBUG, :$-F, :$", :$0, :$=, :$FILENAME, :$?, :$!, :$rdebug_in_irb, :$-K, :$TESTING, :$fileutils_rb_have_lchmod, :$EMAIL_EXCEPTIONS, :$binding, :$-v, :$>, :$SAFE, :$/, :$fileutils_rb_have_lchown, :$-p, :$-W, :$:, :$__dbg_interface, :$stderr, :$\, :$&, :$<, :$debug, :$;, :$~, :$-a, :$DEBUG_RDOC, :$CGI_ENV, :$LOAD_PATH, :$-d, :$*, :$., :$-w, :$+, :$@, :$`, :$stdin, :$1, :$2, :$3, :$4, :$5, :$6, :$7, :$8, :$9]
                Severity: Minor
                Found in app/controllers/admin_controller.rb - About 2 hrs to fix

                  Function update_annotations_table has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function update_annotations_table(rowsArray) {
                    "use strict";
                    var ontologies = {},
                      classes = {},
                      match_types = {},
                  Severity: Major
                  Found in app/assets/javascripts/bp_annotator.js - About 2 hrs to fix

                    Function update_annotations_table has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function update_annotations_table(rowsArray) {
                      "use strict";
                      var ontologies = {},
                        classes = {},
                        match_types = {},
                    Severity: Major
                    Found in app/assets/javascripts/bp_annotatorplus.js - About 2 hrs to fix

                      File admin_controller.rb has 263 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      class AdminController < ApplicationController
                        layout :determine_layout
                        before_action :cache_setup
                      
                        DEBUG_BLACKLIST = [:"$,", :$ADDITIONAL_ONTOLOGY_DETAILS, :$rdebug_state, :$PROGRAM_NAME, :$LOADED_FEATURES, :$KCODE, :$-i, :$rails_rake_task, :$$, :$gems_build_rake_task, :$daemons_stop_proc, :$VERBOSE, :$DAEMONS_ARGV, :$daemons_sigterm, :$DEBUG_BEFORE, :$stdout, :$-0, :$-l, :$-I, :$DEBUG, :$', :$gems_rake_task, :$_, :$CODERAY_DEBUG, :$-F, :$", :$0, :$=, :$FILENAME, :$?, :$!, :$rdebug_in_irb, :$-K, :$TESTING, :$fileutils_rb_have_lchmod, :$EMAIL_EXCEPTIONS, :$binding, :$-v, :$>, :$SAFE, :$/, :$fileutils_rb_have_lchown, :$-p, :$-W, :$:, :$__dbg_interface, :$stderr, :$\, :$&, :$<, :$debug, :$;, :$~, :$-a, :$DEBUG_RDOC, :$CGI_ENV, :$LOAD_PATH, :$-d, :$*, :$., :$-w, :$+, :$@, :$`, :$stdin, :$1, :$2, :$3, :$4, :$5, :$6, :$7, :$8, :$9]
                      Severity: Minor
                      Found in app/controllers/admin_controller.rb - About 2 hrs to fix

                        Function $httpBackend has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          function $httpBackend(method, url, data, callback, headers, timeout, withCredentials) {
                            var xhr = new MockXhr(),
                                expectation = expectations[0],
                                wasExpected = false;
                        
                        
                        Severity: Major
                        Found in public/browse/lib/angular-mocks/angular-mocks.js - About 2 hrs to fix

                          Function onSuccessAction has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          AjaxAction.prototype.onSuccessAction = function(data, ontology, deferredObj) {
                            var self = this;
                            if (!self.isLongOperation) {
                              return;
                            }
                          Severity: Major
                          Found in app/assets/javascripts/bp_admin.js - About 2 hrs to fix

                            Function formComplete_formatItem has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                            Open

                            function formComplete_formatItem(row) {
                            
                                var input = this.extraParams.input;
                                var BP_include_definitions = jQuery(input).attr("data-bp_include_definitions");
                                if (typeof BP_include_definitions === "undefined") {
                            Severity: Minor
                            Found in public/javascripts/widgets/form_complete.js - About 2 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Method feedback has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                            Open

                              def feedback
                                # Show the header/footer or not
                                feedback_layout = params[:pop].eql?('true') ? 'popup' : 'ontology'
                            
                                # We're using a hidden form field to trigger for error checking
                            Severity: Minor
                            Found in app/controllers/home_controller.rb - About 2 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function get_annotations has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
                            Open

                            function get_annotations() {
                              jQuery("#results_error").html("");
                              jQuery("#annotator_error").html("");
                            
                              // Validation
                            Severity: Minor
                            Found in app/assets/javascripts/bp_annotatorplus.js - About 2 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function setClass has 56 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                    setClass: function(element, add, remove, options) {
                                      options = parseAnimateOptions(options);
                            
                                      var STORAGE_KEY = '$$animateClasses';
                                      element = angular.element(element);
                            Severity: Major
                            Found in public/browse/lib/angular-animate/angular-animate.js - About 2 hrs to fix

                              Function setTreeNodes has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  var setTreeNodes = function(obj, useParent) {
                                    obj = useParent ? obj.parent() : obj;
                                    $('li>a', obj).addClass('text').bind('selectstart', function() {
                                      return false;
                                    }).click(function() {
                              Severity: Major
                              Found in public/widgets/jquery.ncbo.tree-2.0.0.js - About 2 hrs to fix

                                Function runSuggest has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                      function runSuggest(e) {
                                        var search = function(searchData) {
                                          if (this.value.length < settings.minCharacters) {
                                            clearAndHideResults();
                                            return false;
                                Severity: Major
                                Found in public/widgets/jquery.ncbo.autocomplete.js - About 2 hrs to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language