Sign upLogin

nebijokit/omniva

View on GitHub
Star

Showing 3 of 3 total issues

Method createShipment has 104 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function createShipment(Parcel $parcel): stdClass
    {
        $writer = new XMLWriter;
        $writer->openMemory();
Severity: Major
Found in src/Client.php - About 4 hrs to fix

    Parcel has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Parcel
{
    /**
     * weight in kilograms
     */
    Severity: Minor
    Found in src/Parcel.php - About 2 hrs to fix

      Function createShipment has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          public function createShipment(Parcel $parcel): stdClass
    {
        $writer = new XMLWriter;
        $writer->openMemory();
      Severity: Minor
      Found in src/Client.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language